- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: checkstyle: Reformat one liner methods
by tnisan＠redhat.com 14 Jul '15

14 Jul '15

Tal Nisan has submitted this change and it was merged. Change subject: checkstyle: Reformat one liner methods ...................................................................... checkstyle: Reformat one liner methods Reformat one liner methods to fit the project standards Change-Id: I189520de7cc5d5e07c6685443138d1d1354d4ee8 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanError.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanErrorWrapper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StopVmParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DestroyVmVDSCommandParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/FenceConfigValueHelperTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingVmInstanceTypeManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 11 files changed, 88 insertions(+), 29 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Vered Volansky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I189520de7cc5d5e07c6685443138d1d1354d4ee8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: move ADMIN_PASSWORD from global setup to e...
by sbonazzo＠redhat.com 14 Jul '15

14 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: move ADMIN_PASSWORD from global setup to engine specific ...................................................................... packaging: setup: move ADMIN_PASSWORD from global setup to engine specific probably a left over. Change-Id: I359378c6efaaa1330a0be10d999c56cfe9aedbba Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsmi.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py 4 files changed, 13 insertions(+), 13 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43584 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I359378c6efaaa1330a0be10d999c56cfe9aedbba Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: remove unused method signature from VdsServerConnector
by derez＠redhat.com 14 Jul '15

14 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: core: remove unused method signature from VdsServerConnector ...................................................................... core: remove unused method signature from VdsServerConnector Remove unused registerSecrets method signature from VdsServerConnector. Change-Id: I22e6340f1e17412c19a54ff93b6c5d42999c0dc8 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43598 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22e6340f1e17412c19a54ff93b6c5d42999c0dc8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add missing audit log severities to OVF_STORE audit log.
by mlipchuk＠redhat.com 14 Jul '15

14 Jul '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add missing audit log severities to OVF_STORE audit log. ...................................................................... core: Add missing audit log severities to OVF_STORE audit log. Change-Id: Ibe4ab285a26e5efc35999f971269beb62c48473e Bug-Url: https://bugzilla.redhat.com/1242948 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Passed CI tests Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe4ab285a26e5efc35999f971269beb62c48473e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Block adding Cinder with same URL.
by mlipchuk＠redhat.com 14 Jul '15

14 Jul '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Block adding Cinder with same URL. ...................................................................... core: Block adding Cinder with same URL. Adding the same Cinder provider should be blocked. Change-Id: I67c15559d00a992ffc4b2e6b1836339300acc171 Bug-Url: https://bugzilla.redhat.com/1242944 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/CinderProviderValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 24 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/43567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67c15559d00a992ffc4b2e6b1836339300acc171 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Spy validator directly
by amureini＠redhat.com 14 Jul '15

14 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Spy validator directly ...................................................................... core: Spy validator directly Fixed RemoveStorageDomainCommandTest to spy the StorageDomainToPoolRelationValidator it uses directly, instead of mocking its internal DAO calls. This way, RemoveStorageDomainCommandTest actually tests the logic in RemoveStorageDomainCommand instead of testing the internal implementation of the validatiors it uses. Change-Id: I23276e19bae974075f5438b421a4f5b7f37a3d79 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java 1 file changed, 3 insertions(+), 22 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23276e19bae974075f5438b421a4f5b7f37a3d79 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Data member modifiers
by amureini＠redhat.com 14 Jul '15

14 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Data member modifiers ...................................................................... core: Data member modifiers Made the members of StorageHandlingCommandBaseTest private as per Java and JUnit's best practices. Change-Id: Ia91702de4bc8d8ddebb5b2b7239feaeecd07712f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia91702de4bc8d8ddebb5b2b7239feaeecd07712f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Removed useless data memebers
by amureini＠redhat.com 14 Jul '15

14 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed useless data memebers ...................................................................... core: Removed useless data memebers The attachedDomains and isoMap members are constant empty maps. Since they are never changed, there's no point in holding them as data members. Instead, where they are used as mock return values, and inline call to Collections.emptyList() is clearer, and leaves less room for potential mistakes in the future. Change-Id: I03d3b2109ef7939cf7ad7c77f6a7b0b214b3bf67 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03d3b2109ef7939cf7ad7c77f6a7b0b214b3bf67 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove useless DbFacade mocking
by amureini＠redhat.com 14 Jul '15

14 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove useless DbFacade mocking ...................................................................... core: Remove useless DbFacade mocking Removed useless mocking of DbFacade from StorageHandlingCommandBaseTest. The DAOs are mocked directly, and mocking the DbFacade does nothing but redundantly expose implementation details to the test. Change-Id: I4dd520dbf7fa5907b22bc6053b1658e316dfc84c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 1 file changed, 8 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dd520dbf7fa5907b22bc6053b1658e316dfc84c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove useless DbFacade mocking
by amureini＠redhat.com 14 Jul '15

14 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove useless DbFacade mocking ...................................................................... core: Remove useless DbFacade mocking Removed useless mocking of DbFacade from AddExistingBlockStorageDomainCommandTest. The DAOs are mocked directly, and mocking the DbFacade does nothing but redundantly expose implementation details to the test. Change-Id: I47338c264b8ea9392f1ef4dd939727b94cefb158 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47338c264b8ea9392f1ef4dd939727b94cefb158 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0