- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: invoke freeze and thaw for cinder disks
by derez＠redhat.com 14 Jul '15

14 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: core: invoke freeze and thaw for cinder disks ...................................................................... core: invoke freeze and thaw for cinder disks Invoke freeze/thaw on live snapshot with Cinder disks. Change-Id: I01d3af3cff290c2e1fc6b2ddabc3715fde84713a Bug-Url: https://bugzilla.redhat.com/1240636 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 82 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43283 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01d3af3cff290c2e1fc6b2ddabc3715fde84713a Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: added AuditLog messages for freeze and thaw
by derez＠redhat.com 14 Jul '15

14 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: core: added AuditLog messages for freeze and thaw ...................................................................... core: added AuditLog messages for freeze and thaw Adding AuditLog warnings for failure in freeze/thaw. Change-Id: Ifc4379136c6a5b5c8084370857c2affc7047390b Bug-Url: https://bugzilla.redhat.com/1240636 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43282 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc4379136c6a5b5c8084370857c2affc7047390b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: EngineError - add freeze and thaw errors
by derez＠redhat.com 14 Jul '15

14 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: core: EngineError - add freeze and thaw errors ...................................................................... core: EngineError - add freeze and thaw errors Added vdsm errors relevant to freeze/thaw API. Change-Id: I8c29c3ec18dac9a3b86ab9c538766fe83af7a8a4 Bug-Url: https://bugzilla.redhat.com/1240636 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java 3 files changed, 15 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c29c3ec18dac9a3b86ab9c538766fe83af7a8a4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: introduce ThawVdsCommand
by derez＠redhat.com 14 Jul '15

14 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: core: introduce ThawVdsCommand ...................................................................... core: introduce ThawVdsCommand Added ThawVdsCommand and updates VdsServer files accordingly. Change-Id: Id07f0515f82716df9ad5b89db8ffa915c8df0ea0 Bug-Url: https://bugzilla.redhat.com/1240636 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ThawVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 6 files changed, 40 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Passed CI tests Maor Lipchuk: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43280 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id07f0515f82716df9ad5b89db8ffa915c8df0ea0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: introduce FreezeVdsCommand
by derez＠redhat.com 14 Jul '15

14 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: core: introduce FreezeVdsCommand ...................................................................... core: introduce FreezeVdsCommand Added FreezeVdsCommand and updates VdsServer files accordingly. Change-Id: I5dbe773457256da5b8e94815294afc38bd5dade9 Bug-Url: https://bugzilla.redhat.com/1240636 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FreezeVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 6 files changed, 40 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43279 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5dbe773457256da5b8e94815294afc38bd5dade9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: vm-like dialogs: name validation fixed
by tjelinek＠redhat.com 14 Jul '15

14 Jul '15

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: vm-like dialogs: name validation fixed ...................................................................... webadmin: vm-like dialogs: name validation fixed * UnitVmModel.validate() and UnitVmModel.validateHwPart() collided - both fired ValidationCompleteEvent * Allowed characters validation fix - name was always validated as pool name (allowing '?' char) * Pool name length validation reflects presence of '?' in the name Change-Id: Iabfe10fea10d89ca1f8aabce0f2e604e95f3d9ce Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1236267 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/instancetypes/InstanceTypeListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NonClusterModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/ExistingPoolNameLengthValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NewPoolNameLengthValidation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/PoolNameLengthValidation.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/ExistingPoolNameLengthValidationTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 13 files changed, 161 insertions(+), 58 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43510 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabfe10fea10d89ca1f8aabce0f2e604e95f3d9ce Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: VdsBrokerObjectsBuilder Naming conventions
by amureini＠redhat.com 14 Jul '15

14 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: VdsBrokerObjectsBuilder Naming conventions ...................................................................... core: VdsBrokerObjectsBuilder Naming conventions Fixed method names to lowerCamelCase, as per Java conventions. This patch fixes the FindBugs warning NM_METHOD_NAMING_CONVENTION reported on this class. Change-Id: I4dfa7e913e9c117444e54a940abe59a81c7eba16 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 2 files changed, 150 insertions(+), 150 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dfa7e913e9c117444e54a940abe59a81c7eba16 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Print HE's domain name if it's not found
by amureini＠redhat.com 14 Jul '15

14 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Print HE's domain name if it's not found ...................................................................... core: Print HE's domain name if it's not found If the Hosted Engine's domain cannot be found in the system it will be null, and cannot be logged effectively. Instead, we should log the name we used to search for it. This patch fixes the FindBugs warning NP_LOAD_OF_KNOWN_NULL_VALUE on this line. Change-Id: I6ea3980419d63e7ac1d85da9be0b3233ea7ca1ba Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ea3980419d63e7ac1d85da9be0b3233ea7ca1ba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: findbugs in Live Merge flows
by amureini＠redhat.com 14 Jul '15

14 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: findbugs in Live Merge flows ...................................................................... core: findbugs in Live Merge flows Fixed the RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE FindBugs warnings that were introduced by 37013cb001f3be4f2e8478b9351e912a51eb575a. Change-Id: I758265df99d1d8ec1f1004195a9849a0d902021a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I758265df99d1d8ec1f1004195a9849a0d902021a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: enable HC only if requirements are met
by sbonazzo＠redhat.com 14 Jul '15

14 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: enable HC only if requirements are met ...................................................................... packaging: setup: enable HC only if requirements are met Enable HC setup support only if gluster services are provided by vdsm-gluster and glusterfs-server >= 3.7.2. If requirements are not met, show a warning. If HC is explicitly requested by answer file exit since the request can't be satisfied. Change-Id: Ica5bdc876c7a47ed70bbeff9c86334e8f16b154c Bug-Url: http://bugzilla.redhat.com/1236464 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/system/Makefile.am M src/plugins/ovirt-hosted-engine-setup/system/__init__.py A src/plugins/ovirt-hosted-engine-setup/system/packages.py 4 files changed, 139 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43417 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica5bdc876c7a47ed70bbeff9c86334e8f16b154c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0