- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AttachStorageDomainToPoolCommandTest mocking
by amureini＠redhat.com 13 Jul '15

13 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AttachStorageDomainToPoolCommandTest mocking ...................................................................... core: AttachStorageDomainToPoolCommandTest mocking Fixed DAO mocking for AttachStorageDomainToPoolCommandTest so it won't need to redundantly mock DbFacade. Change-Id: I7716368ace81326bbd3dde6b9a76f9287e537155 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java 1 file changed, 6 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7716368ace81326bbd3dde6b9a76f9287e537155 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use Collections.singletonList
by amureini＠redhat.com 13 Jul '15

13 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use Collections.singletonList ...................................................................... core: Use Collections.singletonList Use Collections.singletonList instead of ArrayList for a "constant" list that should always hold a single item. Change-Id: Ib5f6077599c3a949bcd75b79573598a87cfcce48 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43515 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5f6077599c3a949bcd75b79573598a87cfcce48 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: DeactivateStorageDomainCommandTest members
by amureini＠redhat.com 13 Jul '15

13 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: DeactivateStorageDomainCommandTest members ...................................................................... core: DeactivateStorageDomainCommandTest members Fix member declarations and initialization in DeactivateStorageDomainCommandTest as per JUnit's best practices. Change-Id: Ic758a0d31804920429fd9d372bd6318e61821984 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic758a0d31804920429fd9d372bd6318e61821984 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Inline useless constants
by amureini＠redhat.com 13 Jul '15

13 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Inline useless constants ...................................................................... core: Inline useless constants Inlined constants in AddExistingFileStorageDomainCommandTest, which just repeat the conf. values they represent Change-Id: I08e924a5f6a05cdfb0c3e437a2f9c0c94951e0de Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43514 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08e924a5f6a05cdfb0c3e437a2f9c0c94951e0de Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: AttachStorageDomainToPoolCommandTest generics
by amureini＠redhat.com 13 Jul '15

13 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AttachStorageDomainToPoolCommandTest generics ...................................................................... core: AttachStorageDomainToPoolCommandTest generics Used proper Java 7 diamond generics and removed redundant generics definitions. Change-Id: I21efb67ea4e5dc1acb12b37afcefd62889ec28c9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43519 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21efb67ea4e5dc1acb12b37afcefd62889ec28c9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: AttachStorageDomainToPoolCommandTest members
by amureini＠redhat.com 13 Jul '15

13 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: AttachStorageDomainToPoolCommandTest members ...................................................................... core: AttachStorageDomainToPoolCommandTest members Made AttachStorageDomainToPoolCommandTest's members private and removed redundant initilizers. Change-Id: I432ce03d4fd0359d95262c812e5055c429f741b9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I432ce03d4fd0359d95262c812e5055c429f741b9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: DeactivateStorageDomainCommandTest asserts
by amureini＠redhat.com 13 Jul '15

13 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: DeactivateStorageDomainCommandTest asserts ...................................................................... core: DeactivateStorageDomainCommandTest asserts Use the proper assertEquals instead of assertTrue for better debug printing. Change-Id: Ia368cc9d71ed2e06ff03872471e1e17c025daf64 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia368cc9d71ed2e06ff03872471e1e17c025daf64 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: DeactivateStorageDomainCommandTest lists
by amureini＠redhat.com 13 Jul '15

13 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: DeactivateStorageDomainCommandTest lists ...................................................................... core: DeactivateStorageDomainCommandTest lists Stop using the confusing ArrayList in DeactivateStorageDomainCommandTest, and instead use Collections.emptyList() and Collections.singletonList(Object) to make the test easier to read, and to reduce the possibility of these lists being modified mistakenly. Change-Id: I72c60e44e1daed90113e1e477c75133bee7d7f51 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72c60e44e1daed90113e1e477c75133bee7d7f51 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove unused CommandMocks
by amureini＠redhat.com 13 Jul '15

13 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused CommandMocks ...................................................................... core: Remove unused CommandMocks Previous patches in this series have removed all the usages of CommandMocks. This patch finishes the job and removes this now-unused class. Change-Id: I563b5618d84b5596234917b130509eaa1debb371 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/CommandMocks.java 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43525 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I563b5618d84b5596234917b130509eaa1debb371 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Inline redundant method
by amureini＠redhat.com 13 Jul '15

13 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Inline redundant method ...................................................................... core: Inline redundant method Removed useless method to generate an empty list in AttachStorageDomainToPoolCommandTest. Change-Id: Id08bd87852acf7cc2267d8eeca49b8b240edc4ac Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id08bd87852acf7cc2267d8eeca49b8b240edc4ac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0