- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix DeactivateStorageDomainCommand mocking
by amureini＠redhat.com 13 Jul '15

13 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix DeactivateStorageDomainCommand mocking ...................................................................... core: Fix DeactivateStorageDomainCommand mocking Fix DbFacade and DAO access in DeactivateStorageDomainCommand in order to fix their mocking in the test. Change-Id: I89e30d34bd4874a3e3f34334999863e31375ec72 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java 2 files changed, 10 insertions(+), 20 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89e30d34bd4874a3e3f34334999863e31375ec72 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: VM_POOL_NAME lock on VM pool creation
by ahadas＠redhat.com 13 Jul '15

13 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: core: VM_POOL_NAME lock on VM pool creation ...................................................................... core: VM_POOL_NAME lock on VM pool creation Added VM_POOL_NAME lock that is taken when a VM pool with a given name is created. This prevents race condition that allowed to create two VM pools with the same name. Change-Id: Icfa9669a03e0b26aee2e51d91e556457d0369cf3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1167284 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java 5 files changed, 30 insertions(+), 1 deletion(-) Approvals: Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfa9669a03e0b26aee2e51d91e556457d0369cf3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in mom[master]: guest manager: single-thread monitoring
by alitke＠redhat.com 13 Jul '15

13 Jul '15

Adam Litke has submitted this change and it was merged. Change subject: guest manager: single-thread monitoring ...................................................................... guest manager: single-thread monitoring So far MOM used one thread per Guest Monitor. The two main reasons were - to minimize interference between VMs - the lack of a suitable bulk API (especially from libvirt). However, when running inside VDSM, MOM can leverage the safety which VDSM provides, and its bulk APIs. Moreover, libvirt recently gained bulk APIs as well. This patch changes the internals of Guest Manager to fully decouple Guest Monitor and threads. It is still possible to run one thread per Guest Monitor as before, but it is now possible to mix and match threads and monitors with complete freedom. This change paves the road for better and more efficient integration with VDSM. In that case, we want to be able to run all the MOM monitoring with just one thread. Change-Id: I96b96fef0c0c42fd45b76754da9c629865ab1954 Signed-off-by: Francesco Romani <fromani(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/37826 Continuous-Integration: Jenkins CI Reviewed-by: Martin Sivák <msivak(a)redhat.com> --- M doc/mom-balloon+ksm.conf M doc/mom-balloon.conf M mom/GuestManager.py M mom/__init__.py 4 files changed, 65 insertions(+), 9 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/37826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96b96fef0c0c42fd45b76754da9c629865ab1954 Gerrit-PatchSet: 18 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: ProcessDownVmCommand.isRemovingVmPool() refactoring
by ahadas＠redhat.com 13 Jul '15

13 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: core: ProcessDownVmCommand.isRemovingVmPool() refactoring ...................................................................... core: ProcessDownVmCommand.isRemovingVmPool() refactoring In ProcessDownVmCommand.isRemovingVmPool() using getVmPoolCached() instead of fetching VmPool instance from DB. Change-Id: I1f0640aa7e36d001ae9d03925c15c807f9affd70 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43526 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f0640aa7e36d001ae9d03925c15c807f9affd70 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Keep stateless snapshot on VM down for VMs from manual...
by ahadas＠redhat.com 13 Jul '15

13 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: core: Keep stateless snapshot on VM down for VMs from manual pool ...................................................................... core: Keep stateless snapshot on VM down for VMs from manual pool For VMs from manual pool do not run RestoreStatelessVmCommand from ProcessDownVmCommand. It will be called later from DetachUserFromVmFromPoolCommand, when the VM will be manually returned to the pool. Change-Id: I72104e2bbd1aa3a02267cb32b29e8f101002ec48 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1239153 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java 1 file changed, 18 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72104e2bbd1aa3a02267cb32b29e8f101002ec48 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: tools: Added enabling option to config for AREM.
by rgolan＠redhat.com 13 Jul '15

13 Jul '15

Roy Golan has submitted this change and it was merged. Change subject: tools: Added enabling option to config for AREM. ...................................................................... tools: Added enabling option to config for AREM. AREM (Affinity Rules Enforcement Manager) can be enabled or disabled on engine startup using the engine-config tools. To enabled/disable AREM, run in the shell: engine-config -s AffinityRulesEnforcementManager=false #To disable AREM engine-config -s AffinityRulesEnforcementManager=true #To enable AREM *AREM is enabled by default. Change-Id: I4f2dfaf240970fbf6595476a798cd5e8d03aa323 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 4 files changed, 12 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/43462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f2dfaf240970fbf6595476a798cd5e8d03aa323 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Allow importing hosted engine storage domain
by rgolan＠redhat.com 13 Jul '15

13 Jul '15

Roy Golan has submitted this change and it was merged. Change subject: core: Allow importing hosted engine storage domain ...................................................................... core: Allow importing hosted engine storage domain Allow importing the special storage domain of the hosted engine VM. Change-Id: I79b3f1227ef99a778654dc83fc4530f602085d80 Bug-Url: https://bugzilla.redhat.com/1160094 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java 4 files changed, 4 insertions(+), 18 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79b3f1227ef99a778654dc83fc4530f602085d80 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in mom[master]: guest manager: reorganize internals
by alitke＠redhat.com 13 Jul '15

13 Jul '15

Adam Litke has submitted this change and it was merged. Change subject: guest manager: reorganize internals ...................................................................... guest manager: reorganize internals this apparently large patch reorganize the internals of GuestManager with only renames and code move inside the class, to mark private methods as such and to make room for another implementation using a single thread. Change-Id: I8ecc6f56f326b2eb20ef84479387c4aaf3e7f147 Signed-off-by: Francesco Romani <fromani(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/37825 Continuous-Integration: Jenkins CI Reviewed-by: Martin Sivák <msivak(a)redhat.com> --- M mom/GuestManager.py 1 file changed, 45 insertions(+), 45 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/37825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ecc6f56f326b2eb20ef84479387c4aaf3e7f147 Gerrit-PatchSet: 13 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in mom[master]: monitor: simplify should_run implementation
by alitke＠redhat.com 13 Jul '15

13 Jul '15

Adam Litke has submitted this change and it was merged. Change subject: monitor: simplify should_run implementation ...................................................................... monitor: simplify should_run implementation Make the method a couple of lines shorter. Change-Id: Id41a43f430d09dfba7eded27f58f4036dcfa48a6 Signed-off-by: Francesco Romani <fromani(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/41378 Reviewed-by: Adam Litke <alitke(a)redhat.com> Reviewed-by: Martin Sivák <msivak(a)redhat.com> Continuous-Integration: Jenkins CI --- M mom/Monitor.py 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/41378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id41a43f430d09dfba7eded27f58f4036dcfa48a6 Gerrit-PatchSet: 7 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in mom[master]: guest monitor: split monitor from thread
by alitke＠redhat.com 13 Jul '15

13 Jul '15

Adam Litke has submitted this change and it was merged. Change subject: guest monitor: split monitor from thread ...................................................................... guest monitor: split monitor from thread We have the GuestMonitor class which inherits from threading.Thread, and takes care of the per-VM monitor book-keeping and of the monitoring loop. This patch splits the class in two, with an explicit monitoring thread, decoupling the two responsabilities. This is needed for better scalability, because this way we can now optionally demand the actual invocation of the monitoring code to the hypervisor, which can integrate it with its monitoring loop(s). Moreover, this patch also adds explicit registration and deregistration methods for Guest Monitor objects inside the Guest Manager. Besides a little cleanup, this patch makes room for a future patch want to optionally demand the collection of the MOM stats to hypervisor. The old behaviour is preserved through fallback code. Change-Id: I224104f8b353d92a420723d3415df94aaf68da0c Signed-off-by: Francesco Romani <fromani(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/31591 Continuous-Integration: Jenkins CI Reviewed-by: Martin Sivák <msivak(a)redhat.com> --- M mom/GuestManager.py M mom/GuestMonitor.py M mom/HostMonitor.py M mom/Monitor.py 4 files changed, 65 insertions(+), 38 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/31591 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I224104f8b353d92a420723d3415df94aaf68da0c Gerrit-PatchSet: 20 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Pavlásek <mpavlase(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0