- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine-config : add Double type support
by masayag＠redhat.com 07 Jul '15

07 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: engine-config : add Double type support ...................................................................... engine-config : add Double type support Added support for Double type Example: Adding ElimDoubleTest engine-config.properties --------------------------- ElimDoubleTest.type=Double ElimDoubleTest.description=Test Double values ConfigValues: --------------------------- @TypeConverterAttribute(Double.class) @DefaultValueAttribute("1.1") ElimDoubleTest, I also added the code for installing this value in 0000_config.sql and called Double d = Config.getValue("ElimDoubleTest"); But all the above was only for testing, the new helper class is the only code added since all code uses either Generics or dynamic load of the helper. Change-Id: I0608da138b57c9b571e082eba2e5991b95ede01f Signed-off-by: emesika <emesika(a)redhat.com> --- A backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/DoubleValueHelper.java 1 file changed, 35 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43210 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0608da138b57c9b571e082eba2e5991b95ede01f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: Verify iSCSI username and password length
by sbonazzo＠redhat.com 07 Jul '15

07 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Verify iSCSI username and password length ...................................................................... packaging: setup: Verify iSCSI username and password length Verify that iSCSI username length is equal or less to the ovirt_hosted_engine_setup.constants.Const.MAX_STORAGE_USERNAME_LENGTH (Currently set to 50 characters). Also verify that iSCSI password length is equal or less to the ovirt_hosted_engine_setup.constants.Const.MAX_STORAGE_PASSWORD_LENGTH (Currently also set to 50 characters). Please note that the values of these constants must be synced with the values defined in user_name and password fields of the storage_server_connections table. (These tables are defined in packaging/dbscripts/create_tables.sql). Note: this patch requires https://gerrit.ovirt.org/#/c/42851/ patch ('store' param support in queryEnvKey) in order to function properly. Change-Id: I74ba0a296b5c488dbf31c656f4c67fb7c79cc52e Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1210763 --- M ovirt-hosted-engine-setup.spec.in M src/bin/ovirt-hosted-engine-setup.env M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/storage/blockd.py 4 files changed, 60 insertions(+), 30 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74ba0a296b5c488dbf31c656f4c67fb7c79cc52e Gerrit-PatchSet: 17 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: ignore a problematic test
by emesika＠redhat.com 07 Jul '15

07 Jul '15

Eli Mesika has submitted this change and it was merged. Change subject: gluster: ignore a problematic test ...................................................................... gluster: ignore a problematic test This test does not pass CI tests from time to time and is unstable. Error generated by CI : 09:57:42 Failed tests: 09:57:42 testSaveDetails(org.ovirt.engine.core.dao.gluster.GlusterGeoRepDaoTest): expected:<org.ovirt.engine.core.common.businessentities.gluster.GlusterGeoRepSessionDetails@d01db74c> but was:<org.ovirt.engine.core.common.businessentities.gluster.GlusterGeoRepSessionDetails@8654f94c> 09:57:42 This patch ignores this test until it is fixed Change-Id: I411c67ff0109676dc118300f2dbbb75541739de5 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Passed CI tests Moti Asayag: Looks good to me, approved Liran Zelkha: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43264 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I411c67ff0109676dc118300f2dbbb75541739de5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Fix alignment issues in storage popup on updated FF
by derez＠redhat.com 07 Jul '15

07 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Fix alignment issues in storage popup on updated FF ...................................................................... webadmin: Fix alignment issues in storage popup on updated FF Change-Id: I48f9f13008f4130efb5c1a980d0bf4c5f9ca7725 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/GlusterStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml 4 files changed, 18 insertions(+), 33 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Vered Volansky: Verified -- To view, visit https://gerrit.ovirt.org/43266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48f9f13008f4130efb5c1a980d0bf4c5f9ca7725 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: Grey out placeholder host devices in VM sub tab
by tjelinek＠redhat.com 07 Jul '15

07 Jul '15

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Grey out placeholder host devices in VM sub tab ...................................................................... frontend: Grey out placeholder host devices in VM sub tab We add a special CSS class on rows representing host devices that are attached only as IOMMU placeholders. Change-Id: I6628db873a862ac5bdbda9a4eebf6c92af5d6dbb Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/VmHostDeviceListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/VmHostDeviceModelTable.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/WebAdmin.css 3 files changed, 31 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/43160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6628db873a862ac5bdbda9a4eebf6c92af5d6dbb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine : Add null check in RefreshLunsSize command
by amureini＠redhat.com 07 Jul '15

07 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: engine : Add null check in RefreshLunsSize command ...................................................................... engine : Add null check in RefreshLunsSize command Add null check when getting the VDS. This issue was reported by Coverity Scan. Change-Id: I89e4e91169cf9245cdc90ba18456b48307ce53a9 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshLunsSizeCommand.java 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89e4e91169cf9245cdc90ba18456b48307ce53a9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Reimplement HostSpmPriorityComparator
by amureini＠redhat.com 07 Jul '15

07 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Reimplement HostSpmPriorityComparator ...................................................................... core: Reimplement HostSpmPriorityComparator Replace HostSpmPriorityComparator's implementation with the built in Integer.compare method instead of explicitly duplicating that code. Change-Id: I135f276436e4d7b30c2a78f01fb74bdb2174fa99 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43248 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I135f276436e4d7b30c2a78f01fb74bdb2174fa99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Make HostSpmPriorityComparator Serializable
by amureini＠redhat.com 07 Jul '15

07 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Make HostSpmPriorityComparator Serializable ...................................................................... core: Make HostSpmPriorityComparator Serializable Made HostSpmPriorityComparator Serializable as per Java best practices (and FindBugs warnings). Change-Id: I65c72d3c161545d64bfc529c8814953f06f6f9b4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65c72d3c161545d64bfc529c8814953f06f6f9b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove VmStaticDaoTest logger
by amureini＠redhat.com 07 Jul '15

07 Jul '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove VmStaticDaoTest logger ...................................................................... core: Remove VmStaticDaoTest logger Removed an unused logger. Change-Id: Ia05aa12b42555e31f1270297b9a745ee4fbe3a4e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDaoTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia05aa12b42555e31f1270297b9a745ee4fbe3a4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: backend: Expose iommuPlaceholder flag on HostDeviceView
by ofrenkel＠redhat.com 07 Jul '15

07 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: backend: Expose iommuPlaceholder flag on HostDeviceView ...................................................................... backend: Expose iommuPlaceholder flag on HostDeviceView GetExtendedVmHostDevicesByVmIdQuery now returns all configured VM HostDevices (placeholder or not) with the additional flag to enable visual distinction of (non)placeholder devices on frontend. Change-Id: Ic74d887bf3790948019f2bdead682f2991adb802 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetExtendedVmHostDevicesByVmIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostDeviceView.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmHostDevice.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoImpl.java M packaging/dbscripts/create_views.sql 5 files changed, 32 insertions(+), 31 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43159 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic74d887bf3790948019f2bdead682f2991adb802 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0