- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: branding: rename some branding classes and images
by Code Review 22 Aug '17

22 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80762 ) Change subject: branding: rename some branding classes and images ...................................................................... branding: rename some branding classes and images Rename some branding classes and images for clarity. Change-Id: Ib495a1326417801c7b5fad66050cc119e03f9e62 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/credentialsChange.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/405.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_landing_bg_bottom_left.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_landing_bg_top_right.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_logo.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_middle_logo.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_webadmin_about_bg.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_webadmin_masthead_bg.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_webadmin_masthead_logo.png M frontend/brands/ovirt-brand/src/main/sass/_branding_common.scss M frontend/brands/ovirt-brand/src/main/sass/_branding_webadmin.scss M frontend/brands/ovirt-brand/src/main/sass/_ovirt-patternfly-compat.scss M frontend/brands/ovirt-brand/src/main/sass/_ovirt.scss M frontend/brands/ovirt-brand/src/main/sass/_welcome_base.scss M frontend/brands/ovirt-brand/src/main/sass/webadmin.scss M frontend/brands/ovirt-brand/src/main/sass/welcome.scss M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AboutPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.ui.xml 23 files changed, 95 insertions(+), 95 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/80762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib495a1326417801c7b5fad66050cc119e03f9e62 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Add passthrough column under vNIC profiles sub tab
by Code Review 22 Aug '17

22 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80679 ) Change subject: frontend: Add passthrough column under vNIC profiles sub tab ...................................................................... frontend: Add passthrough column under vNIC profiles sub tab Add column for passthrough property in Network -> Networks -> vNIC Profiles. Change width of Port Mirroring column to match vNIC profiles tab table. Change-Id: I33748b410393994a43870ae4b2b7b2a3daa48575 Signed-off-by: Ales Musil <amusil(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1241410 --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkProfileView.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Ales Musil: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33748b410393994a43870ae4b2b7b2a3daa48575 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ales Musil <amusil(a)redhat.com> Gerrit-Reviewer: Ales Musil <amusil(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: osinfo: update memory requirements for RHEL
by Code Review 22 Aug '17

22 Aug '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80894 ) Change subject: osinfo: update memory requirements for RHEL ...................................................................... osinfo: update memory requirements for RHEL Change-Id: I78ac7e94786517feb7292e9a44b9bb6705b3b75a Bug-Url: https://bugzilla.redhat.com/1428490 Signed-off-by: Michal Skrivanek <michal.skrivanek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M packaging/conf/osinfo-defaults.properties 3 files changed, 8 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Michal Skrivanek: Verified -- To view, visit https://gerrit.ovirt.org/80894 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78ac7e94786517feb7292e9a44b9bb6705b3b75a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: db: disallow file type to be null
by Code Review 22 Aug '17

22 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80693 ) Change subject: db: disallow file type to be null ...................................................................... db: disallow file type to be null Since we assume the image's file type has a concrete value, it can't be null. Change-Id: Ia65236a38b8ef106eab5ec21eeda2a9ae1354212 Signed-off-by: Shani Leviim <sleviim(a)redhat.com> --- A packaging/dbscripts/upgrade/04_02_0490_disallow_file_type_to_be_null.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Shani Leviim: Verified -- To view, visit https://gerrit.ovirt.org/80693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia65236a38b8ef106eab5ec21eeda2a9ae1354212 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Use is_secret
by Code Review 22 Aug '17

22 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79345 ) Change subject: packaging: setup: Use is_secret ...................................................................... packaging: setup: Use is_secret Add secret constants to LOG_FILTER_KEYS by marking them is_secret=True instead of manually. Bug-Url: https://bugzilla.redhat.com/1169099 Change-Id: Ie0c28ad17644b1875b78aa4a02bd2cad92c00971 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/ovirt_engine_setup/provisiondb/constants.py M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/connection.py M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/provisioning/database.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/pki.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaa.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 10 files changed, 22 insertions(+), 73 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/79345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0c28ad17644b1875b78aa4a02bd2cad92c00971 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: populate SETUP_ATTRS_MODULES early
by Code Review 22 Aug '17

22 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79344 ) Change subject: packaging: setup: populate SETUP_ATTRS_MODULES early ...................................................................... packaging: setup: populate SETUP_ATTRS_MODULES early It used to be populated in STAGE_SETUP. Move this to STAGE_BOOT, before SECRETS_FILTERED_FROM_SETUP_ATTRS_MODULES, so that secret keys will be filtered early. Change-Id: Ie8bfb95022e0dec328a50cd10f3071265ac3fc31 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/core/misc.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/core/misc.py M packaging/setup/plugins/ovirt-engine-common/websocket_proxy/core.py M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/core/misc.py 4 files changed, 56 insertions(+), 21 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/79344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8bfb95022e0dec328a50cd10f3071265ac3fc31 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live 4.1.5-1
by Code Review 22 Aug '17

22 Aug '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. ( https://gerrit.ovirt.org/80886 ) Change subject: build: ovirt-live 4.1.5-1 ...................................................................... build: ovirt-live 4.1.5-1 Change-Id: I543f58e37536dd6a7e802e7eb906a6815332ce39 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests Sandro Bonazzola: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I543f58e37536dd6a7e802e7eb906a6815332ce39 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix typo in method name.
by Code Review 22 Aug '17

22 Aug '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/80864 ) Change subject: core: Fix typo in method name. ...................................................................... core: Fix typo in method name. Fix typo Change-Id: I437c9d708aac0f919cba6dd34fb0e9e118166376 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I437c9d708aac0f919cba6dd34fb0e9e118166376 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: missing injection caused NPE in event log
by Code Review 22 Aug '17

22 Aug '17

>From Eli Mesika <emesika(a)redhat.com>: Eli Mesika has submitted this change and it was merged. ( https://gerrit.ovirt.org/80860 ) Change subject: core: missing injection caused NPE in event log ...................................................................... core: missing injection caused NPE in event log When trying to dismiss an error (like in the case you try to add a host to an incompatible dc/cluster version), a NPE is thrown as a result of a AuditLogBase instance that is created without injecting its members. This patch handled this problem by populating an AuditLogImpl instance instead without a need of injection. Change-Id: Ibe53da55b969962139b43b9701f8c100a2a40306 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1480208 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAuditLogByIdCommand.java 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80860 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe53da55b969962139b43b9701f8c100a2a40306 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: handle HE VM hosting host fencing
by Code Review 22 Aug '17

22 Aug '17

>From Eli Mesika <emesika(a)redhat.com>: Eli Mesika has submitted this change and it was merged. ( https://gerrit.ovirt.org/79882 ) Change subject: core: handle HE VM hosting host fencing ...................................................................... core: handle HE VM hosting host fencing The non-responding host is in a fencing flow while the engine VM is restarted on another machine, the fencing flow did only the <stop> step from the fencing flow and then the engine VM goes down. Since in the engine start we look only for host with <non-responding> status , this host which is actually in <down> status will not be started. Proposed solution is to add a is_in_fencing_flow boolean column to vds_dynamic 1) The flag is set at the start of hard fencing flow (stop command) and reset at the end of the hard fencing flow (start command) when the origin of those command comes from non-responding host and not manual fencing 2) In the non-responding treatment that occurs on engine start we will take in account also hosts that have the is_in_fencing_flow and reset the is_in_fencing_flow flag 3) when the host is UP either by a successful start command or by Host Monitoring, the is_in_fencing_flow should be rest as well This will ensure that engine will try to fence hosts that were stuck in the middle of a fencing flow as a result of engine restart Change-Id: I8761b52b5ffb4e10875a5b235a4cfc8de6664cf9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1440101 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceVdsBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/RestartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/startup/recovery/RecoveryStartupBean.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_02_0480_add_vm_dynamic_in_fence_flow.sql M packaging/dbscripts/vds_sp.sql 13 files changed, 105 insertions(+), 28 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8761b52b5ffb4e10875a5b235a4cfc8de6664cf9 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0