- Engine-commits - oVirt List Archives

Change in jenkins[master]: Adapting OST manual job to macro changes
by Code Review 21 Aug '17

21 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80790 ) Change subject: Adapting OST manual job to macro changes ...................................................................... Adapting OST manual job to macro changes Change-Id: I7a5dad25d33ca61b50c227201eb5d1f97c25166f Jira-ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1598 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Eyal Edri: Looks good to me Barak Korren: Verified; Looks good to me, approved; Ready for merge Anton Marchukov: Looks good to me Daniel Belenky: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80790 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a5dad25d33ca61b50c227201eb5d1f97c25166f Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live 4.1.5
by Code Review 21 Aug '17

21 Aug '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. ( https://gerrit.ovirt.org/80853 ) Change subject: build: ovirt-live 4.1.5 ...................................................................... build: ovirt-live 4.1.5 Change-Id: I7c82217c906f4e3fff9fdf36164b14b775523cb0 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Lev Veyde: Looks good to me, approved Sandro Bonazzola: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c82217c906f4e3fff9fdf36164b14b775523cb0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.1]: build: post ovirt-release41-4.1.5-1
by Code Review 21 Aug '17

21 Aug '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. ( https://gerrit.ovirt.org/80847 ) Change subject: build: post ovirt-release41-4.1.5-1 ...................................................................... build: post ovirt-release41-4.1.5-1 Change-Id: I9feda74695b11557339588d17f1e742a945a3d13 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M automation/build-artifacts.sh M automation/check-patch.sh M configure.ac M ovirt-release41.spec.in 4 files changed, 10 insertions(+), 3 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9feda74695b11557339588d17f1e742a945a3d13 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.1]: build: ovirt-release41-4.1.5-1
by Code Review 21 Aug '17

21 Aug '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. ( https://gerrit.ovirt.org/80845 ) Change subject: build: ovirt-release41-4.1.5-1 ...................................................................... build: ovirt-release41-4.1.5-1 Change-Id: I4d16371f6c337e67ad90c8333621e4059a61a147 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M automation/build-artifacts.sh M automation/check-patch.sh M configure.ac M ovirt-release41.spec.in 4 files changed, 5 insertions(+), 6 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80845 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d16371f6c337e67ad90c8333621e4059a61a147 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: frontend: Add updated size validation to vnic profile names.
by Code Review 21 Aug '17

21 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80837 ) Change subject: frontend: Add updated size validation to vnic profile names. ...................................................................... frontend: Add updated size validation to vnic profile names. Maximum allowed vnic profile name size is now 256 characters; it is not completely unlimited. Re-add size validation with the new appropriate size (256). Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1477161 Change-Id: I7d773ecdb3918a46043df3ba3af26cdb705bec04 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80837 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d773ecdb3918a46043df3ba3af26cdb705bec04 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: Add updated size validation to vnic profile names.
by Code Review 21 Aug '17

21 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80838 ) Change subject: backend: Add updated size validation to vnic profile names. ...................................................................... backend: Add updated size validation to vnic profile names. Maximum allowed vnic profile name size is now 256 characters; it is not completely unlimited. Re-add size validation with the new appropriate size (256). Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1477161 Change-Id: I312e63f294a42ee0010a26eb62ce05c76ef00496 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfile.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80838 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I312e63f294a42ee0010a26eb62ce05c76ef00496 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: dbscripts: Increase vnic_profile's name column to...
by Code Review 21 Aug '17

21 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80811 ) Change subject: packaging: dbscripts: Increase vnic_profile's name column to 256 bytes. ...................................................................... packaging: dbscripts: Increase vnic_profile's name column to 256 bytes. By default vnic profiles are named after its underlying network. With the recent change to network names where networks are no longer restricted to 15 ASCII characters, vnic profile names must follow suit. Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1477569 Change-Id: I73dcabb3fd9404dc2802121d402e2c79fd5c8a75 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/04_01_0870_increase_vnic_profile_name_size.sql 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Passed CI tests Alona Kaplan: Looks good to me, approved Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73dcabb3fd9404dc2802121d402e2c79fd5c8a75 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: replace network name with vdsm name when needed
by Code Review 21 Aug '17

21 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80813 ) Change subject: backend: replace network name with vdsm name when needed ...................................................................... backend: replace network name with vdsm name when needed In a scenario where a network with a long name is removed or detached from a cluster, detaching the network (which is now unmanaged) from hosts will be impossible as mapping network name to vdsm name is no longer possible. To remedy this, on network removal, replace network_name in vds_interface from network name to vdsm name in each interface where the removed network is attached to in the datacenter or cluster. Change-Id: I93fca4940deae3bff497c85fcaf46e1a87f07c02 Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1478790 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkFromClusterInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoImpl.java 5 files changed, 35 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93fca4940deae3bff497c85fcaf46e1a87f07c02 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: pass vdsm name over network name to vmInfo
by Code Review 21 Aug '17

21 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80812 ) Change subject: backend: pass vdsm name over network name to vmInfo ...................................................................... backend: pass vdsm name over network name to vmInfo The actual interface's name libvirt needs to make use of is vdsm_name and not the network's name which is to be used by engine. Pass vdsm_name to vmInfo instead of network name. Change-Id: Ie53dcf8cc81da8cb83b42d215e753f40cf1b727a Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1478806 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Passed CI tests Alona Kaplan: Looks good to me, approved Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80812 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie53dcf8cc81da8cb83b42d215e753f40cf1b727a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: dbscripts: Increase vds_interface's network_name ...
by Code Review 21 Aug '17

21 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80810 ) Change subject: packaging: dbscripts: Increase vds_interface's network_name col size. ...................................................................... packaging: dbscripts: Increase vds_interface's network_name col size. vds_interface holds the network name of the relevant network. With the recent change to network names where networks are no longer restricted to 15 ASCII characters, vds_interface's network_name must follow suit and be increased to 256 bytes. Change-Id: I09bf3ee1fe6f875885b911a34628ffc16b613225 Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1478717 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/04_01_0860_increase_vds_interface_network_name_size.sql 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09bf3ee1fe6f875885b911a34628ffc16b613225 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0