- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Change message to match new UI
by Code Review 22 Aug '17

22 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80866 ) Change subject: webadmin: Change message to match new UI ...................................................................... webadmin: Change message to match new UI Before this patch, when importing an image from Glance, the text in the dialog box redirects to the "'Events' or 'Tasks' tabs in the footer pane", which doesn't exist in the new UI. Also, the main 'tabs' are called 'content views'. Change-Id: I8d64089a0c1627c3e70882bdfa7bad9ae6c32cf3 Bug-Url: https://bugzilla.redhat.com/1482451 Signed-off-by: Shani Leviim <sleviim(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Shani Leviim: Verified -- To view, visit https://gerrit.ovirt.org/80866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d64089a0c1627c3e70882bdfa7bad9ae6c32cf3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: set vm owner on import vm like on add vm
by Code Review 22 Aug '17

22 Aug '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/77050 ) Change subject: core: set vm owner on import vm like on add vm ...................................................................... core: set vm owner on import vm like on add vm In theory, the permission settings on import VM should be similar to that on add VM. This patch applies what commit I7e814ab0 did for add VM to import VM, in order to prevent a scenario in which users import VMs and then lack the required permissions to manage them. Change-Id: I4a8c63e8a5cce4c313fdeee8e90a8857faca11d0 Bug-Url: https://bugzilla.redhat.com/1451501 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java 1 file changed, 33 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Verified; Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/77050 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a8c63e8a5cce4c313fdeee8e90a8857faca11d0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: hypervisor table - add description
by Code Review 21 Aug '17

21 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80876 ) Change subject: inventory: hypervisor table - add description ...................................................................... inventory: hypervisor table - add description Change-Id: Id5608eb300378c2e89e4247bd66f340ea02c4f5a Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5608eb300378c2e89e4247bd66f340ea02c4f5a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: packaging: setup: Remove unneeded STAGE_BOOT priorities
by Code Review 21 Aug '17

21 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79568 ) Change subject: packaging: setup: Remove unneeded STAGE_BOOT priorities ...................................................................... packaging: setup: Remove unneeded STAGE_BOOT priorities Change-Id: I6588dbaaa207c09758d23be056e39f92cfaff722 Related-To: https://bugzilla.redhat.com/1472325 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-host-deploy.spec.in M src/plugins/ovirt-host-deploy/core/misc.py M src/plugins/ovirt-host-mgmt/core/misc.py 3 files changed, 1 insertion(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/79568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6588dbaaa207c09758d23be056e39f92cfaff722 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Allow marking env keys as secret
by Code Review 21 Aug '17

21 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79343 ) Change subject: packaging: setup: Allow marking env keys as secret ...................................................................... packaging: setup: Allow marking env keys as secret Add a new parameter 'is_secret' to the decorator osetupattrs used to create "attributed-constants". Add keys with 'is_secret=True' to LOG_FILTER_KEYS. Change-Id: Iab8e0807d39f04cd88de78f334d1a0c13231c4b0 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/base/core/__init__.py A packaging/setup/plugins/ovirt-engine-common/base/core/filter_secrets.py 3 files changed, 72 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/79343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab8e0807d39f04cd88de78f334d1a0c13231c4b0 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Add --sumary
by Code Review 21 Aug '17

21 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80867 ) Change subject: inventory: Add --sumary ...................................................................... inventory: Add --sumary Executive summary, no pre-upgrade checks Change-Id: I8531a914b68b9b5cace9e6a1d57385a03d4aa629 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/ovirt-log-collector-analyzer.sh M src/inventory_report/produceReport/produceReport.sh M src/inventory_report/unpackAndPrepareDump.sh 3 files changed, 80 insertions(+), 55 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80867 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8531a914b68b9b5cace9e6a1d57385a03d4aa629 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Virtual and Actual size in GB
by Code Review 21 Aug '17

21 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80839 ) Change subject: webadmin: Virtual and Actual size in GB ...................................................................... webadmin: Virtual and Actual size in GB In snapshots sub-tab Disks, Virtual and Actual size should be in GB instead of Bytes. Change-Id: I0ef4b1707e9be7dfda322d150db3540ad15d5aa1 Bug-Url: https://bugzilla.redhat.com/1479752 Signed-off-by: Shani Leviim <sleviim(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListViewItem.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Shani Leviim: Verified -- To view, visit https://gerrit.ovirt.org/80839 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ef4b1707e9be7dfda322d150db3540ad15d5aa1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: enable polling of balloon driver stats
by Code Review 21 Aug '17

21 Aug '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80721 ) Change subject: core: enable polling of balloon driver stats ...................................................................... core: enable polling of balloon driver stats VDSM is switching from ovirt-guest-agent to balloon driver for memory statistics. It is necessary to enable the polling in domain XML before VDSM can access them. Change-Id: I7087a7f8324f30e714b6cddcb0368d7e652deee4 Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved Tomas Golembiovsky: Verified -- To view, visit https://gerrit.ovirt.org/80721 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7087a7f8324f30e714b6cddcb0368d7e652deee4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add support for secrets and credentials to STD CI
by Code Review 21 Aug '17

21 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/76241 ) Change subject: Add support for secrets and credentials to STD CI ...................................................................... Add support for secrets and credentials to STD CI [1] Added module for secrets resolvers which will handle all the user requests for secrets, filter the secret data from un-related secrets and credentials and resolve CI secrets file [2] Added module for ci_env_client which will handle user request(s) for environmental variables. [3] Added tests for the different methods, testing functionality and exceptions. The general idea, is that a user will specify the required credentials for his project in a yaml format, and we'll supply the requirement as environmental vars inside mock's env. (Support in mock_runner.sh will be added in a different patch) For more info, please refer to Jira: https://ovirt-jira.atlassian.net/browse/OVIRT-894 Change-Id: Ic1ac9ec8c2a2a9fb7370d15fea36d903c37a7404 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M automation/check-patch.packages A automation/check-patch.packages.el6 M automation/check-patch.packages.el7 M automation/check-patch.packages.fc24 A scripts/ci_env_client.py A scripts/secrets_resolvers.py A test/test_ci_env_client.py A test/test_secrets_resolvers.py 8 files changed, 381 insertions(+), 0 deletions(-) Approvals: Barak Korren: Looks good to me, approved; Ready for merge Daniel Belenky: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1ac9ec8c2a2a9fb7370d15fea36d903c37a7404 Gerrit-PatchSet: 18 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Staging Jenkins Server

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Release mac pools only VMs with disks on removed SD.
by Code Review 21 Aug '17

21 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80822 ) Change subject: core: Release mac pools only VMs with disks on removed SD. ...................................................................... core: Release mac pools only VMs with disks on removed SD. The force remove of storage domain currently releases mac pools of VMs which are related to the entire storage pool. The fix is to release the mac pools only for VMs which have disks which are reside the the removed storage domain. Change-Id: Ic9bfb91ad7c1683111ad83e377217d8afe0c416c Bug-Url: https://bugzilla.redhat.com/1482569 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DetachStorageDomainFromPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ForceRemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/80822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9bfb91ad7c1683111ad83e377217d8afe0c416c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0