- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: remove legacy osinfo.py file
by sbonazzo＠redhat.com 17 Nov '14

17 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: remove legacy osinfo.py file ...................................................................... packaging: remove legacy osinfo.py file Change-Id: I388e687c29e0faa6f7e6a6c5763ab66b95d25a86 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/__init__.py D packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/osinfo.py 3 files changed, 0 insertions(+), 217 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve Martin Betak: Verified Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I388e687c29e0faa6f7e6a6c5763ab66b95d25a86 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: Parsing http body return on error and improve output
by oourfali＠redhat.com 17 Nov '14

17 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: Parsing http body return on error and improve output ...................................................................... Parsing http body return on error and improve output Instead of generalizing the error by using PROVIDER_FAILURE, foreman starts to provide full description of the failure reason, such as: Body: { "error": {"id":17,"errors":{"root_pass":["should be 8 characters or more"]}, "full_messages":["Root password should be 8 characters or more"]} } In this patch we add the "full_messages" to engine.log Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124891 Change-Id: I1a5717baa06665e475e64a8f91e23ffcb01e17b4 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanError.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanErrorWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java 3 files changed, 35 insertions(+), 1 deletion(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a5717baa06665e475e64a8f91e23ffcb01e17b4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: db: add a common function for index creation
by oourfali＠redhat.com 17 Nov '14

17 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: db: add a common function for index creation ...................................................................... db: add a common function for index creation This patch adds a common function that drop the index if exists and creates it after that. This is done in order to prevent scripts failures when the index is not dropped and an attempt to re-create it is done Bug-Url: https://bugzilla.redhat.com/1155153 Change-Id: I6e6e2577ceac435e25030dfde6ff6c4c3f8a7278 Signed-off-by: Eli Mesika <emesika(a)redhat.com> (cherry picked from commit d65b5293b48d552d90cc4dbf44d2c09769548906) --- M packaging/dbscripts/common_sp.sql 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e6e2577ceac435e25030dfde6ff6c4c3f8a7278 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Set storage type as set in the paramteres.
by tnisan＠redhat.com 16 Nov '14

16 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Set storage type as set in the paramteres. ...................................................................... core: Set storage type as set in the paramteres. 1) Set the storage type of the storage after it was fetched from VDSM in GetExistingStorageDomainListQuery 2) use getStorageDomainsList to be fetched without Storage Domains type. Change-Id: I9a6f2f22b09de9daffde5e003528324237d6835f Bug-Url: https://bugzilla.redhat.com/1157240 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetExistingStorageDomainListQuery.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a6f2f22b09de9daffde5e003528324237d6835f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fixed description in edit affinity group
by tnisan＠redhat.com 16 Nov '14

16 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fixed description in edit affinity group ...................................................................... webadmin: Fixed description in edit affinity group In the "Edit" popup of the "Affinity Group" subtab for the VM The description field wasn't retrieved(It was left empty even after being set). This error was fixed and now description field that was set will be shown in the edit popup. Change-Id: Ib0e88bc052844a5cfca30b0f1c53bf1b118c2ae3 Bug-Url: https://bugzilla.redhat.com/1142233 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/affinity_groups/model/EditAffinityGroupModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Tomer Saban: Verified Roy Golan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0e88bc052844a5cfca30b0f1c53bf1b118c2ae3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Use GetExistingStorageDomainList to fetch all type of ...
by tnisan＠redhat.com 16 Nov '14

16 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Use GetExistingStorageDomainList to fetch all type of Storages ...................................................................... core: Use GetExistingStorageDomainList to fetch all type of Storages Use GetExistingStorageDomainList to fetch different tpye of storage type, so user can manipulate the Storage Domain type while importing it. Change-Id: If3a082e0bddaad745788b9b166f2b17eff0fbd17 Bug-Url: https://bugzilla.redhat.com/1157240 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainsListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 5 files changed, 10 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3a082e0bddaad745788b9b166f2b17eff0fbd17 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Remove redundant Vds call at Add existingFileStorageDo...
by tnisan＠redhat.com 16 Nov '14

16 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove redundant Vds call at Add existingFileStorageDomain ...................................................................... core: Remove redundant Vds call at Add existingFileStorageDomain Remove redundant getStorageDomainsList VDS call. The call was used to know if the Storage Exists in the VDSM, but we can also know that from the next VDS command of getStorageDomainInfo. Changing the test accordingly Change-Id: I2294f83eb204cab44b6a52e7c7a763bf107aaa37 Bug-Url: https://bugzilla.redhat.com/1157240 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java 1 file changed, 10 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2294f83eb204cab44b6a52e7c7a763bf107aaa37 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Determine file storage type by user.
by tnisan＠redhat.com 16 Nov '14

16 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Determine file storage type by user. ...................................................................... core: Determine file storage type by user. Importing a Storage Domain should be determined by the user instead it will be determined from the meta data. Alao removing unrequired related CDA message, and a test which is not relevant anymore. Change-Id: I1251c51b06bcd5f17633a4ad3de2496d5cb77683 Bug-Url: https://bugzilla.redhat.com/1157240 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 0 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1251c51b06bcd5f17633a4ad3de2496d5cb77683 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Determine block storage type by user.
by tnisan＠redhat.com 16 Nov '14

16 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Determine block storage type by user. ...................................................................... core: Determine block storage type by user. Importing a Storage Domain should be determined by the user instead it will be determined from the meta data. Change-Id: I6d5076d78eea0960da41a058b4de17bbb01b05f1 Bug-Url: https://bugzilla.redhat.com/1157240 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d5076d78eea0960da41a058b4de17bbb01b05f1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: respect user preference on payload, smartcard and watc...
by ofrenkel＠redhat.com 16 Nov '14

16 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: respect user preference on payload, smartcard and watchdog ...................................................................... core: respect user preference on payload, smartcard and watchdog The payload, smardcard and watchdog were copied from the instance type if it was selected all the time. Since this properties are no longer the "marked" ones, we need to respect the user preference on them. Change-Id: I1bc56e7b9f6e91431acb9345b4d87e9bfe145ee9 Bug-Url: https://bugzilla.redhat.com/1149663 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bc56e7b9f6e91431acb9345b4d87e9bfe145ee9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0