- Engine-commits - oVirt List Archives

Change in ovirt-guest-agent[ovirt-3.5]: win32: OpenKey third parameter must always be 0
by vfeenstr＠redhat.com 18 Nov '14

18 Nov '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: win32: OpenKey third parameter must always be 0 ...................................................................... win32: OpenKey third parameter must always be 0 The third parameter is a reserved parameter, where the fourth is the parameter for the requested access rights. Previously the requested access was passed as the reserved parameter which is wrong, however it did not fail any testing. This patch corrects the misusage. Change-Id: I9fb3747edec2a7ea7270522ac7104748f7021870 Bug-Url: https://bugzilla.redhat.com/1158470 Bug-Url: https://bugzilla.redhat.com/1105056 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit 93aa6178f79189b41c28312e9c839e8d8045e52f) --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fb3747edec2a7ea7270522ac7104748f7021870 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: win32: Set registry value with SetValueEx not SetValue
by vfeenstr＠redhat.com 18 Nov '14

18 Nov '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: win32: Set registry value with SetValueEx not SetValue ...................................................................... win32: Set registry value with SetValueEx not SetValue _winreg.SetValue only allows to set the default value on a subkey SetValueEx lets one specify the value name and the value itself. Additionally as a security measure we're now encapsulating all exceptions coming from SAS handling to still at least attempt the login, even if the SAS portion may fail. This is just a precaution to prevent SSO from breaking due to some unforeseen bug. Change-Id: I51d70381de43d62e96f9f24de60bdf0226e20f54 Bug-Url: https://bugzilla.redhat.com/1158470 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51d70381de43d62e96f9f24de60bdf0226e20f54 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: win32: Read serial info directly when not available through WMI
by vfeenstr＠redhat.com 18 Nov '14

18 Nov '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: win32: Read serial info directly when not available through WMI ...................................................................... win32: Read serial info directly when not available through WMI The SerialNumber field in the WMI table 'Win32_DiskDrive' is only available from Windows Vista and Windows 2008 Server. This patch works around this issue by querying the device directly, but only if the SerialNumber field is not available. Change-Id: Id39914464377c388b8ef3e2551a47a295de4a750 Bug-Url: https://bugzilla.redhat.com/1158907 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 64 insertions(+), 2 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id39914464377c388b8ef3e2551a47a295de4a750 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: win32: Also the listener thread needs to call CoInitialize
by vfeenstr＠redhat.com 18 Nov '14

18 Nov '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: win32: Also the listener thread needs to call CoInitialize ...................................................................... win32: Also the listener thread needs to call CoInitialize Change-Id: If31c9703d177930922769b98187fae67a28efd4f Bug-Url: https://bugzilla.redhat.com/1158855 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If31c9703d177930922769b98187fae67a28efd4f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: win32: OpenKey third parameter must always be 0
by vfeenstr＠redhat.com 18 Nov '14

18 Nov '14

Vinzenz Feenstra has submitted this change and it was merged. Change subject: win32: OpenKey third parameter must always be 0 ...................................................................... win32: OpenKey third parameter must always be 0 The third parameter is a reserved parameter, where the fourth is the parameter for the requested access rights. Previously the requested access was passed as the reserved parameter which is wrong, however it did not fail any testing. This patch corrects the misusage. Change-Id: I9fb3747edec2a7ea7270522ac7104748f7021870 Bug-Url: https://bugzilla.redhat.com/1158470 Bug-Url: https://bugzilla.redhat.com/1105056 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Vinzenz Feenstra: Verified; Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fb3747edec2a7ea7270522ac7104748f7021870 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Use existing Engine session for REST API integration
by awels＠redhat.com 17 Nov '14

17 Nov '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Use existing Engine session for REST API integration ...................................................................... webadmin: Use existing Engine session for REST API integration Before this patch ================= * WebAdmin login triggers creation of separate (logical) Engine session through creation of new (physical) REST session using HTTP basic auth -> REST session is acquired using current WebAdmin user credentials -> REST session ID is provided to all UI plugins * above causes two separate user login operations with same credentials and therefore two "user has logged in" events in Engine server log * acquired (physical) REST session, as well as corresponding (logical) Engine session, are _NOT_ closed upon WebAdmin logout, even though these sessions were created with WebAdmin user credentials After this patch ================ * WebAdmin login _DOES NOT_ trigger creation of separate (logical) Engine session; instead, it reuses existing Engine user session -> REST session is still acquired, but instead of HTTP basic auth credentials, we're passing existing Engine session auth token to associate REST session with current user's Engine session -> REST session ID is provided to all UI plugins * above ensures single user login operation upon WebAdmin login * since acquired REST session maps to existing Engine session, WebAdmin user logout makes that REST session unusable, even if the REST session itself is still alive We use Prefer:new-auth to ensure that new REST session is created on each WebAdmin login. Important note for UI plugin developers ======================================= REST session ID passed to UI plugins via "RestApiSessionAcquired" hook, also represented by JSESSIONID cookie for /api, will become unusable after WebAdmin logout. Since UI plugins are active (invoked by the infra) only while the user is authenticated, this shouldn't impact UI plugins that use provided REST session (cookie) to talk directly with Engine. Change-Id: Ic3905b3b5834a0f7327321e93064274df0d1db65 Bug-Url: https://bugzilla.redhat.com/1161734 Bug-Url: https://bugzilla.redhat.com/1161730 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/FrontendLoginHandler.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java 5 files changed, 91 insertions(+), 67 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3905b3b5834a0f7327321e93064274df0d1db65 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: filters: add Prefer new-auth option
by awels＠redhat.com 17 Nov '14

17 Nov '14

Alexander Wels has submitted this change and it was merged. Change subject: aaa: filters: add Prefer new-auth option ...................................................................... aaa: filters: add Prefer new-auth option this enforces opening a new http session, this is useful when remote wants to enforce new session and authorization in persist mode. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1161734 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1161730 Change-Id: I78e91d9c1994203bd4b278d878b26c843eaad3cf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/RestApiSessionMgmtFilter.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/RestApiSessionValidationFilter.java M backend/manager/modules/aaa/src/test/java/org/ovirt/engine/core/aaa/filters/FiltersHelperTest.java 4 files changed, 41 insertions(+), 29 deletions(-) Approvals: Alon Bar-Lev: Verified Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78e91d9c1994203bd4b278d878b26c843eaad3cf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: filters: enable accept engine session using header
by awels＠redhat.com 17 Nov '14

17 Nov '14

Alexander Wels has submitted this change and it was merged. Change subject: aaa: filters: enable accept engine session using header ...................................................................... aaa: filters: enable accept engine session using header new header OVIRT-INTERNAL-ENGINE-AUTH-TOKEN accepts token that contains engine session id. a new query GetEngineSessionIdToken returns this token. ui should use the new query and apply the header to avoid double login. this may be temporary solution for 3.5 life cycle, as such applied only for restapi. when engine session is invalidated, all instances that used it are also invalidated. Change-Id: I028082cced7043b5af0b9fa7b0548ba888996e9d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1161734 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1161730 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- A backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EngineSessionTokenAuthenticationFilter.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SessionValidationFilter.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetEngineSessionIdTokenQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml 6 files changed, 106 insertions(+), 14 deletions(-) Approvals: Alon Bar-Lev: Verified Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I028082cced7043b5af0b9fa7b0548ba888996e9d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add foreign keys from async_tasks to command_entities
by tnisan＠redhat.com 17 Nov '14

17 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add foreign keys from async_tasks to command_entities ...................................................................... core: Add foreign keys from async_tasks to command_entities Change-Id: If66661c75806fbad7821c9a2c9ffebabdeabe485 Bug-Url: https://bugzilla.redhat.com/1161012 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/03_05_1160_add_foreign_keys_to_async_tasks_table.sql 4 files changed, 20 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/35219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If66661c75806fbad7821c9a2c9ffebabdeabe485 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.5]: remove password leak from ovirt-engine setup answer file
by sbonazzo＠redhat.com 17 Nov '14

17 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: remove password leak from ovirt-engine setup answer file ...................................................................... remove password leak from ovirt-engine setup answer file Change-Id: Ie86186b48e04141d2ed7ee9b2185eb3a09bbc166 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1162781 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit aee7188f3f272c47e49daf10b012d4d314ec52db) --- M src/sos/plugins/ovirt.py 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie86186b48e04141d2ed7ee9b2185eb3a09bbc166 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0