- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: host-deploy: enable icmp
by oourfali＠redhat.com 16 Nov '14

16 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: host-deploy: enable icmp ...................................................................... host-deploy: enable icmp Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1162180 Change-Id: I5c0dd908a459c18b2f295d55871673c447ef43f3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c0dd908a459c18b2f295d55871673c447ef43f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Nullity check in GetVmTemplateQuery
by tnisan＠redhat.com 16 Nov '14

16 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Nullity check in GetVmTemplateQuery ...................................................................... core: Nullity check in GetVmTemplateQuery Nullity check added to VM template- the query tries to get a template from the DB and didn't check if the returned value is null which will result in NullPointerException thrown from the query. Change-Id: I994083a491db2b78f3ce24783fb0afa3348030d3 Bug-Url: https://bugzilla.redhat.com/1162078 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplateQuery.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Amit Aviram: Verified -- To view, visit http://gerrit.ovirt.org/35199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I994083a491db2b78f3ce24783fb0afa3348030d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: changed the list of fields which can not be overri...
by tnisan＠redhat.com 16 Nov '14

16 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: changed the list of fields which can not be overridden ...................................................................... webadmin: changed the list of fields which can not be overridden There are the following types of fields in instance types: - the ones which are taken from it but the user can override them (e.g. defaults) - the ones which the user can not override This patch reduces the num of fields which can not be overridden to contain only the really most important ones. This avoids the situation that the user will have to have instance types like: "big with soundcard", "big with smardcard and soundcard" etc. The list is now significantly smaller, contains only: - memory size - num of sockets/cores per socket - HA - migration model/downtime - priority - balloon/min allocated memory The specific UI changes include: - remove the chain icon from fields which are not considered to be "marked" anymore - remove the specific fields from InstanceTypeAttachDetachManager.detachableModels so it will not detach the VM from instance type if changed Change-Id: I7fc831f0a0656f8eaa92fe3509b03c8ac1b71fb9 Bug-Url: https://bugzilla.redhat.com/1149663 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeAttachDetachManager.java 3 files changed, 14 insertions(+), 59 deletions(-) Approvals: Tomas Jelinek: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fc831f0a0656f8eaa92fe3509b03c8ac1b71fb9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: changed the list of fields which can not be overridden
by tnisan＠redhat.com 16 Nov '14

16 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: changed the list of fields which can not be overridden ...................................................................... core: changed the list of fields which can not be overridden Some of the fields on the instance types are prohibited to be overridden because in such a case the VM would not be considered to be based on that instance type anymore. This patch reduces the num of fields which can not be overridden to contain only the really most important ones. This avoids the situation that the user will have to have instance types like: "big with soundcard", "big with smardcard and soundcard" etc. The list is now significantly smaller, contains only: - memory size - num of sockets/cores per socket - HA - migration model/downtime - priority - balloon/min allocated memory Change-Id: I6142a240d60d54634361d3e6427b2a56fbd01362 Bug-Url: https://bugzilla.redhat.com/1149663 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java 1 file changed, 14 insertions(+), 23 deletions(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6142a240d60d54634361d3e6427b2a56fbd01362 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: error in calculating number of available macs / trimmi...
by lvernia＠redhat.com 16 Nov '14

16 Nov '14

Lior Vernia has submitted this change and it was merged. Change subject: core: error in calculating number of available macs / trimming mac pool ranges ...................................................................... core: error in calculating number of available macs / trimming mac pool ranges mac ranges was trimmed to inapproriate size; it was trimmed so that first and last mac representation can 'fit' into int datatype, but that rendered unable to fit *count* of macs in such range into int datatype, since that count would then be max_int+1 and that'd cause overflow. Bug-Url: https://bugzilla.redhat.com/1162077 Change-Id: I4bbf719deb47c795862a03deb515283b1eae9a0e Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/Range.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/RangeTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MacAddressRangeUtilsTest.java 4 files changed, 36 insertions(+), 4 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bbf719deb47c795862a03deb515283b1eae9a0e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: remove log4j requirment from spec file
by ydary＠redhat.com 16 Nov '14

16 Nov '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: remove log4j requirment from spec file ...................................................................... packaging: remove log4j requirment from spec file removed log4j requirment from reports spec file since we provide it. Change-Id: Ic06600ae62e6af2acdc04431d067430dbe3c052f Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Verified Yaniv Dary: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic06600ae62e6af2acdc04431d067430dbe3c052f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: host-deploy: enable icmp
by oourfali＠redhat.com 16 Nov '14

16 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: host-deploy: enable icmp ...................................................................... host-deploy: enable icmp Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1162180 Change-Id: I5c0dd908a459c18b2f295d55871673c447ef43f3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c0dd908a459c18b2f295d55871673c447ef43f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Jaša <djasa(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Nullity check in GetVmTemplateQuery
by laravot＠redhat.com 16 Nov '14

16 Nov '14

Liron Aravot has submitted this change and it was merged. Change subject: core: Nullity check in GetVmTemplateQuery ...................................................................... core: Nullity check in GetVmTemplateQuery Nullity check added to VM template- the query tries to get a template from the DB and didn't check if the returned value is null which will result in NullPointerException thrown from the query. Change-Id: I994083a491db2b78f3ce24783fb0afa3348030d3 Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplateQuery.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Amit Aviram: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I994083a491db2b78f3ce24783fb0afa3348030d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix NPE on Template creation
by ofrenkel＠redhat.com 16 Nov '14

16 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Fix NPE on Template creation ...................................................................... core: Fix NPE on Template creation Change-Id: I0d9ed1719db7129be1f560068f8b8c2c707f3efa Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d9ed1719db7129be1f560068f8b8c2c707f3efa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: provide UI error for builtin krbldap
by tnisan＠redhat.com 14 Nov '14

14 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: aaa: provide UI error for builtin krbldap ...................................................................... aaa: provide UI error for builtin krbldap Bug-Url: https://bugzilla.redhat.com/1106435 Change-Id: Idb1d19d8642ad2aaccd56ada23bebf12f540bf38 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerCommandBase.java 2 files changed, 17 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ondřej Macháček: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb1d19d8642ad2aaccd56ada23bebf12f540bf38 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.ondra(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0