- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: Adding host to DB before calling provision
by tnisan＠redhat.com 13 Nov '14

13 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: Adding host to DB before calling provision ...................................................................... Adding host to DB before calling provision When calling provision foreman expect the engine's host-id to allow calling the reinstallation after provisioning. Engine generates host-id while saving host info to db, therefore this patch switches between the DB. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1158588 Change-Id: I635d87d09eec0dd052d86329d2b6b7f0a1658836 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I635d87d09eec0dd052d86329d2b6b7f0a1658836 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unnecessary String.format in logging calls
by emesika＠redhat.com 13 Nov '14

13 Nov '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Remove unnecessary String.format in logging calls ...................................................................... core: Remove unnecessary String.format in logging calls Use slf4j string formatting instead of String.format call in logging. Change-Id: I1fc06b84903db89386c51a63b1589e0d0e3a8a15 Bug-Url: https://bugzilla.redhat.com/1109871 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMClearTaskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMRevertTaskVDSCommand.java 5 files changed, 6 insertions(+), 7 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fc06b84903db89386c51a63b1589e0d0e3a8a15 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: Add support for auto-convergence and XBZRLE compres...
by ofrenkel＠redhat.com 13 Nov '14

13 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: backend: Add support for auto-convergence and XBZRLE compression ...................................................................... backend: Add support for auto-convergence and XBZRLE compression Change-Id: I04a651c4a6995876742092be31ca6e3510194b31 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MigrateVDSCommandParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDaoDbFacade.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_0520_add_vm_auto_convergence.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/dbscripts/vds_groups_sp.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql M packaging/etc/engine-config/engine-config.properties 27 files changed, 375 insertions(+), 35 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04a651c4a6995876742092be31ca6e3510194b31 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: minor refactor for custom props validation
by ofrenkel＠redhat.com 13 Nov '14

13 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: minor refactor for custom props validation ...................................................................... core: minor refactor for custom props validation instead of calling one method to check the properties and then another to check the result, now calling one method to do both. Change-Id: I444f374d0c1bb4c495b3c2b1c26c92bc466e19c9 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/VmPropertiesUtils.java 7 files changed, 21 insertions(+), 28 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35116 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I444f374d0c1bb4c495b3c2b1c26c92bc466e19c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: nit: fix pep8 issues
by ydary＠redhat.com 13 Nov '14

13 Nov '14

Yaniv Dary has submitted this change and it was merged. Change subject: nit: fix pep8 issues ...................................................................... nit: fix pep8 issues Fixed errors reported by make validations. Change-Id: I79f7c2c7dc9209fcf318c863de73dadd3c4b99fb Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79f7c2c7dc9209fcf318c863de73dadd3c4b99fb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: utils: fix compiler warnings (unit test)
by masayag＠redhat.com 13 Nov '14

13 Nov '14

Moti Asayag has submitted this change and it was merged. Change subject: utils: fix compiler warnings (unit test) ...................................................................... utils: fix compiler warnings (unit test) Some HashMaps were unintentionally subclassed, which generated a warning about missing serialVersionUID. Change-Id: I7b9b149dc43bc0d60cf0bbfcb530f642d4128820 Signed-off-by: Tim Speetjens <tim.speetjens(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/linq/LinqUtilsTest.java 1 file changed, 20 insertions(+), 26 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b9b149dc43bc0d60cf0bbfcb530f642d4128820 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tim Speetjens <tim.speetjens(a)gmail.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tim Speetjens <tim.speetjens(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: Remove unused LinqUtils.transformToSet
by masayag＠redhat.com 13 Nov '14

13 Nov '14

Moti Asayag has submitted this change and it was merged. Change subject: utils: Remove unused LinqUtils.transformToSet ...................................................................... utils: Remove unused LinqUtils.transformToSet Remove LinqUtils.transformToSet, which is unused, and cuases compiler warnings Change-Id: I646707625f139572333ee626c6613f46c35d70c6 Signed-off-by: Tim Speetjens <tim.speetjens(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/LinqUtils.java 1 file changed, 0 insertions(+), 13 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I646707625f139572333ee626c6613f46c35d70c6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tim Speetjens <tim.speetjens(a)gmail.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tim Speetjens <tim.speetjens(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: Avoid compiler warnings for missing Enum values
by masayag＠redhat.com 13 Nov '14

13 Nov '14

Moti Asayag has submitted this change and it was merged. Change subject: utils: Avoid compiler warnings for missing Enum values ...................................................................... utils: Avoid compiler warnings for missing Enum values Change-Id: I882f2196a13ec6cea4d0398d0c1b842bcca0af9b Signed-off-by: Tim Speetjens <tim.speetjens(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I882f2196a13ec6cea4d0398d0c1b842bcca0af9b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tim Speetjens <tim.speetjens(a)gmail.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: extract balloon validation in import vm
by ahadas＠redhat.com 13 Nov '14

13 Nov '14

Arik Hadas has submitted this change and it was merged. Change subject: core: extract balloon validation in import vm ...................................................................... core: extract balloon validation in import vm It is better to extract the validation from the canDoAction command for 2 reasons: 1. Readability - to make the canDoAction method more readable 2. Testability - to make the command more testable Change-Id: I152a9b96e9804ba66bc967f2754a33c346222674 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java 2 files changed, 23 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/35087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I152a9b96e9804ba66bc967f2754a33c346222674 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: SnapshotModel - remove unused method
by derez＠redhat.com 13 Nov '14

13 Nov '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: SnapshotModel - remove unused method ...................................................................... webadmin: SnapshotModel - remove unused method SnapshotModel -> updateModelBySnapshot: unused, hence removed. Change-Id: I616e0eed78c1320cc098984c60f09cda58a682b1 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/35113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I616e0eed78c1320cc098984c60f09cda58a682b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0