- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: avoid adding ovf store when register disk fails
by laravot＠redhat.com 12 Nov '14

12 Nov '14

Liron Aravot has submitted this change and it was merged. Change subject: core: avoid adding ovf store when register disk fails ...................................................................... core: avoid adding ovf store when register disk fails Trying to add an ovf store when the disk registration failed it will result in a low level sql error: ERROR: insert or update on table "storage_domains_ovf_info" violates foreign key constraint "storage_domains_ovf_info_ovf_disk_id_fkey" Change-Id: I947a04e14305cd96afa8c455391f2084856d1fc5 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Federico Simoncelli: Verified Maor Lipchuk: Looks good to me, approved Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I947a04e14305cd96afa8c455391f2084856d1fc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: prevent possible deadlock between monitoring threads
by ahadas＠redhat.com 11 Nov '14

11 Nov '14

Arik Hadas has submitted this change and it was merged. Change subject: core: prevent possible deadlock between monitoring threads ...................................................................... core: prevent possible deadlock between monitoring threads If VM went down during migration in the source host, the monitoring (VURTI) thread of the source host tries to destroy the VM in the destination host. In order to destroy the VM in the destination host, it tries to lock the destination host. When we have two monitoring threads that try to do it, we end-up in a deadlock because each of them locks the host it monitors and tries to lock the other one. This patch solves this problem by postponing the destroy operation on the destination host to take place after the lock on the monitored host is released. It is safe to do it that way because the status of the VM in the destination host must be either Down or MigratingTo. If the status is MigratingTo, the monitoring of the destination host just ignores the VM. If the status is Down, the monitoring of the destination host will just destroy the VM and the second destroy operation will fail. Change-Id: Ia4c52e0f8109f9599965078d2c6dd4db705cec97 Bug-Url: https://bugzilla.redhat.com/1142776 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 3 files changed, 35 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/34995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4c52e0f8109f9599965078d2c6dd4db705cec97 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: Display a note for db credentials
by tnisan＠redhat.com 11 Nov '14

11 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: Display a note for db credentials ...................................................................... packaging: setup: Display a note for db credentials Allow making getCredentials display a note prior to asking for credentials. Change-Id: I4053b5426b1fcb64fda2697ad4310f4044b13d98 Bug-Url: https://bugzilla.redhat.com/1159789 Bug-Url: https://bugzilla.redhat.com/1162549 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 123753c7675bd5a28dd54978ce582e01ec0a9c09) --- M packaging/setup/ovirt_engine_setup/engine_common/database.py 1 file changed, 40 insertions(+), 24 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4053b5426b1fcb64fda2697ad4310f4044b13d98 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: setup: show note about dwh db credentials
by sradco＠redhat.com 11 Nov '14

11 Nov '14

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: show note about dwh db credentials ...................................................................... packaging: setup: show note about dwh db credentials Change-Id: Iac26b56d9c03783c00010fc64beff56ea55666d9 Bug-Url: https://bugzilla.redhat.com/1162549 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 61d0faafa5d174ec5f4dc619d06f453442a4f13a) --- M packaging/setup/ovirt_engine_setup/reports/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac26b56d9c03783c00010fc64beff56ea55666d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: packaging: setup: show note about engine db credentials
by sradco＠redhat.com 11 Nov '14

11 Nov '14

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: show note about engine db credentials ...................................................................... packaging: setup: show note about engine db credentials Change-Id: Ib38fcc2f24b3994866c3ec0e0c2e3dd8dbca8649 Bug-Url: https://bugzilla.redhat.com/1159789 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 85f11ae17825f93ee7a60cbeb4c76c1c9029d013) --- M packaging/setup/ovirt_engine_setup/dwh/constants.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/engine_connection.py 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib38fcc2f24b3994866c3ec0e0c2e3dd8dbca8649 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: packaging: setup: show note about dwh db credentials
by sradco＠redhat.com 11 Nov '14

11 Nov '14

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: show note about dwh db credentials ...................................................................... packaging: setup: show note about dwh db credentials Change-Id: Iac26b56d9c03783c00010fc64beff56ea55666d9 Bug-Url: https://bugzilla.redhat.com/1162549 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/reports/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac26b56d9c03783c00010fc64beff56ea55666d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: packaging: setup: show note about engine db credentials
by sradco＠redhat.com 11 Nov '14

11 Nov '14

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: show note about engine db credentials ...................................................................... packaging: setup: show note about engine db credentials Change-Id: Ib38fcc2f24b3994866c3ec0e0c2e3dd8dbca8649 Bug-Url: https://bugzilla.redhat.com/1159789 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/dwh/constants.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/engine_connection.py 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib38fcc2f24b3994866c3ec0e0c2e3dd8dbca8649 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: Display a note for db credentials
by sbonazzo＠redhat.com 11 Nov '14

11 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Display a note for db credentials ...................................................................... packaging: setup: Display a note for db credentials Allow making getCredentials display a note prior to asking for credentials. Change-Id: I4053b5426b1fcb64fda2697ad4310f4044b13d98 Bug-Url: https://bugzilla.redhat.com/1159789 Bug-Url: https://bugzilla.redhat.com/1162549 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/database.py 1 file changed, 40 insertions(+), 24 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4053b5426b1fcb64fda2697ad4310f4044b13d98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Allow multiple fencing alerts for the same host
by emesika＠redhat.com 11 Nov '14

11 Nov '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Allow multiple fencing alerts for the same host ...................................................................... core: Allow multiple fencing alerts for the same host Allow following alerts ussed in fencing flow to exist in db (and be displayed to user) multiple times for each host: VDS_ALERT_FENCE_OPERATION_SKIPPED_BROKEN_CONNECTIVITY VDS_ALERT_NOT_RESTARTED_DUE_TO_POLICY VDS_ALERT_FENCE_DISABLED_BY_CLUSTER_POLICY FENCING_DISABLED_IN_CLUSTER_POLICY Change-Id: Ic1b13cfac9d8b3469a6458e13691fbfde197ec80 Bug-Url: https://bugzilla.redhat.com/1142904 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java 2 files changed, 8 insertions(+), 6 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1b13cfac9d8b3469a6458e13691fbfde197ec80 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Allow multiple alerts of the same type for host
by emesika＠redhat.com 11 Nov '14

11 Nov '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Allow multiple alerts of the same type for host ...................................................................... core: Allow multiple alerts of the same type for host Add repeatable attribute to AuditLog and AuditLogableBase class which allows saving multiple alerts of the same type for the same host. Change-Id: I0deda59438b61c88d45f45af59e85b003f218e1a Bug-Url: https://bugzilla.redhat.com/1142904 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java M packaging/dbscripts/audit_log_sp.sql 6 files changed, 109 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0deda59438b61c88d45f45af59e85b003f218e1a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0