- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: filter shareable disks on preview snapshot
by derez＠redhat.com 12 Nov '14

12 Nov '14

Daniel Erez has submitted this change and it was merged. Change subject: core: filter shareable disks on preview snapshot ...................................................................... core: filter shareable disks on preview snapshot TryBackToAllSnapshotsOfVm -> getImagesToPreview: filter out shareable/nonsnapable disks. Change-Id: I232d3387e203933bdbb12a5e3401c096278a41d3 Bug-Url: https://bugzilla.redhat.com/1161916 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I232d3387e203933bdbb12a5e3401c096278a41d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: exportfs after restarting nfs services
by piotr.kliczewski＠gmail.com 12 Nov '14

12 Nov '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: setup: exportfs after restarting nfs services ...................................................................... packaging: setup: exportfs after restarting nfs services Bug-Url: https://bugzilla.redhat.com/1163395 Change-Id: I4d231c28d2fd2e28163fbe382debbf080628d9b9 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit f179315e6a77e27b3d9894ec8d20ebfd3aa1a461) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d231c28d2fd2e28163fbe382debbf080628d9b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: exportfs after restarting nfs services
by sbonazzo＠redhat.com 12 Nov '14

12 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: exportfs after restarting nfs services ...................................................................... packaging: setup: exportfs after restarting nfs services Change-Id: I4d231c28d2fd2e28163fbe382debbf080628d9b9 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d231c28d2fd2e28163fbe382debbf080628d9b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[sdk_3.5]: sdk: Add some usage documentation
by juan.hernandez＠redhat.com 12 Nov '14

12 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Add some usage documentation ...................................................................... sdk: Add some usage documentation This patch improves the README.md file adding some documentation about how to use the SDK with Maven, and about the dependencies required. Change-Id: Ic4b76369f4573465c6779e249664b104275e99e6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 25eddda411974849fbb3ea423298e085b1dd2ada) --- M ovirt-engine-sdk-java/README.md 1 file changed, 25 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4b76369f4573465c6779e249664b104275e99e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk-java[master]: sdk: Add some usage documentation
by juan.hernandez＠redhat.com 12 Nov '14

12 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Add some usage documentation ...................................................................... sdk: Add some usage documentation This patch improves the README.md file adding some documentation about how to use the SDK with Maven, and about the dependencies required. Change-Id: Ic4b76369f4573465c6779e249664b104275e99e6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java/README.md 1 file changed, 25 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4b76369f4573465c6779e249664b104275e99e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Refactor network compliance enforcement
by masayag＠redhat.com 12 Nov '14

12 Nov '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Refactor network compliance enforcement ...................................................................... engine: Refactor network compliance enforcement The motivation of this change is: 1. To decouple network incompatibility auditing from the network compliance check. 2. To extract clusterNetworks which will be used by the network interfaces topology persisters in the following patches. Change-Id: I5ced33a7ddfe71ea1c69ef5a18cbf468c126ec1c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/34565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ced33a7ddfe71ea1c69ef5a18cbf468c126ec1c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Lay foundation for method refactor
by masayag＠redhat.com 12 Nov '14

12 Nov '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Lay foundation for method refactor ...................................................................... engine: Lay foundation for method refactor Extracts the clusterNetworks into an argument, so auditNetworkCompliance would be pulled out of this method. Change-Id: I3907cde04cc5c90d47958871b177f5aa61e83ae1 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/34564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3907cde04cc5c90d47958871b177f5aa61e83ae1 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Extract method of network compliance check
by masayag＠redhat.com 12 Nov '14

12 Nov '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extract method of network compliance check ...................................................................... engine: Extract method of network compliance check Change-Id: Iadc66b853055b7237f9dbe78793f53bb20299b04 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/34563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadc66b853055b7237f9dbe78793f53bb20299b04 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Support replacements in ValidationResult
by masayag＠redhat.com 12 Nov '14

12 Nov '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Support replacements in ValidationResult ...................................................................... engine: Support replacements in ValidationResult The static validation methods of ValidationResult are enhanced with the support of replacements, which are already supported by the ValidationResult instantiation. Change-Id: I5f2bd85af2d129e0647b100b90908a1314419da2 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ValidationResultTest.java 2 files changed, 43 insertions(+), 23 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Verified Objections: Yevgeny Zaspitsky: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/34855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f2bd85af2d129e0647b100b90908a1314419da2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: filters: fix formatting
by oourfali＠redhat.com 12 Nov '14

12 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: filters: fix formatting ...................................................................... aaa: filters: fix formatting Change-Id: I03ee9a1e9c7c57751eb206e633efeef721fe98ef Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03ee9a1e9c7c57751eb206e633efeef721fe98ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0