- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Set storage type as set in the paramteres.
by mlipchuk＠redhat.com 13 Nov '14

13 Nov '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Set storage type as set in the paramteres. ...................................................................... core: Set storage type as set in the paramteres. 1) Set the storage type of the storage after it was fetched from VDSM in GetExistingStorageDomainListQuery 2) use getStorageDomainsList to be fetched without Storage Domains type. Change-Id: I9a6f2f22b09de9daffde5e003528324237d6835f Bug-Url: https://bugzilla.redhat.com/1157240 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetExistingStorageDomainListQuery.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a6f2f22b09de9daffde5e003528324237d6835f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use GetExistingStorageDomainList to fetch all type of ...
by mlipchuk＠redhat.com 13 Nov '14

13 Nov '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use GetExistingStorageDomainList to fetch all type of Storages ...................................................................... core: Use GetExistingStorageDomainList to fetch all type of Storages Use GetExistingStorageDomainList to fetch different tpye of storage type, so user can manipulate the Storage Domain type while importing it. Change-Id: If3a082e0bddaad745788b9b166f2b17eff0fbd17 Bug-Url: https://bugzilla.redhat.com/1157240 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainsListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 5 files changed, 10 insertions(+), 7 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3a082e0bddaad745788b9b166f2b17eff0fbd17 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix icons on role popup
by awels＠redhat.com 12 Nov '14

12 Nov '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fix icons on role popup ...................................................................... webadmin: fix icons on role popup At some point, the role icons in RoleView were stretched to 30px tall. They looked ridiculous. Fixed. Change-Id: Id804691ba5799ca86733e4cba063b7ceb8774aae Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 2 files changed, 6 insertions(+), 11 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/35059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id804691ba5799ca86733e4cba063b7ceb8774aae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: validate vmNotDuringSnapshot on LiveMigrateVmDisks
by tnisan＠redhat.com 12 Nov '14

12 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: validate vmNotDuringSnapshot on LiveMigrateVmDisks ...................................................................... core: validate vmNotDuringSnapshot on LiveMigrateVmDisks LiveMigrateVmDisksCommand: valifate VM is not during snapshot on canDoAction. Change-Id: Ide91ad3042bbf0889ba948763ce88444045fc104 Bug-Url: https://bugzilla.redhat.com/1162120 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java 2 files changed, 19 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/35097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide91ad3042bbf0889ba948763ce88444045fc104 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: filter shareable disks on preview snapshot
by tnisan＠redhat.com 12 Nov '14

12 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: filter shareable disks on preview snapshot ...................................................................... core: filter shareable disks on preview snapshot TryBackToAllSnapshotsOfVm -> getImagesToPreview: filter out shareable/nonsnapable disks. Change-Id: I232d3387e203933bdbb12a5e3401c096278a41d3 Bug-Url: https://bugzilla.redhat.com/1161916 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/35098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I232d3387e203933bdbb12a5e3401c096278a41d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db: add a common function for index creation
by emesika＠redhat.com 12 Nov '14

12 Nov '14

Eli Mesika has submitted this change and it was merged. Change subject: db: add a common function for index creation ...................................................................... db: add a common function for index creation This patch adds a common function that drop the index if exists and creates it after that. This is done in order to prevent scripts failures when the index is not dropped and an attempt to re-create it is done Change-Id: I6e6e2577ceac435e25030dfde6ff6c4c3f8a7278 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/common_sp.sql 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified Allon Mureinik: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e6e2577ceac435e25030dfde6ff6c4c3f8a7278 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: janitorial: guest monitor: simplify getGuestName()
by alitke＠redhat.com 12 Nov '14

12 Nov '14

Adam Litke has submitted this change and it was merged. Change subject: janitorial: guest monitor: simplify getGuestName() ...................................................................... janitorial: guest monitor: simplify getGuestName() The get() method of the dictionaries has the same semantic of the old method, but just one line of code. Change-Id: I73e2fd6e6eb97cc51d28f70c8ade818fdc74e0be Signed-off-by: Francesco Romani <fromani(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/31588 Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/GuestMonitor.py 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Adam Litke: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/31588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73e2fd6e6eb97cc51d28f70c8ade818fdc74e0be Gerrit-PatchSet: 4 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in mom[master]: Add valid function to the policy parser
by alitke＠redhat.com 12 Nov '14

12 Nov '14

Adam Litke has submitted this change and it was merged. Change subject: Add valid function to the policy parser ...................................................................... Add valid function to the policy parser This new valid function accepts any number of arguments and returns True when none of the arguments evaluates to nil (None). It returns False in all other cases. The Common Lisp way of doing this is by using higher order functions like this: (every #'null my-list) Our parser lacks support for such constructs so I decided to add the new function. This will allow us to escape parts of the policy with checks for the presence of optional collector fields. For example: (if (valid guest.balloon_min guest.balloon_cur) (process_ballooning)) Change-Id: I5aa31886811593860c75cf13bf7743e85fde7358 Related-To: https://bugzilla.redhat.com/1143992 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/34791 Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/Policy/Parser.py M tests/ParserTests.py 2 files changed, 60 insertions(+), 1 deletion(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/34791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5aa31886811593860c75cf13bf7743e85fde7358 Gerrit-PatchSet: 5 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in mom[master]: Documentation: document the mandatory field behavior
by alitke＠redhat.com 12 Nov '14

12 Nov '14

Adam Litke has submitted this change and it was merged. Change subject: Documentation: document the mandatory field behavior ...................................................................... Documentation: document the mandatory field behavior Make it clear how mandatory field absence should be affect the policy. Change-Id: Iba2f96ec6edca93002dd79ca7c66c4f1ab411141 Bug-Url: https://bugzilla.redhat.com/1143992 Signed-off-by: Roy Golan <rgolan(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/35011 Reviewed-by: Martin Sivák <msivak(a)redhat.com> Reviewed-by: Adam Litke <alitke(a)redhat.com> Tested-by: Adam Litke <alitke(a)redhat.com> --- M mom/Collectors/Collector.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Adam Litke: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba2f96ec6edca93002dd79ca7c66c4f1ab411141 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: validate vmNotDuringSnapshot on LiveMigrateVmDisks
by derez＠redhat.com 12 Nov '14

12 Nov '14

Daniel Erez has submitted this change and it was merged. Change subject: core: validate vmNotDuringSnapshot on LiveMigrateVmDisks ...................................................................... core: validate vmNotDuringSnapshot on LiveMigrateVmDisks LiveMigrateVmDisksCommand: valifate VM is not during snapshot on canDoAction. Change-Id: Ide91ad3042bbf0889ba948763ce88444045fc104 Bug-Url: https://bugzilla.redhat.com/1162120 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java 2 files changed, 19 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide91ad3042bbf0889ba948763ce88444045fc104 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0