- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[master]: get rid of obsoleted getVolumePath calls
by msivak＠redhat.com 06 Nov '14

06 Nov '14

Martin Sivák has submitted this change and it was merged. Change subject: get rid of obsoleted getVolumePath calls ...................................................................... get rid of obsoleted getVolumePath calls https://bugzilla.redhat.com/show_bug.cgi?id=1159240 Change-Id: Ia0f4663141a9901af9edd9361ac9fe55f8c918bc Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/storage_backends.py 1 file changed, 40 insertions(+), 37 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/34881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0f4663141a9901af9edd9361ac9fe55f8c918bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: agent: handle malformed metadata better
by msivak＠redhat.com 06 Nov '14

06 Nov '14

Martin Sivák has submitted this change and it was merged. Change subject: agent: handle malformed metadata better ...................................................................... agent: handle malformed metadata better Change-Id: Ie5d2ad055cbea13490d04ec3589c32a3c08a5119 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1158925 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/34658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5d2ad055cbea13490d04ec3589c32a3c08a5119 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: respect the timeout in EngineUpBadHealth state (better fix)
by msivak＠redhat.com 06 Nov '14

06 Nov '14

Martin Sivák has submitted this change and it was merged. Change subject: respect the timeout in EngineUpBadHealth state (better fix) ...................................................................... respect the timeout in EngineUpBadHealth state (better fix) Change-Id: Id86274fabe5f66ee42fc0235a4091205afedd79c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1150600 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/states.py 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/34857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id86274fabe5f66ee42fc0235a4091205afedd79c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: VM should be PINNED_TO_HOST when using host cpu flags
by rgolan＠redhat.com 06 Nov '14

06 Nov '14

Roy Golan has submitted this change and it was merged. Change subject: core: VM should be PINNED_TO_HOST when using host cpu flags ...................................................................... core: VM should be PINNED_TO_HOST when using host cpu flags according to the bug a VM using pass-through host cpu (host cpu flags) might bump into issues when migrating to cpu lower than the SRC hardware and this is, apparently not supported Change-Id: I781891e91680bbe8095097a2a1e4c426e318c720 Bug-Url: https://bugzilla.redhat.com/1052168 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I781891e91680bbe8095097a2a1e4c426e318c720 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Don't allow migration when using host cpu
by rgolan＠redhat.com 06 Nov '14

06 Nov '14

Roy Golan has submitted this change and it was merged. Change subject: webadmin: Don't allow migration when using host cpu ...................................................................... webadmin: Don't allow migration when using host cpu 1."Use Host CPU" label is change to Pass-through Host Cpu Its the actual behavior we use below, see libvirt doc[1] 2. make sure the only migration mode allowed is Non migratable [1] http://libvirt.org/formatdomain.html#elementsCPU Change-Id: Ifb736a69ff2a0a4995e18a5842a352d61f93bf00 Bug-Url: https://bugzilla.redhat.com/1052168 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb736a69ff2a0a4995e18a5842a352d61f93bf00 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Set endAction try again to false on failure
by yzaslavs＠redhat.com 06 Nov '14

06 Nov '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : Set endAction try again to false on failure ...................................................................... engine : Set endAction try again to false on failure On failure of commands with handlers, if no handler has been executed the endWithFailure is not invoked on the handlers. This can leave setEndActionTryAgain to true causing AsyncTaskManager to continuously wait for commands completion. In such cases the CommandBase should set the setEndActionTryAgain to false so the command can converge. Change-Id: Idf6f8755a22f2654b9af6678f1353f9b6ae08942 Bug-Url: https://bugzilla.redhat.com/1159325 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf6f8755a22f2654b9af6678f1353f9b6ae08942 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: adjusted width of create template dialog
by derez＠redhat.com 06 Nov '14

06 Nov '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: adjusted width of create template dialog ...................................................................... webadmin: adjusted width of create template dialog Adjusted width for better accommodating disks table. Change-Id: I23649dd270935aead25815eaff311b2efadba814 Bug-Url: https://bugzilla.redhat.com/1149466 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java 5 files changed, 6 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/34799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23649dd270935aead25815eaff311b2efadba814 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: fail the build if osinfo-defaults.properties fail...
by tnisan＠redhat.com 06 Nov '14

06 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: fail the build if osinfo-defaults.properties fails to parse ...................................................................... packaging: fail the build if osinfo-defaults.properties fails to parse check the properties file we ship with the exact code that checks it at runtime when the engine loads. this test is hooked into the packaging process and must fail it. Change-Id: I9aead46c067134dbc59b83ad70d1715ec004587c Bug-Url: https://bugzilla.redhat.com/1056965 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M Makefile A build/validations/pom.xml A build/validations/src/test/java/org/ovirt/engine/build/validations/OsinfoValidationsTest.java M packaging/conf/osinfo-defaults.properties 4 files changed, 50 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9aead46c067134dbc59b83ad70d1715ec004587c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Date formatting when deleting a snapshot
by tnisan＠redhat.com 06 Nov '14

06 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Date formatting when deleting a snapshot ...................................................................... webadmin: Date formatting when deleting a snapshot When deleting a VM's snapshot a formatted date is now shown based on a constant taken from another component in the system (DiskGeneralModel) for system consistency. this constant is intended to be exported to some util class later on. Bug-Url: https://bugzilla.redhat.com/1158959 Change-Id: I5d6a3f43557696fd35256b4a3fc55a5fbf59fdba Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Amit Aviram: Verified -- To view, visit http://gerrit.ovirt.org/34837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d6a3f43557696fd35256b4a3fc55a5fbf59fdba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Correction of UI Constants
by tnisan＠redhat.com 06 Nov '14

06 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Correction of UI Constants ...................................................................... webadmin: Correction of UI Constants Messages that was using the word "Detach" incorrectly, namely using capital "D" when there was no need to- changed to "detach". In addition, the "Data Center" part of the message who related to detaching storage from a data center has changed back to "Data Center(s)" due to the fact that it is possible that some chosen Storage is attached to more than one Data Center. Change-Id: Id288103a417db6aee13e3f990b2d0af3fb3827f7 Bug-Url: https://bugzilla.redhat.com/1152558 Relates-To:https://bugzilla.redhat.com/1149457 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Amit Aviram: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id288103a417db6aee13e3f990b2d0af3fb3827f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0