- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Hot plug CPU - allow over-commit in QEMU limits
by tnisan＠redhat.com 06 Nov '14

06 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Hot plug CPU - allow over-commit in QEMU limits ...................................................................... core: Hot plug CPU - allow over-commit in QEMU limits Allow to hot plug CPUs up to QEMU limits[1] even if they over-commit the host resources. [1] http://doc.opensuse.org/products/draft/SLES/SLES-kvm_sd_draft/cha.kvm.limit… Change-Id: Ic27aefa52543b201d018d07296de1e4983bfb863 Bug-Url: https://bugzilla.redhat.com/1097195 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetNumberOfCpusCommand.java 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic27aefa52543b201d018d07296de1e4983bfb863 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: Fix Vm Dialog name validation
by tjelinek＠redhat.com 06 Nov '14

06 Nov '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix Vm Dialog name validation ...................................................................... frontend: Fix Vm Dialog name validation Add missing call to setValidTab upon validation of name, description and comment properties. Change-Id: If15c482953c48107d155d1c5e8206c675ff9fb23 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124363 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/34858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If15c482953c48107d155d1c5e8206c675ff9fb23 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: create template - sub version label
by derez＠redhat.com 06 Nov '14

06 Nov '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: create template - sub version label ...................................................................... webadmin: create template - sub version label Changed label to: "Create as a Template Sub Version" Change-Id: Ied4b6637dfc4ce34c2f59286db305314fc2217a4 Bug-Url: https://bugzilla.redhat.com/1149466 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/34798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied4b6637dfc4ce34c2f59286db305314fc2217a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: validate osinfo properties files - fail backend on error
by tnisan＠redhat.com 06 Nov '14

06 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: validate osinfo properties files - fail backend on error ...................................................................... core: validate osinfo properties files - fail backend on error validate the osinfo properties files by the order of loading. on-error, a RuntimeException is thrown, which should fail the backend from loading. The parsing itself is implemented using ANTLR parser and lexer generator and the Osinfo.g4 grammar file. Osinfo.g4 grammar file that expresses the syntax of the properties file and except for unique validation needs should be the only place to be changed when needed. OsinfoPreferencesParser.java the tool to parse a property file with and match is against the syntax OsinfoPreferencesParser.parse("path/to/file") Change-Id: Ie33bf9446857e15d13221271120a3ff2b400350c Bug-Url: https://bugzilla.redhat.com/1056965 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/dependencies/pom.xml A backend/manager/dependencies/src/main/modules/org/antlr/antlr4-runtime/main/module.xml M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/utils/exclude-filters.xml M backend/manager/modules/utils/pom.xml A backend/manager/modules/utils/src/main/antlr4/org/ovirt/engine/core/utils/osinfo/Osinfo.g4 M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsInfoPreferencesLoader.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsinfoPropertiesParser.java M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml M backend/manager/modules/utils/src/test/resources/osinfo.conf.d/00-osinfo-test.properties M pom.xml 11 files changed, 321 insertions(+), 5 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie33bf9446857e15d13221271120a3ff2b400350c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Pass password across filters so it will be known during...
by tnisan＠redhat.com 06 Nov '14

06 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: aaa: Pass password across filters so it will be known during LoginUserCommand ...................................................................... aaa: Pass password across filters so it will be known during LoginUserCommand As basic authentication passed auth record to Login filter, the passsword used for authentication was not passed, hence was not set in the session data container. Change-Id: Ie48f8f1408b17882337f4fd0a8c38f7829472cf2 Bug-Url: https://bugzilla.redhat.com/1141541 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> (cherry picked from commit 3d4c423269b8dd099b2fe4bce43b0d2efa6f9e33) --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/BasicAuthenticationFilter.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/LoginFilter.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LoginUserParameters.java 4 files changed, 7 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie48f8f1408b17882337f4fd0a8c38f7829472cf2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : query execution failed due to insufficient permissions
by tnisan＠redhat.com 06 Nov '14

06 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: engine : query execution failed due to insufficient permissions ...................................................................... engine : query execution failed due to insufficient permissions Adding a disk using a user with DiskCreator privileges logs insufficient permissions message in the log Change-Id: I11adfe9c49d1e57ecc88d1828ed63884016c33e8 Bug-Url: https://bugzilla.redhat.com/1153043 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTasksStatusesByTasksIDsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 2 files changed, 11 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11adfe9c49d1e57ecc88d1828ed63884016c33e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : Add User Id to async tasks table
by tnisan＠redhat.com 06 Nov '14

06 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: engine : Add User Id to async tasks table ...................................................................... engine : Add User Id to async tasks table Add user id to async tasks table, the user id will be used to determine if the user has permissions to see the tasks for which the user requested statuses When tasks are retrieved from vdsm after server restart the user id information is not available and will be set to Guid.Empty when tasks are created Change-Id: Ib5b9f3dfb38d6d56f186aa87f3ff75007a0d3997 Bug-Url: https://bugzilla.redhat.com/1153043 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTask.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java M packaging/dbscripts/async_tasks_sp.sql A packaging/dbscripts/upgrade/03_05_1150_add_user_id_to_async_tasks.sql 7 files changed, 73 insertions(+), 4 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5b9f3dfb38d6d56f186aa87f3ff75007a0d3997 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: packaging: spec: add support for EL7 builds
by sradco＠redhat.com 06 Nov '14

06 Nov '14

Shirly Radco has submitted this change and it was merged. Change subject: packaging: spec: add support for EL7 builds ...................................................................... packaging: spec: add support for EL7 builds Change-Id: I5faef659a862f720fd02ef219d6a178e099ab66d Bug-Url: https://bugzilla.redhat.com/1159293 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 4b1608d13ccd07fcc0c488d0b36ffe915e94d59f) --- M ovirt-engine-dwh.spec.in 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified Shirly Radco: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5faef659a862f720fd02ef219d6a178e099ab66d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Check live snapshot capabilities in live storage migra...
by tnisan＠redhat.com 05 Nov '14

05 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Check live snapshot capabilities in live storage migration CDA ...................................................................... core: Check live snapshot capabilities in live storage migration CDA Change-Id: Idba6581587d1908e4428ea2d18878c2f62a0b317 Bug-Url: https://bugzilla.redhat.com/1158049 Bug-Url: https://bugzilla.redhat.com/1105846 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/LiveSnapshotValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java 4 files changed, 56 insertions(+), 29 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idba6581587d1908e4428ea2d18878c2f62a0b317 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Check live snapshot capabilities in live storage migra...
by tnisan＠redhat.com 05 Nov '14

05 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Check live snapshot capabilities in live storage migration CDA ...................................................................... core: Check live snapshot capabilities in live storage migration CDA Change-Id: Idba6581587d1908e4428ea2d18878c2f62a0b317 Bug-Url: https://bugzilla.redhat.com/1158049 Bug-Url: https://bugzilla.redhat.com/1105846 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/LiveSnapshotValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java 4 files changed, 56 insertions(+), 29 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idba6581587d1908e4428ea2d18878c2f62a0b317 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0