- Engine-commits - oVirt List Archives

Change in jenkins[master]: Added db upgrade job
by dcaroest＠redhat.com 04 Nov '14

04 Nov '14

David Caro has submitted this change and it was merged. Change subject: Added db upgrade job ...................................................................... Added db upgrade job I had to add also some extra files: * support to upgrade from or to a branch * whitelist scripts, triggers, builder and publisher * generic gerrit scm Change-Id: Iae2aaf97d330757441872586aa844ab07cd42f36 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/confs/groovy-scripts/whitelist-filter.groovy A jobs/confs/shell-scripts/ovirt-engine_upgrade-db.cleanup.sh A jobs/confs/shell-scripts/ovirt-engine_upgrade-db.sh A jobs/confs/shell-scripts/whitelist-filter.sh A jobs/confs/yaml/builders/ovirt-engine_upgrade-db.yaml A jobs/confs/yaml/builders/whitelist.yaml A jobs/confs/yaml/jobs/ovirt-engine/ovirt-engine_upgrade-db.yaml A jobs/confs/yaml/publishers/whitelist.yaml A jobs/confs/yaml/scms/gerrit.yaml A jobs/confs/yaml/templates/engine-upgrade-db.yaml M jobs/confs/yaml/triggers/gerrit.yaml 11 files changed, 272 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae2aaf97d330757441872586aa844ab07cd42f36 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add MaxHostNetworkQosShares configuration value
by lvernia＠redhat.com 04 Nov '14

04 Nov '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Add MaxHostNetworkQosShares configuration value ...................................................................... core: Add MaxHostNetworkQosShares configuration value This will be used to determine the maximum number of allowed shares given to a specific network - this will be used to set the granularity/resolution of traffic prioritization by network. Change-Id: Idfd8df78fd8a06b5e73d1a66f12897d423cdcfe0 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 4 files changed, 8 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/34762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfd8df78fd8a06b5e73d1a66f12897d423cdcfe0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove VmCommand.getBlockSparseInitSizeInGb
by amureini＠redhat.com 04 Nov '14

04 Nov '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove VmCommand.getBlockSparseInitSizeInGb ...................................................................... core: Remove VmCommand.getBlockSparseInitSizeInGb This function is unused, and thus could (and should!) be removed. Change-Id: I901faf1a6fec899c0c3604d23533bf180c88eee1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I901faf1a6fec899c0c3604d23533bf180c88eee1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: add element ids to vm general subtab
by awels＠redhat.com 03 Nov '14

03 Nov '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal, webadmin: add element ids to vm general subtab ...................................................................... userportal, webadmin: add element ids to vm general subtab Added element ids to the vm general subtab -- every row, every column in the form. The ids will have the format unique-prefix_rowX_colX_label and unique-prefix_rowX_colX_value. Also added some infrastructure to easily add ids to all of the sub-tab form views. Change-Id: I0d2c6843c61a1d9364a36e8d4d3b5b64a1726f69 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementIdUtils.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/AbstractFormPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/AbstractModelBoundFormWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineGeneralView.java 4 files changed, 48 insertions(+), 1 deletion(-) Approvals: Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d2c6843c61a1d9364a36e8d4d3b5b64a1726f69 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: jsonrpc: version bump
by tnisan＠redhat.com 03 Nov '14

03 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: jsonrpc: version bump ...................................................................... jsonrpc: version bump Bug-Url: https://bugzilla.redhat.com/1154398 Change-Id: Ib69768ab2b384136308e16624a365c98583fba63 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib69768ab2b384136308e16624a365c98583fba63 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core, engine, webadmin: Consider only online logical CPUs
by ofrenkel＠redhat.com 03 Nov '14

03 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core, engine, webadmin: Consider only online logical CPUs ...................................................................... core, engine, webadmin: Consider only online logical CPUs This patch reports the ids of the logical CPUs which are online in the Hosts tab of the webadmin interface, and uses this information to validate the CPU pinning during the VM creation. A new column in the vds_dynamic table was added to store this list. Change-Id: Ib20f20d6003502fe2f2864abb5ad8f4f5a19ecdc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148092 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_0510_add_online_cpu_list.sql M packaging/dbscripts/vds_sp.sql 15 files changed, 112 insertions(+), 17 deletions(-) Approvals: Vitor de Lima: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib20f20d6003502fe2f2864abb5ad8f4f5a19ecdc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: jsonrpc: Introduction of new logging framework
by tnisan＠redhat.com 03 Nov '14

03 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: jsonrpc: Introduction of new logging framework ...................................................................... jsonrpc: Introduction of new logging framework In order to be able to change logging framework from commons-logging to slf4j and support future vdsm-jsonrpc-java updates we, introduce additional dependency in module.xml. Change-Id: I8669dcdb1dbbde4f6fa45443e120fceae1597059 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1159832 --- M backend/manager/dependencies/src/main/modules/org/ovirt/vdsm-jsonrpc-java/main/module.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34503 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8669dcdb1dbbde4f6fa45443e120fceae1597059 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: Fix frontend compile fedora 21
by tnisan＠redhat.com 03 Nov '14

03 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: userportal,webadmin: Fix frontend compile fedora 21 ...................................................................... userportal,webadmin: Fix frontend compile fedora 21 - On java < 8 the missing class definition for GenericApiGWTServiceAsync was silently ignored and would not cause an issue, but with fedora 21 you can't downgrade to java < 8 so the missing class would cause the compile to fail. The class is generated but we never added the generated classes path to the source definition in the POM.xml Change-Id: Ib7fc9c9ecebf39dcae3a0b9c3923e2790dbb179a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1159026 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/pom.xml 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Alexander Wels: Verified Vojtech Szocs: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7fc9c9ecebf39dcae3a0b9c3923e2790dbb179a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: ignore powering-up events when vm is being migrated
by ahadas＠redhat.com 03 Nov '14

03 Nov '14

Arik Hadas has submitted this change and it was merged. Change subject: core: ignore powering-up events when vm is being migrated ...................................................................... core: ignore powering-up events when vm is being migrated No need to decrease the pending memory & cpu because of powering-up events while the VM is being migrated. The migrate command is responsible to decrease the pending resources when it is finished. Change-Id: Ib1c57900fd3fbc0cb9a5953bee90e53ab11ef7c4 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 4 files changed, 20 insertions(+), 24 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1c57900fd3fbc0cb9a5953bee90e53ab11ef7c4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: assume live snapshot supported as default
by tnisan＠redhat.com 03 Nov '14

03 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: assume live snapshot supported as default ...................................................................... core: assume live snapshot supported as default VDSM will report if underlying QEMU reports live snapshot or not. This information is provided through libvirt. If libvirt, or VDSM, no longer report this capability, Engine get stuck with the old value and it is no longer updated. There is an unlucky case on CentOS and RHEL 6.6 on which we can hit this condition. To fix that, this patch assumes live snapshot is supported if we don't have word from VDSM. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1159211 Related-To: http://bugzilla.redhat.com/1149460 Related-To: http://bugzilla.redhat.com/1158974 Change-Id: I4660560e08f606e2b16a580ef60618abfad49244 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4660560e08f606e2b16a580ef60618abfad49244 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0