- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: Stop remote dwh
by sbonazzo＠redhat.com 03 Nov '14

03 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Stop remote dwh ...................................................................... packaging: setup: Stop remote dwh Change-Id: Ib7e345bf71c2a5ecdddc777487d67fcae9d4b84a Bug-Url: https://bugzilla.redhat.com/1024028 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- A packaging/setup/ovirt_engine_setup/engine_common/dwh_history_timekeeping.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py 3 files changed, 226 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Shirly Radco: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/34566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7e345bf71c2a5ecdddc777487d67fcae9d4b84a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: don't allow snapshot for suspended vm
by ofrenkel＠redhat.com 03 Nov '14

03 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: don't allow snapshot for suspended vm ...................................................................... core: don't allow snapshot for suspended vm creating snapshot while vm is suspended is problematic, since when resuming, vdsm still use the old volumes, another problem is that the hibernation volumes info is not saved in the ovf. Change-Id: Icf2c4c3ec3561df1d35f5e4da964664d63598434 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120232 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java 3 files changed, 19 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf2c4c3ec3561df1d35f5e4da964664d63598434 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Update host network QoS supported version to 3.6
by lvernia＠redhat.com 03 Nov '14

03 Nov '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Update host network QoS supported version to 3.6 ...................................................................... core: Update host network QoS supported version to 3.6 It used to be 3.4, but due to shortcomings of libvirt it is only made available in 3.6. Change-Id: I8bb61c373cb99f36e00d913dd61afc3b33ae34eb Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/34118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bb61c373cb99f36e00d913dd61afc3b33ae34eb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: assume live snapshot supported as default
by ofrenkel＠redhat.com 03 Nov '14

03 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: assume live snapshot supported as default ...................................................................... core: assume live snapshot supported as default VDSM will report if underlying QEMU reports live snapshot or not. This information is provided through libvirt. If libvirt, or VDSM, no longer report this capability, Engine get stuck with the old value and it is no longer updated. There is an unlucky case on CentOS and RHEL 6.6 on which we can hit this condition. To fix that, this patch assumes live snapshot is supported if we don't have word from VDSM. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1159211 Related-To: http://bugzilla.redhat.com/1149460 Related-To: http://bugzilla.redhat.com/1158974 Change-Id: I4660560e08f606e2b16a580ef60618abfad49244 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4660560e08f606e2b16a580ef60618abfad49244 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: osinfo - fail backend startup on coliding os id error
by rgolan＠redhat.com 03 Nov '14

03 Nov '14

Roy Golan has submitted this change and it was merged. Change subject: core: osinfo - fail backend startup on coliding os id error ...................................................................... core: osinfo - fail backend startup on coliding os id error fail loading the backend by throwing a RuntimeException if an osinfo properties have colliding id's. e.g os.linux.id.value = 12345 os.windows.id.value = 12345 obviously wrong and should fail with logged exception "java.lang.RuntimeException: colliding os id 12345 at node /os/windows/id" Change-Id: I9f19a1d33336f020b1ff71d9bcfd06eaee45e81d Bug-Url: https://bugzilla.redhat.com/996055 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java 2 files changed, 21 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f19a1d33336f020b1ff71d9bcfd06eaee45e81d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: adding retry for host start for PPC
by tnisan＠redhat.com 02 Nov '14

02 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: adding retry for host start for PPC ...................................................................... core: adding retry for host start for PPC Sometimes a restart operation started by engine is not completed because the host PM failed to put the host on 'on' state This occurred on PPC hosts only until now. Some fencing scripts as the one used here (IPMI) have an option to se retries for the 'on' operation by sending : retry_on=<number> The patch adds "retry_on=2" for the relevant PPC fencing scripts such that this will be sent by engine as a default when a PPC host has one of those agents used Change-Id: I2c7a195526eb3f6454116806131294de2d3fc067 Bug-Url: https://bugzilla.redhat.com/1151553 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c7a195526eb3f6454116806131294de2d3fc067 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: set boot order index 0 for unmanaged nic
by ahadas＠redhat.com 02 Nov '14

02 Nov '14

Arik Hadas has submitted this change and it was merged. Change subject: core: set boot order index 0 for unmanaged nic ...................................................................... core: set boot order index 0 for unmanaged nic This patch fix NPE which was thrown when computing boot order for a VM that has unmanaged network interface. The boot order index for unmanaged network interfaces will now be 0. Change-Id: If299f5c10dbfd15cf5ebe01f6d7911a7f92eb56f Bug-Url: https://bugzilla.redhat.com/1155667 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtilsTest.java 2 files changed, 23 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/34732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If299f5c10dbfd15cf5ebe01f6d7911a7f92eb56f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix typos in test.
by oourfali＠redhat.com 02 Nov '14

02 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix typos in test. ...................................................................... core: fix typos in test. Change-Id: I15a9c82059d4c470dc8de6b6c69ae1a818dedf25 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VdcActionTypeTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15a9c82059d4c470dc8de6b6c69ae1a818dedf25 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Create default disk profiles for data domains
by tnisan＠redhat.com 02 Nov '14

02 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Create default disk profiles for data domains ...................................................................... core: Create default disk profiles for data domains All data domains should have default disk profiles with unlimited QoS (currently implemented by null) Otherwise all existing data domains needs manual intervention for creating disks if the data center is upgraded to version 3.5 Change-Id: I3ee3174e5c7bef3bcd5591b9cd99ff5324bee488 Bug-Url: https://bugzilla.redhat.com/1145241 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_1130_create_default_disk_profiles.sql 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Roy Golan: Verified -- To view, visit http://gerrit.ovirt.org/34598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ee3174e5c7bef3bcd5591b9cd99ff5324bee488 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: handle host architecture in fence flow
by tnisan＠redhat.com 02 Nov '14

02 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: handle host architecture in fence flow ...................................................................... core: handle host architecture in fence flow This patch adds a getArchitecture method to VDS. It is used in order to get the host architecture using its cpu flags, in case that this is null, the architecture of the containing cluster is used. Please note that a separate call to get VdsDynamic information for the host since the VDS object passed to the fencing code is slim and does not contain any dymanic information. Change-Id: I081361c9f956ea71a715acf0368c79c7130674c7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1149235 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsArchitectureHelper.java 3 files changed, 36 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I081361c9f956ea71a715acf0368c79c7130674c7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0