- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Fix not to revert patch for BZ 1123780
by oourfali＠redhat.com 05 Nov '14

05 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Fix not to revert patch for BZ 1123780 ...................................................................... webadmin: Fix not to revert patch for BZ 1123780 Fix regress cause by patch 27bc7af603b0a0 which over wrote changes made by patch Id4b46a36bd676 for BZ 1123780. Change-Id: If2353b4123851b807e38450991958d28aa4ad751 Bug-Url: https://bugzilla.redhat.com/1123780 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved mooli tayer: Verified; Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2353b4123851b807e38450991958d28aa4ad751 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Missing Guid ctor for CreateSnapshotFromTemplate
by oourfali＠redhat.com 05 Nov '14

05 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Missing Guid ctor for CreateSnapshotFromTemplate ...................................................................... core: Missing Guid ctor for CreateSnapshotFromTemplate Change-Id: I0c43ab5f83db55587894f32116ab229fd28cff36 Bug-Url: https://bugzilla.redhat.com/1160537 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotFromTemplateCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/34809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c43ab5f83db55587894f32116ab229fd28cff36 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Missing Guid ctor for CreateSnapshotFromTemplate
by yzaslavs＠redhat.com 05 Nov '14

05 Nov '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Missing Guid ctor for CreateSnapshotFromTemplate ...................................................................... core: Missing Guid ctor for CreateSnapshotFromTemplate Change-Id: I0c43ab5f83db55587894f32116ab229fd28cff36 Bug-Url: https://bugzilla.redhat.com/1160537 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotFromTemplateCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/34808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c43ab5f83db55587894f32116ab229fd28cff36 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: Revert "restapi: Fix NPE in request for CDROMs of wrong VM"
by tnisan＠redhat.com 04 Nov '14

04 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: Revert "restapi: Fix NPE in request for CDROMs of wrong VM" ...................................................................... Revert "restapi: Fix NPE in request for CDROMs of wrong VM" This reverts part of commit 8d5aa3646e2402a48f88a0532a70d9bb50347e57, as it breaks listing of empty collections of VM devices. Change-Id: I14333ee4b8f43da4da287a70304107b225990c44 Bug-Url: https://bugzilla.redhat.com/1159642 Related-To: https://bugzilla.redhat.com/1150953 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 25215cefbd56b4d9b03d9622f886f762d2570fae) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendReadOnlyDevicesResource.java 1 file changed, 1 insertion(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14333ee4b8f43da4da287a70304107b225990c44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core, engine, webadmin: Consider only online logical CPUs
by tnisan＠redhat.com 04 Nov '14

04 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core, engine, webadmin: Consider only online logical CPUs ...................................................................... core, engine, webadmin: Consider only online logical CPUs This patch reports the ids of the logical CPUs which are online in the Hosts tab of the webadmin interface, and uses this information to validate the CPU pinning during the VM creation. A new column in the vds_dynamic table was added to store this list. Change-Id: Ib20f20d6003502fe2f2864abb5ad8f4f5a19ecdc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1148092 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_1140_add_online_cpu_list.sql M packaging/dbscripts/vds_sp.sql 15 files changed, 112 insertions(+), 17 deletions(-) Approvals: Vitor de Lima: Verified Eli Mesika: Looks good to me, but someone else must approve Gilad Chaplik: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib20f20d6003502fe2f2864abb5ad8f4f5a19ecdc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: GetAllDisksByVmIdQuery - improved performance
by laravot＠redhat.com 04 Nov '14

04 Nov '14

Liron Aravot has submitted this change and it was merged. Change subject: core: GetAllDisksByVmIdQuery - improved performance ...................................................................... core: GetAllDisksByVmIdQuery - improved performance Currently when executing GetAllDisksByVmIdQuery, all the vm disks are queried using the GetDisksVmGuid stored procedure and then the vm device for each disk is being loaded to complete to queried data. This can cause to mass of loads that could be prevented, GetDisksVmGuid already performs join with vm_device table so that records could be just returned. Change-Id: I91d12ee535563204b5d6aaeb64ec6a7c23ea1a81 Bug-Url: https://bugzilla.redhat.com/1130065 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQuery.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M packaging/dbscripts/all_disks_sp.sql M packaging/dbscripts/create_views.sql 5 files changed, 40 insertions(+), 47 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91d12ee535563204b5d6aaeb64ec6a7c23ea1a81 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Anonymous Coward #1000524 Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: make constants class ctor private
by laravot＠redhat.com 04 Nov '14

04 Nov '14

Liron Aravot has submitted this change and it was merged. Change subject: core: make constants class ctor private ...................................................................... core: make constants class ctor private Change-Id: Ifef9264b2bfb39150cbcdde2efe376bfde3861b5 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfInfoFileConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifef9264b2bfb39150cbcdde2efe376bfde3861b5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "restapi: Fix NPE in request for CDROMs of wrong VM"
by juan.hernandez＠redhat.com 04 Nov '14

04 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: Revert "restapi: Fix NPE in request for CDROMs of wrong VM" ...................................................................... Revert "restapi: Fix NPE in request for CDROMs of wrong VM" This reverts part of commit 8d5aa3646e2402a48f88a0532a70d9bb50347e57, as it breaks listing of empty collections of VM devices. Change-Id: I14333ee4b8f43da4da287a70304107b225990c44 Bug-Url: https://bugzilla.redhat.com/1159642 Related-To: https://bugzilla.redhat.com/1150953 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendReadOnlyDevicesResource.java 1 file changed, 1 insertion(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14333ee4b8f43da4da287a70304107b225990c44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: skip failing proxy when waiting for status
by oourfali＠redhat.com 04 Nov '14

04 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: skip failing proxy when waiting for status ...................................................................... core: skip failing proxy when waiting for status This patch fix a bug when we have a preferred proxy (in 6the same cluster as the fenced host) that failed to perform the desired operation. In this case, we should remember the failed proxy inside the "get status" loop and use the one that had succeeded (if exists) Change-Id: I2b846444ff795e7099b61f6d0be8909402b7bfa1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1141514 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java 1 file changed, 17 insertions(+), 16 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b846444ff795e7099b61f6d0be8909402b7bfa1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: set boot order index 0 for unmanaged nic
by tnisan＠redhat.com 04 Nov '14

04 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: set boot order index 0 for unmanaged nic ...................................................................... core: set boot order index 0 for unmanaged nic This patch fix NPE which was thrown when computing boot order for a VM that has unmanaged network interface. The boot order index for unmanaged network interfaces will now be 0. Change-Id: If299f5c10dbfd15cf5ebe01f6d7911a7f92eb56f Bug-Url: https://bugzilla.redhat.com/1155667 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtilsTest.java 2 files changed, 23 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/34749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If299f5c10dbfd15cf5ebe01f6d7911a7f92eb56f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0