- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Set Migrate On Error in Data Center Guide Me
by tnisan＠redhat.com 14 Oct '14

14 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Set Migrate On Error in Data Center Guide Me ...................................................................... webadmin: Set Migrate On Error in Data Center Guide Me The Add Cluster dialog in the Data Center "Guide Me" was not setting the chosen Migrate On Error action in the VDSGroup instance that is sent to the AddVdsGroup command. Change-Id: I7498ae26f1ff2fcd90e547aae48fb66e25bb4a43 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1142658 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Vitor de Lima: Verified -- To view, visit http://gerrit.ovirt.org/34013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7498ae26f1ff2fcd90e547aae48fb66e25bb4a43 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Suppress compiler warnings for unchecked cast
by tnisan＠redhat.com 14 Oct '14

14 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: aaa: Suppress compiler warnings for unchecked cast ...................................................................... aaa: Suppress compiler warnings for unchecked cast Suppress two compiler warnings for unchecked casts There is no more targeted approach for suppressing it properly in NegotiationFilter, hence the "unchecked" warnings are suppressed for the complete doFilter method. Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I730d91cdb7392f91e475642230a5c499f235f73c Signed-off-by: Tim Speetjens <tim.speetjens(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EnforceAuthFilter.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I730d91cdb7392f91e475642230a5c499f235f73c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tim Speetjens <tim.speetjens(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Host SSH Fingerprint success message shouldn't be ...
by oourfali＠redhat.com 14 Oct '14

14 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Host SSH Fingerprint success message shouldn't be in red text ...................................................................... webadmin: Host SSH Fingerprint success message shouldn't be in red text When host SSH fingerprint is fetched successfully the sucess message is displayed in red. Change-Id: I28c5a3c82202733a9a628b80a50634c7ccb19d85 Bug-Url: https://bugzilla.redhat.com/1148567 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 2 files changed, 15 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28c5a3c82202733a9a628b80a50634c7ccb19d85 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: builtin-extensions: remove EngineEncryptionUtils usage
by tnisan＠redhat.com 14 Oct '14

14 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: builtin-extensions: remove EngineEncryptionUtils usage ...................................................................... builtin-extensions: remove EngineEncryptionUtils usage Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: Ic4a2d8927729223c710dfe43c07b85ccbc9b5d56 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerCommandBase.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapWithConfiguredCredentialsCommandBase.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java 3 files changed, 14 insertions(+), 21 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4a2d8927729223c710dfe43c07b85ccbc9b5d56 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix pm policy checkbox label width
by oourfali＠redhat.com 14 Oct '14

14 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Fix pm policy checkbox label width ...................................................................... webadmin: Fix pm policy checkbox label width Fixes PM policy checkbox label witdth in Power Management tab in Host Detail popup. This problem appears only in Firefox 31 on RHEL 6. Change-Id: I9731f94ca73f4f1eb06b2c6ddb409953255565dc Bug-Url: https://bugzilla.redhat.com/1148868 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Peřina: Verified -- To view, visit http://gerrit.ovirt.org/33991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9731f94ca73f4f1eb06b2c6ddb409953255565dc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix vertical positioning of checkbox and label
by oourfali＠redhat.com 14 Oct '14

14 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Fix vertical positioning of checkbox and label ...................................................................... webadmin: Fix vertical positioning of checkbox and label Fixes vertical positioning of checkbox and its label if checkbox is placed on the right of its label. Change-Id: I38f8cf40fccfb0ec34672915f7aad15b2b08da75 Related-To: https://bugzilla.redhat.com/1148868 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseEntityModelCheckboxEditor.java M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified Greg Sheremeta: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38f8cf40fccfb0ec34672915f7aad15b2b08da75 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: host-deploy: remove usage commons-logging
by yzaslavs＠redhat.com 14 Oct '14

14 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: host-deploy: remove usage commons-logging ...................................................................... host-deploy: remove usage commons-logging most are to be converted to try-with-resources and drop logging. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109871 Change-Id: I0391bd92ecfbbc6289a10ac6d8fa6afde94ac1de Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHClient.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHDialog.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/CachedTar.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/Tar.java 4 files changed, 23 insertions(+), 99 deletions(-) Approvals: Alon Bar-Lev: Verified Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0391bd92ecfbbc6289a10ac6d8fa6afde94ac1de Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: uutils: remove usage of commons-logging
by yzaslavs＠redhat.com 14 Oct '14

14 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: uutils: remove usage of commons-logging ...................................................................... uutils: remove usage of commons-logging Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109871 Change-Id: Ie79052db8ec6e1f8bf99a5f9bc9bfa065d7ee2c8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java M backend/manager/modules/uutils/src/main/modules/org/ovirt/engine/core/uutils/main/module.xml M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java 5 files changed, 38 insertions(+), 47 deletions(-) Approvals: Alon Bar-Lev: Verified Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34081 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie79052db8ec6e1f8bf99a5f9bc9bfa065d7ee2c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: handling websocket_proxy rpm from websocke...
by tnisan＠redhat.com 14 Oct '14

14 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: handling websocket_proxy rpm from websocketproxy plugin ...................................................................... packaging: setup: handling websocket_proxy rpm from websocketproxy plugin Handling websocketproxy rpm from websocketproxy setup plugin. The websocketproxy setup plugin is now able to install the websocketproxy rpm if the user decide to configure it but the rpm is not present. Bug-Url: https://bugzilla.redhat.com/1140599 Change-Id: I1179ec04c3b24113de30b148fc3e04fc50e29c00 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 75af7ab89aa8cb01a6c88fa46e308e60ecd7269a) --- M packaging/setup/ovirt_engine_setup/websocket_proxy/constants.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/__init__.py A packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/packages.py 3 files changed, 103 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/33201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1179ec04c3b24113de30b148fc3e04fc50e29c00 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Correction of UI Constant
by tnisan＠redhat.com 14 Oct '14

14 Oct '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Correction of UI Constant ...................................................................... webadmin: Correction of UI Constant Detach Storage dialog text related issues solved: "Data Center(s)" was changed to "Data Center", "Detach storage" was changed to "Detach Storage" Change-Id: I8a0848956c472fae929e36841de65d893e728d96 Bug-Url: https://bugzilla.redhat.com/1149457 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Amit Aviram: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34116 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a0848956c472fae929e36841de65d893e728d96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0