- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: dont copy old num of sockets on hotplug
by ofrenkel＠redhat.com 14 Oct '14

14 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: dont copy old num of sockets on hotplug ...................................................................... core: dont copy old num of sockets on hotplug when editing running vm, all fields that are not editable, are copied from the old vm to new vm, as they are saved in the running snapshot, and db reflect the actual running config. when user select to do hot-set to cpu, the number of sockets should not be copied with the old value, as it is used in the hot-set command. this is fixed by sending to the copy method, if this is a hot-set flow, and it will check it when doing copy of the old value, for hot-set allowed fields. Change-Id: I57bcd2287350c3146f06fe2a5c9a583c88dded04 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1151827 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java 3 files changed, 19 insertions(+), 8 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57bcd2287350c3146f06fe2a5c9a583c88dded04 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Handle audit log of expired account
by yzaslavs＠redhat.com 14 Oct '14

14 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Handle audit log of expired account ...................................................................... aaa: Handle audit log of expired account Bug-Url: https:/bugzilla.redhat.com/1078196 Topic: AAA Change-Id: Ifba0841260071c5a7e9b3ee5df8d04b81ec21076 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 13 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifba0841260071c5a7e9b3ee5df8d04b81ec21076 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: remove duplicate groups from entities
by yzaslavs＠redhat.com 14 Oct '14

14 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: remove duplicate groups from entities ...................................................................... aaa: remove duplicate groups from entities Change-Id: If5c1313c96e0e3e0900023efed2469dfea306632 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java 3 files changed, 22 insertions(+), 19 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5c1313c96e0e3e0900023efed2469dfea306632 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: protocol fall back for older vdsms
by oourfali＠redhat.com 13 Oct '14

13 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: protocol fall back for older vdsms ...................................................................... core: protocol fall back for older vdsms When we try to install new host which only supports xmlrpc and we have cluster with compatibility level set to 3.5+ the code will fail. Solution for this issue is attempting to connect by using jsonrpc and if it fails falling back to xmlrpc. Change-Id: Ie6f48bec60b520c089f326f8c5e79aec288ff3d6 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FutureVDSCommandType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/TimeBoundPollVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/FutureMap.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TimeBoundPollVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 9 files changed, 211 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6f48bec60b520c089f326f8c5e79aec288ff3d6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi, userportal, webadmin: secure cookie
by awels＠redhat.com 13 Oct '14

13 Oct '14

Alexander Wels has submitted this change and it was merged. Change subject: restapi,userportal,webadmin: secure cookie ...................................................................... restapi,userportal,webadmin: secure cookie - Added secure cookie for session in webadmin, userportal, and rest api. Change-Id: I4de909c25ec7b28d12dc7e325c366962c85d32a7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1142728 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml M ovirt-engine.spec.in 4 files changed, 5 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4de909c25ec7b28d12dc7e325c366962c85d32a7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: osinfo: Disable unsupported rtl8139 in SLES 11 for ppc64
by ofrenkel＠redhat.com 13 Oct '14

13 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: osinfo: Disable unsupported rtl8139 in SLES 11 for ppc64 ...................................................................... osinfo: Disable unsupported rtl8139 in SLES 11 for ppc64 The SLES 11 operating system does not support the rtl8139 network interface, this patch disables it in the osinfo. Change-Id: Ia63250ec01a638e31fcb4b003d5913c0a43f8f36 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1151015 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia63250ec01a638e31fcb4b003d5913c0a43f8f36 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: osinfo: Disable unsupported VirtIO SCSI in SLES 11 for ppc64
by ofrenkel＠redhat.com 13 Oct '14

13 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: osinfo: Disable unsupported VirtIO SCSI in SLES 11 for ppc64 ...................................................................... osinfo: Disable unsupported VirtIO SCSI in SLES 11 for ppc64 The SLES 11 operating system does not support the VirtIO SCSI controller, this patch disables it in the osinfo. Change-Id: I664468106bfb76715db25289fa551436b1086a5c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1151010 Signed-off-by: Vitor de Lima <vdelima(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Vitor de Lima: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I664468106bfb76715db25289fa551436b1086a5c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fixed UI for popup New CPU QoS
by gchaplik＠redhat.com 13 Oct '14

13 Oct '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fixed UI for popup New CPU QoS ...................................................................... webadmin: Fixed UI for popup New CPU QoS In the popup "New CPU Qos", the scroll bar was removed and also, margin was added for the "Limit" textbox so it will be aligned with the rest of the textboxes. Color for the "Limit" row wasn't changed(It was decided to leave it as is). Change-Id: I4aebf602a70b7b65f65d45e388b5d49296ed0be7 Bug-Url: https://bugzilla.redhat.com/1142813 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/CpuQosPopupView.ui.xml 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Jiří Moskovčák: Looks good to me, but someone else must approve Tomer Saban: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4aebf602a70b7b65f65d45e388b5d49296ed0be7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: optimization in processOnVmStop
by ofrenkel＠redhat.com 13 Oct '14

13 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: optimization in processOnVmStop ...................................................................... core: optimization in processOnVmStop Do not insert Runnable object to the thread pool when no logic is made by that object. Change-Id: I37bd1f2eb570b9c73599430211d5e9fd4e8ea83e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/34052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37bd1f2eb570b9c73599430211d5e9fd4e8ea83e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Admin user is not properly synchronized
by yzaslavs＠redhat.com 13 Oct '14

13 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Admin user is not properly synchronized ...................................................................... aaa: Admin user is not properly synchronized Change-Id: I48f68ac6160e4e8c09526ac23a5180feac43361e Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthz.java 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48f68ac6160e4e8c09526ac23a5180feac43361e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0