- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: cleanup - extract method
by ahadas＠redhat.com 14 Oct '14

14 Oct '14

Arik Hadas has submitted this change and it was merged. Change subject: userportal: cleanup - extract method ...................................................................... userportal: cleanup - extract method Extract the code that adds new VM to separate method: UserPortalListModel#saveNewVm. Change-Id: Ia28f695d93d0e26858b140e172fe5b4267b5bbf7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 1 file changed, 44 insertions(+), 44 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/33147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia28f695d93d0e26858b140e172fe5b4267b5bbf7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: remove unneeded query for template's disks
by ahadas＠redhat.com 14 Oct '14

14 Oct '14

Arik Hadas has submitted this change and it was merged. Change subject: frontend: remove unneeded query for template's disks ...................................................................... frontend: remove unneeded query for template's disks Change-Id: Ib4e29db112befaf2fdbeef18e3971c71f159840c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 2 files changed, 21 insertions(+), 45 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/33145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4e29db112befaf2fdbeef18e3971c71f159840c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: Add support for Kerberos authentication
by juan.hernandez＠redhat.com 14 Oct '14

14 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Add support for Kerberos authentication ...................................................................... cli: Add support for Kerberos authentication This patch adds a --kerberos option that enables Kerberos authentication. Change-Id: I973db40adec102da95bb605cb7db6e7854ee4343 Bug-Url: https://bugzilla.redhat.com/1145239 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/cli/context.py M src/ovirtcli/command/connect.py M src/ovirtcli/infrastructure/context.py M src/ovirtcli/infrastructure/options.py M src/ovirtcli/infrastructure/settings.py M src/ovirtcli/shell/connectcmdshell.py 6 files changed, 40 insertions(+), 24 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I973db40adec102da95bb605cb7db6e7854ee4343 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: show host-id for a vm in an unknown state
by juan.hernandez＠redhat.com 14 Oct '14

14 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: show host-id for a vm in an unknown state ...................................................................... restapi: show host-id for a vm in an unknown state When a VM was running in an unknown state, REST would not return the current host-id for that VM. Changed mapper to return host-id (and other dynamic info) as long as the VM is not down for sure. Change-Id: I8010522e42d1a7cfc963b2408b22c3bc468e30eb Bug-Url: https://bugzilla.redhat.com/1144938 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eldan Shachar: Verified Juan Hernandez: Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8010522e42d1a7cfc963b2408b22c3bc468e30eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fixed capitalization on "New Cluster".
by gchaplik＠redhat.com 14 Oct '14

14 Oct '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fixed capitalization on "New Cluster". ...................................................................... webadmin: Fixed capitalization on "New Cluster". Fixed Capitalization on the "New Cluster" dialog. The text: "Migrate only Highly Available Virtual Machines" was changed to: "Migrate Only Highly Available Virtual Machines" in order to match the capitalization with the two other options. Change-Id: I9ea28360b7554d45b26df9194fc420ab8249f31b Bug-Url: https://bugzilla.redhat.com/1147987 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jiří Moskovčák: Looks good to me, but someone else must approve Gilad Chaplik: Looks good to me, approved Tomer Saban: Verified Roy Golan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33923 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ea28360b7554d45b26df9194fc420ab8249f31b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fixed out of frame load balancer boxes.
by gchaplik＠redhat.com 14 Oct '14

14 Oct '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fixed out of frame load balancer boxes. ...................................................................... webadmin: Fixed out of frame load balancer boxes. In the "New Scheduling Policy" dialog, extended the height of the frame. Also, Added new css style "separatorStyle" with margins for the seperators to adjust the style to the height change. Change-Id: Ic4342dc06d11d0d7c884e9f6b0ecbc25b3934db5 Bug-Url: https://bugzilla.redhat.com/1142897 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.ui.xml 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Tomer Saban: Verified Gilad Chaplik: Looks good to me, approved Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4342dc06d11d0d7c884e9f6b0ecbc25b3934db5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core, engine: Do not count sPAPR VLAN devices as PCI
by ofrenkel＠redhat.com 14 Oct '14

14 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: core, engine: Do not count sPAPR VLAN devices as PCI ...................................................................... core, engine: Do not count sPAPR VLAN devices as PCI The checkPciAndIdeLimits function accounted sPAPR VLAN devices as PCI, but these devices have their own bus (the spapr-vio bus). This change skips these devices in the total count of PCI devices done in the VM related commands. Change-Id: Iab14ae25f59cd77e29ef444bb1887911a2dcdb05 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1076518 Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Vitor de Lima: Verified Jiří Moskovčák: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25758 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab14ae25f59cd77e29ef444bb1887911a2dcdb05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vdelima(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: builtin-extensions: remove usage of org.ovirt.engine.core.ut...
by yzaslavs＠redhat.com 14 Oct '14

14 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: builtin-extensions: remove usage of org.ovirt.engine.core.utils.log.Log ...................................................................... builtin-extensions: remove usage of org.ovirt.engine.core.utils.log.Log Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109871 Change-Id: I43124cb57f54c60f6e8717678a87f151bccdf856 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/ADGroupContextMapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/ADUserContextMapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DefaultRootDSEContextMapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DirectorySearcher.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/GSSAPIDirContextAuthenticationStrategy.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/GetRootDSE.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/GetRootDSETask.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/IPAGroupContextMapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/IPAUserContextMapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/ITDSGroupContextMapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/ITDSRootDSEContextMapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/ITDSUserContextMapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosLdapAuthz.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/KerberosManager.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LDAPTemplateWrapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LDAPTemplateWrapperFactory.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapAuthenticateUserCommand.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerBase.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerCommandBase.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerUtils.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchExceptionHandler.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/OpenLdapGroupContextMapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/OpenLdapUserContextMapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/PrepareLdapConnectionTask.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/RHDSGroupContextMapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/RHDSRootDSEContextMapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/RHDSUserContextMapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/ipa/OpenLdapUserContextMapper.java 28 files changed, 155 insertions(+), 150 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43124cb57f54c60f6e8717678a87f151bccdf856 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: builtin-extensions: remove EngineEncryptionUtils usage
by yzaslavs＠redhat.com 14 Oct '14

14 Oct '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: builtin-extensions: remove EngineEncryptionUtils usage ...................................................................... builtin-extensions: remove EngineEncryptionUtils usage Change-Id: Ic4a2d8927729223c710dfe43c07b85ccbc9b5d56 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerCommandBase.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapWithConfiguredCredentialsCommandBase.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java 3 files changed, 14 insertions(+), 21 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4a2d8927729223c710dfe43c07b85ccbc9b5d56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: print number of cpu value in SetNumberOfCpusVDSCommand
by ofrenkel＠redhat.com 14 Oct '14

14 Oct '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: print number of cpu value in SetNumberOfCpusVDSCommand ...................................................................... core: print number of cpu value in SetNumberOfCpusVDSCommand Change-Id: I4afe6d777e779ee1718d271809758fdcd99e9ec9 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetNumberOfCpusVDSCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Roy Golan: Looks good to me, approved Omer Frenkel: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/34080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4afe6d777e779ee1718d271809758fdcd99e9ec9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0