- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: allow to maintenance host if install failed
by oourfali＠redhat.com 01 Oct '14

01 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: allow to maintenance host if install failed ...................................................................... core: allow to maintenance host if install failed Allow to put host in maintenance if install failed This patch allows to put a host in maintenance in case that host installation failed. In networking problems it may occur that after trying to put the host in maintenance it will go to preparing for maintenance=>Non Responding and we will have to put it in maintenance again. Change-Id: Ic3611e4fb7ac039ee4014f6cb158b0da5067331e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1147988 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3611e4fb7ac039ee4014f6cb158b0da5067331e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: adding QoS network name to vmNetworkInterface entity
by masayag＠redhat.com 01 Oct '14

01 Oct '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: adding QoS network name to vmNetworkInterface entity ...................................................................... engine: adding QoS network name to vmNetworkInterface entity Change-Id: Id8480381c42626bba80284345bee8b437b77b7fc Bug-Url: https://bugzilla.redhat.com/1103493 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkInterface.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoDbFacadeImpl.java M packaging/dbscripts/create_views.sql 3 files changed, 20 insertions(+), 4 deletions(-) Approvals: Eliraz Levi: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8480381c42626bba80284345bee8b437b77b7fc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : Fix NPE in CommandBase buildCommandEntity
by oourfali＠redhat.com 01 Oct '14

01 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core : Fix NPE in CommandBase buildCommandEntity ...................................................................... core : Fix NPE in CommandBase buildCommandEntity When execution context is null CommandBase buildCommandEntity throws a NPE. Change-Id: I6f6a2b7e0727a22a9649d0b305000f59eb4236a1 Bug-Url: https://bugzilla.redhat.com/1147971 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Allon Mureinik: Looks good to me, approved Yair Zaslavsky: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f6a2b7e0727a22a9649d0b305000f59eb4236a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : Display custom error page if reports is not installed
by oourfali＠redhat.com 01 Oct '14

01 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core : Display custom error page if reports is not installed ...................................................................... core : Display custom error page if reports is not installed When reports is not installed the link from /ovirt-engine/ page takes you to 404 page when user clicks on reports link. A custom error page is displayed that shows the message that reports is not installed Change-Id: Idaed902328695e2d448ac49c414ddfbde8d3fd25 Bug-Url: https://bugzilla.redhat.com/1143998 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java M backend/manager/modules/welcome/src/main/resources/messages.properties M backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml M packaging/services/ovirt-engine/ovirt-engine.conf.in 5 files changed, 40 insertions(+), 9 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaed902328695e2d448ac49c414ddfbde8d3fd25 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: sdk: Add support for Kerberos authentication
by juan.hernandez＠redhat.com 01 Oct '14

01 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Add support for Kerberos authentication ...................................................................... sdk: Add support for Kerberos authentication This patch adds support for Kerberos authentication. To use it the API object has to be created using the "kerberos" parameter: api = ovirtsdk.api.API( url="https://ovirt.example.com/ovirt-engine/api", kerberos=True, ... ) For this to succeed the user must have acquired the Kerberos credentials (the TGT) before calling the Python SDK. Change-Id: Ic36e8548e5743aca71757eba46e4970976f08911 Bug-Url: https://bugzilla.redhat.com/1145234 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/EntryPointTemplate M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/connectionspool.py 3 files changed, 31 insertions(+), 16 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/33221 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic36e8548e5743aca71757eba46e4970976f08911 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: boot-protocol for VmInitNetwork
by shavivi＠redhat.com 01 Oct '14

01 Oct '14

Shahar Havivi has submitted this change and it was merged. Change subject: engine: boot-protocol for VmInitNetwork ...................................................................... engine: boot-protocol for VmInitNetwork Needs to return STATIC instead of STATIC_IP Validate BootProtocol input. Bug-Url: https://bugzilla.redhat.com/1144005 Change-Id: I21f8a9cf509dd4d3d6e73a83ce9f66b183605161 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInitNetwork.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/GuestNicConfigurationValidator.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/VmValidator.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 4 files changed, 33 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified Juan Hernandez: Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21f8a9cf509dd4d3d6e73a83ce9f66b183605161 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: sdk: Replace httplib with pycurl
by juan.hernandez＠redhat.com 01 Oct '14

01 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Replace httplib with pycurl ...................................................................... sdk: Replace httplib with pycurl Currently we use the Python httplib module to handle the HTTP connection with the server. Unfortunatelly this module doesn't support any interesting authentication mechanism. In the future we want to add support for Kerberos, for example. As a first step this patch replaces httplib with the pycurl. Change-Id: I7fa93cef1b8ca0deb5bdbc02c35ab604e11b4570 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/EntryPointHeadTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/EntryPointMethodsTemplate M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/EntryPointTemplate M ovirt-engine-sdk-python.spec.in M setup.py M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/connectionspool.py M src/ovirtsdk/infrastructure/errors.py M src/ovirtsdk/infrastructure/proxy.py D src/ovirtsdk/web/__init__.py D src/ovirtsdk/web/connection.py D src/ovirtsdk/web/cookiejaradapter.py D src/ovirtsdk/web/httpsconnection.py 13 files changed, 280 insertions(+), 779 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fa93cef1b8ca0deb5bdbc02c35ab604e11b4570 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: AddVmPoolWithVmsCommand storage allocation
by ahadas＠redhat.com 01 Oct '14

01 Oct '14

Arik Hadas has submitted this change and it was merged. Change subject: core: AddVmPoolWithVmsCommand storage allocation ...................................................................... core: AddVmPoolWithVmsCommand storage allocation This patch is a part of a series of patches, adding storage allocation validations to the system when they're missing, and replacing old verification usage with unified, new, correct and tested verification. This patch did this for AddVmPoolWithVmsCommand, using only existing validations. Previously the storage allocation check was wrongfully in CommonVmPoolWithVmsCommand, and is now extracted to AddVmPoolWithVmsCommand only. Change-Id: I3120acf7eb5c71be6ade437522174a7bf62ea52a Bug-Url: https://bugzilla.redhat.com/1143888 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommandTest.java 3 files changed, 73 insertions(+), 28 deletions(-) Approvals: Allon Mureinik: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/33525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3120acf7eb5c71be6ade437522174a7bf62ea52a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup - grammar and unused code
by ahadas＠redhat.com 01 Oct '14

01 Oct '14

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup - grammar and unused code ...................................................................... core: cleanup - grammar and unused code Revised class comment and removed unused method. Change-Id: I33196e7dcda8cdc69f53d9837329a5171239cb16 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java 1 file changed, 7 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/33514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33196e7dcda8cdc69f53d9837329a5171239cb16 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add checkbox for format when remove Storage domain
by mlipchuk＠redhat.com 01 Oct '14

01 Oct '14

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Add checkbox for format when remove Storage domain ...................................................................... webadmin: Add checkbox for format when remove Storage domain Add format checkbox when remove a data Storage Doman. The checkbox should be checked for Data Storage Domain since most of the use cases should be formatting it. Change-Id: Ia844883ebca19be9c4f6a26f7c34b3423bf0f2d3 Bug-Url: https://bugzilla.redhat.com/1138132 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/RemoveStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 2 insertions(+), 6 deletions(-) Approvals: Federico Simoncelli: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia844883ebca19be9c4f6a26f7c34b3423bf0f2d3 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0