- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: persist disk image parameters for live migration
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: persist disk image parameters for live migration ...................................................................... core: persist disk image parameters for live migration DiskImage's Disk Profile and Quota wasn't updated. Change-Id: I0d6acdd7e8567294d489d1916ede164683941ef7 Bug-Url: https://bugzilla.redhat.com/1145694 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> (cherry picked from commit 2df230f0245e693455e7fc00bfe82157b0180a1e) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java 1 file changed, 24 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/33530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d6acdd7e8567294d489d1916ede164683941ef7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core:fixing step numbering for steps and sub-steps
by masayag＠redhat.com 30 Sep '14

30 Sep '14

Moti Asayag has submitted this change and it was merged. Change subject: core:fixing step numbering for steps and sub-steps ...................................................................... core:fixing step numbering for steps and sub-steps When a step is added to a job, it should get its step_number value according to the existing steps already added to the job. The same is for adding sub-step to an exiting step. This patch fix a problem in adding step/sub-step when all added steps/sub-steps get a 0 for the step_number value. This resulted in incorrect order of steps and sub-steps in the UI while steps where ordered by the step_number but this had no affect since the step_number was always 0. Change-Id: Ic72e9ab64160116f4fbac3f3b2cdea63db7b9c75 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1143035 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddStepCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java 3 files changed, 20 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic72e9ab64160116f4fbac3f3b2cdea63db7b9c75 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: persist disk image parameters for live migration
by gchaplik＠redhat.com 30 Sep '14

30 Sep '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: persist disk image parameters for live migration ...................................................................... core: persist disk image parameters for live migration DiskImage's Disk Profile and Quota wasn't updated. Change-Id: I0d6acdd7e8567294d489d1916ede164683941ef7 Bug-Url: https://bugzilla.redhat.com/1145694 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java 1 file changed, 24 insertions(+), 5 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33483 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d6acdd7e8567294d489d1916ede164683941ef7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Do not attempt to extend a block domain if LUNs dat...
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Do not attempt to extend a block domain if LUNs data not supplied ...................................................................... restapi: Do not attempt to extend a block domain if LUNs data not supplied When editing a block domain via REST, in case the storage data was not supplied there is still a comparison between the old an new LUNs which results in an NPE, in that case we just skip the comparison if the data was not sent in the request Change-Id: Ibf4b28c2dbc289b88107f1e7fdc19127fb536326 Bug-Url: https://bugzilla.redhat.com/1115966 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf4b28c2dbc289b88107f1e7fdc19127fb536326 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Show correct tooltip in disks tab when a disk is u...
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Show correct tooltip in disks tab when a disk is unattached ...................................................................... webadmin: Show correct tooltip in disks tab when a disk is unattached Bug-Url: https://bugzilla.redhat.com/1140093 Change-Id: Ibc9858297ff9f4cace04707a8894c95429bf2422 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc9858297ff9f4cace04707a8894c95429bf2422 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: VmGuideModel - fix new disk dialog title
by derez＠redhat.com 30 Sep '14

30 Sep '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: VmGuideModel - fix new disk dialog title ...................................................................... webadmin: VmGuideModel - fix new disk dialog title GuideMe -> New disk dialog: fixed dialog title. Change-Id: Ia2ccf6d4110d0772a8bf119486eeaa103bff3bb3 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/33523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2ccf6d4110d0772a8bf119486eeaa103bff3bb3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Do not attempt to extend a block domain if LUNs dat...
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Do not attempt to extend a block domain if LUNs data not supplied ...................................................................... restapi: Do not attempt to extend a block domain if LUNs data not supplied When editing a block domain via REST, in case the storage data was not supplied there is still a comparison between the old an new LUNs which results in an NPE, in that case we just skip the comparison if the data was not sent in the request Change-Id: Ibf4b28c2dbc289b88107f1e7fdc19127fb536326 Bug-Url: https://bugzilla.redhat.com/1115966 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf4b28c2dbc289b88107f1e7fdc19127fb536326 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: Report on insufficient parameters on add provider form
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: ui: Report on insufficient parameters on add provider form ...................................................................... ui: Report on insufficient parameters on add provider form Adding report on insufficient parameters on test if authentication parameters are missing Change-Id: Iafcb126db61fe1ac1b4b668a78c3b09b95fefe90 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1125961 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafcb126db61fe1ac1b4b668a78c3b09b95fefe90 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: userportal, webadmin: keep proper USB support selection
by oourfali＠redhat.com 30 Sep '14

30 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: userportal,webadmin: keep proper USB support selection ...................................................................... userportal,webadmin: keep proper USB support selection There were 2 problems: 1: the UnitVmModel.initUsbPolicy() did set the USB policy always to "disabled". Fixed by making sure that if the previously selected still applys than select it 2: The UnitVmModel.updateDisplayProtocol() have delegated the selection of the old display protocol to behavior.postDisplayTypeItemChanged which is too late, because meanwhile the VNC has been selected by getDisplayProtocol().setItems() which fired an appropriate event which in turn changed the USB support to "disabled" Fixed by removing the logic from VmModelBehaviorBase and moved it into the updateDisplayProtocol() to make sure the event is fired only when needed. Change-Id: I7e1b1048784e9d0c289fab13b4d8b9b80afd6cc9 Bug-Url: https://bugzilla.redhat.com/966415 Bug-Url: https://bugzilla.redhat.com/1080144 Bug-Url: https://bugzilla.redhat.com/1147827 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 27 insertions(+), 53 deletions(-) Approvals: Tomas Jelinek: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e1b1048784e9d0c289fab13b4d8b9b80afd6cc9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: frontend: Fix SPICE-ActiveX upgrade issues
by oourfali＠redhat.com 30 Sep '14

30 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: frontend: Fix SPICE-ActiveX upgrade issues ...................................................................... frontend: Fix SPICE-ActiveX upgrade issues This patch basically reverts previous IE 11 workaround: Syntax error (missing '+' to concatenate strings) in SpicePluginImpl caused silent fail of activex plugin in IE. This patch addresses this. This patch also removes IE11 workaround from SpicePluginImpl (i.e. dummy <PARAM NAME="SecurePort" VALUE="0">). Current SPICE ActiveX plugin already works on IE 11 without this workaround (moreover - it crashes with it!). Change-Id: I884eafed9985991f5f810378792fb45e00837a5e Bug-Url: https://bugzilla.redhat.com/1147609 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/33516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I884eafed9985991f5f810378792fb45e00837a5e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0