- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add lock on attach Storage Domain process
by mlipchuk＠redhat.com 01 Oct '14

01 Oct '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add lock on attach Storage Domain process ...................................................................... core: Add lock on attach Storage Domain process Add a lock in the Storage Domain when attaching a Storage Domain to Data Center. Change-Id: Icc484b92d5e49cbe8c01f371f057639220e21428 Bug-Url: https://bugzilla.redhat.com/1144845 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33460 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc484b92d5e49cbe8c01f371f057639220e21428 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Support format option for data domain
by mlipchuk＠redhat.com 01 Oct '14

01 Oct '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support format option for data domain ...................................................................... core: Support format option for data domain Adding the option to remove Data Storage Domain from the engine without formatting it so we can use it to move entities from one setup to another. Change-Id: I4392de431f6523e3824bbddd9d79aa4b1eb0819c Bug-Url: https://bugzilla.redhat.com/1138132 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 2 insertions(+), 29 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4392de431f6523e3824bbddd9d79aa4b1eb0819c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Order VMs/Templates in alphabetical order on expor...
by mlipchuk＠redhat.com 01 Oct '14

01 Oct '14

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Order VMs/Templates in alphabetical order on export domain ...................................................................... webadmin: Order VMs/Templates in alphabetical order on export domain Order the entities in the Export Storage Domain in an alphabetical order Change-Id: I81ba2555cc59823a22886c7fcc6a6fffdc3c8de0 Bug-Url: https://bugzilla.redhat.com/1088294 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81ba2555cc59823a22886c7fcc6a6fffdc3c8de0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add a lock when detaching Storage from Data Center
by mlipchuk＠redhat.com 01 Oct '14

01 Oct '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add a lock when detaching Storage from Data Center ...................................................................... core: Add a lock when detaching Storage from Data Center Add a lock in the Storage Domain when detaching a Storage Domain from Data Center. Bug-Url: https://bugzilla.redhat.com/1144845 Change-Id: I42c6be592ad6d71579ce0aa20926856cbca23d44 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java 3 files changed, 22 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42c6be592ad6d71579ce0aa20926856cbca23d44 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: refresh wraps.
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: userportal,webadmin: refresh wraps. ...................................................................... userportal,webadmin: refresh wraps. - GWT can't determine the width of margins, and thus the calculations will be wrong when you use them in an action panel. Switched margins to padding which GWT does detect properly. Change-Id: I9f641172099df224f7a4fda322449d02e842068c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1123277 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Alexander Wels: Verified -- To view, visit http://gerrit.ovirt.org/33551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f641172099df224f7a4fda322449d02e842068c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: fix import flow for cpu profile
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: fix import flow for cpu profile ...................................................................... engine: fix import flow for cpu profile Handles import more than once as well. Change-Id: Ice68c57b56208413df6a021650e3b996de14cef5 Bug-Url: https://bugzilla.redhat.com/1145935 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java 5 files changed, 23 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/33547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice68c57b56208413df6a021650e3b996de14cef5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: refactor—overgrown constructor
by lvernia＠redhat.com 30 Sep '14

30 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: refactor—overgrown constructor ...................................................................... webadmin: refactor—overgrown constructor - overgrown constructor split to smaller, single purpose methods (I need to add next gui code there, and it's too long already) - make all parameters final, if they can be final, not just some. Change-Id: I05d1ec1064eb3ec4ce17f88a2d532cb76aa4f39d Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/SharedMacPoolView.java 1 file changed, 37 insertions(+), 10 deletions(-) Approvals: Martin Mucha: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05d1ec1064eb3ec4ce17f88a2d532cb76aa4f39d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: fix import flow for cpu profile
by gchaplik＠redhat.com 30 Sep '14

30 Sep '14

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: fix import flow for cpu profile ...................................................................... engine: fix import flow for cpu profile Handles import more than once as well. Change-Id: Ice68c57b56208413df6a021650e3b996de14cef5 Bug-Url: https://bugzilla.redhat.com/1145935 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java 5 files changed, 23 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice68c57b56208413df6a021650e3b996de14cef5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: Do not emit email events when the state was not changed
by msivak＠redhat.com 30 Sep '14

30 Sep '14

Martin Sivák has submitted this change and it was merged. Change subject: Do not emit email events when the state was not changed ...................................................................... Do not emit email events when the state was not changed This also fixes the trigger regexp to be more in alignment with the current state machine. Change-Id: I2da55f4497fd139a0a1ba4f3079a4e97972adb08 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1146433 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit da8f16f844ec527f85f04a0f2a460b79e1c7d9ab) --- M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/broker/broker.conf 2 files changed, 6 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2da55f4497fd139a0a1ba4f3079a4e97972adb08 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: build: post ovirt-hosted-engine-ha-1.2.1
by msivak＠redhat.com 30 Sep '14

30 Sep '14

Martin Sivák has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-ha-1.2.1 ...................................................................... build: post ovirt-hosted-engine-ha-1.2.1 Change-Id: Ibca7ca95d84c122995ea1cbbcb5212434c644172 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibca7ca95d84c122995ea1cbbcb5212434c644172 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0