- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: userportal, webadmin: remove FF17, add FF31 to supported bro...
by oourfali＠redhat.com 24 Sep '14

24 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: userportal, webadmin: remove FF17, add FF31 to supported browsers ...................................................................... userportal, webadmin: remove FF17, add FF31 to supported browsers Change-Id: I2fbc2df95dc31f072234ce2362a810bcabc4dec6 Bug-Url: https://bugzilla.redhat.com/1145779 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/InternalConfiguration.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Einav Cohen: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/33288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fbc2df95dc31f072234ce2362a810bcabc4dec6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add vnic profile and network caching to validator
by masayag＠redhat.com 23 Sep '14

23 Sep '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add vnic profile and network caching to validator ...................................................................... engine: Add vnic profile and network caching to validator Add vnic profile and network caching to VmNicValidator class by lazy-loading them. Change-Id: Ibeaa7af2ac76433ed832ff65514201ece6049478 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicValidatorTest.java 4 files changed, 48 insertions(+), 18 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/32600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibeaa7af2ac76433ed832ff65514201ece6049478 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[ovirt-live-3.4]: build: oVirt Live 3.4.4
by sbonazzo＠redhat.com 23 Sep '14

23 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: oVirt Live 3.4.4 ...................................................................... build: oVirt Live 3.4.4 Change-Id: Ib6892db5d1f7926ff13f1e514111a56c7694667f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6892db5d1f7926ff13f1e514111a56c7694667f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: remove FF17, add FF31 to supported bro...
by tnisan＠redhat.com 23 Sep '14

23 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: userportal, webadmin: remove FF17, add FF31 to supported browsers ...................................................................... userportal, webadmin: remove FF17, add FF31 to supported browsers Change-Id: I2fbc2df95dc31f072234ce2362a810bcabc4dec6 Bug-Url: https://bugzilla.redhat.com/1043430 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/InternalConfiguration.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Einav Cohen: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/33291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fbc2df95dc31f072234ce2362a810bcabc4dec6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: remove FF17, add FF31 to supported bro...
by ecohen＠redhat.com 23 Sep '14

23 Sep '14

Einav Cohen has submitted this change and it was merged. Change subject: userportal, webadmin: remove FF17, add FF31 to supported browsers ...................................................................... userportal, webadmin: remove FF17, add FF31 to supported browsers Change-Id: I2fbc2df95dc31f072234ce2362a810bcabc4dec6 Bug-Url: https://bugzilla.redhat.com/1043430 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/InternalConfiguration.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Einav Cohen: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/33280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fbc2df95dc31f072234ce2362a810bcabc4dec6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in samples-uiplugins[master]: gluster-nagios-monitoring: fixing extra login popup from tre...
by vszocs＠redhat.com 23 Sep '14

23 Sep '14

Vojtech Szocs has submitted this change and it was merged. Change subject: gluster-nagios-monitoring: fixing extra login popup from trends tab. ...................................................................... gluster-nagios-monitoring: fixing extra login popup from trends tab. gluster-nagios-monitoring UI plugin is using legacy http://host:/api URL for Rest API calls and thats the reason for extra additional popup in the trends tab. Changing the URL to to use /ovirt-engine/api also sending the "Prefer:persistent-auth" header with all Rest API calls to keep the wedamin's Rest API session active. Change-Id: I4dba4af5cef01a5d30ed24831bd2333ba9ae05bd Bug-Url: https://bugzilla.redhat.com/1143041 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M gluster-nagios-monitoring/src/js/services.js 1 file changed, 12 insertions(+), 7 deletions(-) Approvals: Kanagaraj M: Looks good to me, but someone else must approve Vojtech Szocs: Verified; Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/33060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dba4af5cef01a5d30ed24831bd2333ba9ae05bd Gerrit-PatchSet: 3 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixed missing type variable in disk profiles
by gchaplik＠redhat.com 23 Sep '14

23 Sep '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fixed missing type variable in disk profiles ...................................................................... core: Fixed missing type variable in disk profiles Fixed the missing type variable in disk profiles. Also, fixed the bug for CPU profiles, since it share the same common base class as disk profile. Change-Id: I1f7500b557ada1ed78aa6d736018a5319142cd58 Bug-Url: https://bugzilla.redhat.com/1142887 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddDiskProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddProfileCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveCpuProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveDiskProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveProfileCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateCpuProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateDiskProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateProfileCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 14 files changed, 41 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f7500b557ada1ed78aa6d736018a5319142cd58 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: adding RetrieveImageDataCommand
by laravot＠redhat.com 23 Sep '14

23 Sep '14

Liron Aravot has submitted this change and it was merged. Change subject: core: adding RetrieveImageDataCommand ...................................................................... core: adding RetrieveImageDataCommand This patch adds RetrieveImageDataCommand and changes AttachStorageDomainToPoolCommand to use it instead of executing the vds command directly. This is done so that the needed CDA checks/locks will be taken. Furthermore, this patch takes care of polling the created upload task on vdsm side. Change-Id: I4ed10f1d3fc74e1deb6c69fc826f02abfd5d679e Bug-Url: https://bugzilla.redhat.com/1136840 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RetrieveImageDataCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/bll/RetrieveImageDataParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 4 files changed, 75 insertions(+), 7 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ed10f1d3fc74e1deb6c69fc826f02abfd5d679e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: AsyncTaskType - uploadImageFromStream to uploadImageTo...
by laravot＠redhat.com 23 Sep '14

23 Sep '14

Liron Aravot has submitted this change and it was merged. Change subject: core: AsyncTaskType - uploadImageFromStream to uploadImageToStream ...................................................................... core: AsyncTaskType - uploadImageFromStream to uploadImageToStream changed uploadImageFromStream to uploadImageToStream as appears on vdsm. Change-Id: I42de0ddf13fba46c68674e20b570cd0ea759eff8 Bug-Url: https://bugzilla.redhat.com/1136840 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RetrieveImageDataVDSCommand.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42de0ddf13fba46c68674e20b570cd0ea759eff8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: introducing ImageSpmCommand
by laravot＠redhat.com 23 Sep '14

23 Sep '14

Liron Aravot has submitted this change and it was merged. Change subject: core: introducing ImageSpmCommand ...................................................................... core: introducing ImageSpmCommand This patch extracts ImageSpmCommand as a parent class of UploadStreamCommand to contain shared logic between this command and the to-be-added RetrieveImageDataCommand. Change-Id: I32166ee993bce33680f6b2feb5359666e414c777 Bug-Url: https://bugzilla.redhat.com/1136840 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImageSpmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UploadStreamCommand.java 2 files changed, 135 insertions(+), 103 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32166ee993bce33680f6b2feb5359666e414c777 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0