- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: positive affinity breaks maintenancing a host
by tnisan＠redhat.com 23 Sep '14

23 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: positive affinity breaks maintenancing a host ...................................................................... core: positive affinity breaks maintenancing a host I feel that this is best to describe with an example: vm1, vm2 running with enforcing positive affinity group on host A. When putting host A to maintenance, both VMs will try to migrate, and fail because they're violating the affinity constraints. the host is stuck on preparing for maint. The fix ignores the host when it's in preparing for maint status. Change-Id: I7282a9e1c87b30c14869170ed7fb5b9276fad33e Bug-Url: https://bugzilla.redhat.com/1084794 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> (cherry picked from commit cb27efb5b9561420da8ecb7c44a3b4013c126acb) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7282a9e1c87b30c14869170ed7fb5b9276fad33e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: allow 2% gap in host low swap
by tnisan＠redhat.com 23 Sep '14

23 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: allow 2% gap in host low swap ...................................................................... core: allow 2% gap in host low swap This patch change the computation of low swap memory such that it allows a 2% gap between the configured low swap value (LogPhysicalMemoryThresholdInMB) and the actual one in order to prevent th engine log to be flooded with warning when the actual value is OK. Change-Id: Ia3f5da5398141eeba83549a7e425e9f6b9f8673e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1135909 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3f5da5398141eeba83549a7e425e9f6b9f8673e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Don't write empty description/comment to OVF
by tnisan＠redhat.com 23 Sep '14

23 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Don't write empty description/comment to OVF ...................................................................... core: Don't write empty description/comment to OVF Currently when we generate OVF files we write the description and comment properties of the VM even if they are null. As a result when a VM without a description or comment is re-imported it has an empty string a value (instead of null) for these properties. This patch changes the OVF writer so that it won't write the description or comment properties if they are null. Change-Id: Iffd0f7010bc32402c45882dc6087bf02a55a14d9 Bug-Url: https://bugzilla.redhat.com/1145466 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit cbd16554817f0373df18018bd65795412972544f) --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffd0f7010bc32402c45882dc6087bf02a55a14d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: don't allow to create VM with balloon on ppc64
by tnisan＠redhat.com 23 Sep '14

23 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: don't allow to create VM with balloon on ppc64 ...................................................................... engine: don't allow to create VM with balloon on ppc64 Change-Id: Iee077b08a825e65de2cddce85bc88573e89da4ab Bug-Url: https://bugzilla.redhat.com/1127677 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 102 insertions(+), 13 deletions(-) Approvals: Jiří Moskovčák: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee077b08a825e65de2cddce85bc88573e89da4ab Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: reports: do not display input control in ce dashboards
by ydary＠redhat.com 23 Sep '14

23 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: do not display input control in ce dashboards ...................................................................... reports: do not display input control in ce dashboards Change-Id: I2b633bddfb4f4ca61aa70309ecaa4cb4437501f8 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> (cherry picked from commit 6b356af96bc2cfec79da29b2b8e26fc29b9ecced) --- M packaging/ovirt-reports/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard.xml M packaging/ovirt-reports/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard.xml M packaging/ovirt-reports/resources/reports_resources/webadmin_dashboards/ce/system_dashboard.xml 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b633bddfb4f4ca61aa70309ecaa4cb4437501f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: setup: fix link to dashboard
by ydary＠redhat.com 23 Sep '14

23 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: fix link to dashboard ...................................................................... packaging: setup: fix link to dashboard Change-Id: I498c2918005e0ba0f6a7d2e188c7d55104a84f8d Bug-Url: https://bugzilla.redhat.com/1144079 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit cb481081a78f843d1c174b19ab667ee3de07502c) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I498c2918005e0ba0f6a7d2e188c7d55104a84f8d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: do not display input control in ce dashboards
by ydary＠redhat.com 23 Sep '14

23 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: do not display input control in ce dashboards ...................................................................... reports: do not display input control in ce dashboards Change-Id: I2b633bddfb4f4ca61aa70309ecaa4cb4437501f8 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-reports/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard.xml M packaging/ovirt-reports/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard.xml M packaging/ovirt-reports/resources/reports_resources/webadmin_dashboards/ce/system_dashboard.xml 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b633bddfb4f4ca61aa70309ecaa4cb4437501f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: fix older pep8 compatibility
by oourfali＠redhat.com 23 Sep '14

23 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: setup: fix older pep8 compatibility ...................................................................... packaging: setup: fix older pep8 compatibility regardless, this is better... Change-Id: Ibd6b2cf7c1c9f5427a6cce6ceb8df2873bc43888 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> (cherry picked from commit 19a2ed147aff0cde12f2ad144617e7c7240ab0da) --- M packaging/setup/ovirt_engine_setup/remote_engine.py 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Yedidyah Bar David: Verified; Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd6b2cf7c1c9f5427a6cce6ceb8df2873bc43888 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: fix older pep8 compatibility
by emesika＠redhat.com 23 Sep '14

23 Sep '14

Eli Mesika has submitted this change and it was merged. Change subject: packaging: setup: fix older pep8 compatibility ...................................................................... packaging: setup: fix older pep8 compatibility regardless, this is better... Change-Id: Ibd6b2cf7c1c9f5427a6cce6ceb8df2873bc43888 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/remote_engine.py 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd6b2cf7c1c9f5427a6cce6ceb8df2873bc43888 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: fix link to dashboard
by ydary＠redhat.com 23 Sep '14

23 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: fix link to dashboard ...................................................................... packaging: setup: fix link to dashboard Change-Id: I498c2918005e0ba0f6a7d2e188c7d55104a84f8d Bug-Url: https://bugzilla.redhat.com/1144079 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Yaniv Dary: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/33266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I498c2918005e0ba0f6a7d2e188c7d55104a84f8d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0