- Engine-commits - oVirt List Archives

Change in ovirt-iso-uploader[master]: packaging: setup: Making error messages more verbose
by sbonazzo＠redhat.com 24 Sep '14

24 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Making error messages more verbose ...................................................................... packaging: setup: Making error messages more verbose Making error messages a bit more verbose to help the user pointing out possible problems. Change-Id: I0a722d37420f4a3c9b0af09dc483cc9d73b4faff Bug-Url: https://bugzilla.redhat.com/1144836 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 29 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/33263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a722d37420f4a3c9b0af09dc483cc9d73b4faff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: mock: adding fedora 21 config file
by dcaroest＠redhat.com 24 Sep '14

24 Sep '14

David Caro has submitted this change and it was merged. Change subject: mock: adding fedora 21 config file ...................................................................... mock: adding fedora 21 config file Change-Id: I259f1cef33022cece8f4ee6711ca7514d5541da9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A mock_configs/fedora-21-x86_64.cfg 1 file changed, 63 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified David Caro: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I259f1cef33022cece8f4ee6711ca7514d5541da9 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix AddVmParameters for null diskInfoList
by ofrenkel＠redhat.com 24 Sep '14

24 Sep '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix AddVmParameters for null diskInfoList ...................................................................... core: fix AddVmParameters for null diskInfoList In change I06f2de3db1b0559af4df04d0d158b10b8460c684: b7804ad core: cleanup AddVmParameters constructors the logic in charge to ensure that diskInfoList is never null was removed. When a new VM is added from rest-api addVmFromScratch(...) sets diskInfoList to a null value: AddVmParameters params = new AddVmParameters(staticVm); params.setDiskInfoList(mapDisks(vm.getDisks())); resulting in a NPE: ERROR [AddVmFromScratchCommand] Error during CanDoActionFailure: java.lang.NullPointerException at checkImagesConfiguration(ImagesHandler.java:455) [bll.jar:] at canDoAction(AddVmFromScratchCommand.java:150) [bll.jar:] at internalCanDoAction(CommandBase.java:746) [bll.jar:] Change-Id: I979bd6373e4a1440f88d27e416bd2e116b010891 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmParameters.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Federico Simoncelli: Verified Omer Frenkel: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I979bd6373e4a1440f88d27e416bd2e116b010891 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: pep8 fixes
by ydary＠redhat.com 24 Sep '14

24 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: pep8 fixes ...................................................................... packaging: setup: pep8 fixes Change-Id: I46d8bd70a852b0551caf7908e775b9cc161d8556 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py 3 files changed, 6 insertions(+), 13 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46d8bd70a852b0551caf7908e775b9cc161d8556 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.5]: build: oVirt Live 3.5.0 RC3
by sbonazzo＠redhat.com 24 Sep '14

24 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: oVirt Live 3.5.0 RC3 ...................................................................... build: oVirt Live 3.5.0 RC3 Change-Id: Ifb5ea441112057a7c68c871f4aefee2ffa03e9db Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb5ea441112057a7c68c871f4aefee2ffa03e9db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: packaging: setup: Update engine db only if not cleared
by ydary＠redhat.com 24 Sep '14

24 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Update engine db only if not cleared ...................................................................... packaging: setup: Update engine db only if not cleared Also do not fail engine-cleanup if updating the engine db fails. Change-Id: I400a5fc84e9e82902b223dd13a85e9f80424c893 Bug-Url: https://bugzilla.redhat.com/1140986 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 108ca077f0c023a68d13e6ded8e60346abce3446) --- M packaging/setup/ovirt_engine_setup/dwh/constants.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-dwh/db/single_etl.py 2 files changed, 46 insertions(+), 21 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I400a5fc84e9e82902b223dd13a85e9f80424c893 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: packaging: setup: Update engine db only if not cleared
by ydary＠redhat.com 24 Sep '14

24 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Update engine db only if not cleared ...................................................................... packaging: setup: Update engine db only if not cleared Also do not fail engine-cleanup if updating the engine db fails. Change-Id: I400a5fc84e9e82902b223dd13a85e9f80424c893 Bug-Url: https://bugzilla.redhat.com/1140986 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/dwh/constants.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-dwh/db/single_etl.py 2 files changed, 46 insertions(+), 21 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/33310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I400a5fc84e9e82902b223dd13a85e9f80424c893 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: adding RetrieveImageDataCommand
by piotr.kliczewski＠gmail.com 24 Sep '14

24 Sep '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: adding RetrieveImageDataCommand ...................................................................... core: adding RetrieveImageDataCommand This patch adds RetrieveImageDataCommand and changes AttachStorageDomainToPoolCommand to use it instead of executing the vds command directly. This is done so that the needed CDA checks/locks will be taken. Furthermore, this patch takes care of polling the created upload task on vdsm side. Change-Id: I4ed10f1d3fc74e1deb6c69fc826f02abfd5d679e Bug-Url: https://bugzilla.redhat.com/1136840 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RetrieveImageDataCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/bll/RetrieveImageDataParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 4 files changed, 75 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/33278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ed10f1d3fc74e1deb6c69fc826f02abfd5d679e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: AsyncTaskType - uploadImageFromStream to uploadImageTo...
by piotr.kliczewski＠gmail.com 24 Sep '14

24 Sep '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: AsyncTaskType - uploadImageFromStream to uploadImageToStream ...................................................................... core: AsyncTaskType - uploadImageFromStream to uploadImageToStream changed uploadImageFromStream to uploadImageToStream as appears on vdsm. Change-Id: I42de0ddf13fba46c68674e20b570cd0ea759eff8 Bug-Url: https://bugzilla.redhat.com/1136840 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/RetrieveImageDataVDSCommand.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/33277 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42de0ddf13fba46c68674e20b570cd0ea759eff8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: introducing ImageSpmCommand
by piotr.kliczewski＠gmail.com 24 Sep '14

24 Sep '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: introducing ImageSpmCommand ...................................................................... core: introducing ImageSpmCommand This patch extracts ImageSpmCommand as a parent class of UploadStreamCommand to contain shared logic between this command and the to-be-added RetrieveImageDataCommand. Change-Id: I32166ee993bce33680f6b2feb5359666e414c777 Bug-Url: https://bugzilla.redhat.com/1136840 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImageSpmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UploadStreamCommand.java 2 files changed, 135 insertions(+), 103 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/33276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32166ee993bce33680f6b2feb5359666e414c777 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0