- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove storage format validation when adding unattache...
by tnisan＠redhat.com 22 Sep '14

22 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove storage format validation when adding unattached data domain ...................................................................... core: Remove storage format validation when adding unattached data domain Remove storage format validation when adding an unattached data domain with a host that doesn't have a data center Change-Id: I4feea2d476e89e89d2b1ad572ce64904063a0914 Bug-Url: https://bugzilla.redhat.com/1141784 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4feea2d476e89e89d2b1ad572ce64904063a0914 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: allow 2% gap in host low swap
by oourfali＠redhat.com 22 Sep '14

22 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: allow 2% gap in host low swap ...................................................................... core: allow 2% gap in host low swap This patch change the computation of low swap memory such that it allows a 2% gap between the configured low swap value (LogPhysicalMemoryThresholdInMB) and the actual one in order to prevent th engine log to be flooded with warning when the actual value is OK. Change-Id: Ia3f5da5398141eeba83549a7e425e9f6b9f8673e Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3f5da5398141eeba83549a7e425e9f6b9f8673e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Adding possibility to specify multilevel options
by dcaroest＠redhat.com 22 Sep '14

22 Sep '14

David Caro has submitted this change and it was merged. Change subject: Adding possibility to specify multilevel options ...................................................................... Adding possibility to specify multilevel options For example environment vars with: --option environment.MYVAR=MYVALUE Change-Id: I660286c5fe592f8cda75b7880a16e0e4fc6f2003 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M mock_configs/mock_genconfig 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I660286c5fe592f8cda75b7880a16e0e4fc6f2003 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add numa node index when create vm numa node
by rgolan＠redhat.com 22 Sep '14

22 Sep '14

Roy Golan has submitted this change and it was merged. Change subject: core: Add numa node index when create vm numa node ...................................................................... core: Add numa node index when create vm numa node Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28 Bug-Url: https://bugzilla.redhat.com/1099814 Signed-off-by: Bruce Shi <xiao-lei.shi(a)hp.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactoryTest.java 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a6f3f4c4f69dff73ef8df5dc8b6d9f4ed12ec28 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: need vds id when build vm numa properties
by rgolan＠redhat.com 22 Sep '14

22 Sep '14

Roy Golan has submitted this change and it was merged. Change subject: core: need vds id when build vm numa properties ...................................................................... core: need vds id when build vm numa properties Change-Id: I19be54812d0ebbb54145f33e6b036af84ff1d8ae Bug-Url: https://bugzilla.redhat.com/1099417 Signed-off-by: Bruce Shi <xiao-lei.shi(a)hp.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/NumaSettingFactoryTest.java 6 files changed, 266 insertions(+), 94 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, but someone else must approve Roy Golan: Verified; Looks good to me, approved Xiaolei Shi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19be54812d0ebbb54145f33e6b036af84ff1d8ae Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: jsonrpc only for 3.5 cluster compatibility level
by tnisan＠redhat.com 22 Sep '14

22 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: jsonrpc only for 3.5 cluster compatibility level ...................................................................... core: jsonrpc only for 3.5 cluster compatibility level When cluster level is set to lower level than 3.5 we must not let people change default xmlrpc to jsonrpc. Lower versions of vdsm are not able to understand jsonrpc so we disabled possibility on the UI. Bug-Url: https://bugzilla.redhat.com/1142945 Change-Id: Ifaf0afa2abbd6ccc40a4fd84bebcb94544271639 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 3 files changed, 3 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33137 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifaf0afa2abbd6ccc40a4fd84bebcb94544271639 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: Host settings not populated with prtocol info on Guide M...
by tnisan＠redhat.com 22 Sep '14

22 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: ui: Host settings not populated with prtocol info on Guide Me panels ...................................................................... ui: Host settings not populated with prtocol info on Guide Me panels DataCenter and Cluster Guide me panels did not set protocol type so it was always set to xmlrpc unless user changed the value. Bug-Url: https://bugzilla.redhat.com/1142706 Change-Id: I2308aa387b584388ecb5f44cfb0973380688eff1 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 2 files changed, 43 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2308aa387b584388ecb5f44cfb0973380688eff1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: cleanup - remove unused field
by ahadas＠redhat.com 22 Sep '14

22 Sep '14

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: cleanup - remove unused field ...................................................................... webadmin: cleanup - remove unused field Change-Id: I919eaf6349c40f9c75fc88096a3e12841d6829d7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/33144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I919eaf6349c40f9c75fc88096a3e12841d6829d7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup - order ctr and important public methods first
by rgolan＠redhat.com 22 Sep '14

22 Sep '14

Roy Golan has submitted this change and it was merged. Change subject: core: cleanup - order ctr and important public methods first ...................................................................... core: cleanup - order ctr and important public methods first Change-Id: Ie2fd6ef474f1e5fe6734d65f5de5c8d3592c0d12 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1099068 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 82 insertions(+), 82 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2fd6ef474f1e5fe6734d65f5de5c8d3592c0d12 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: VdsManger - rename fields to fit convention
by rgolan＠redhat.com 22 Sep '14

22 Sep '14

Roy Golan has submitted this change and it was merged. Change subject: core: VdsManger - rename fields to fit convention ...................................................................... core: VdsManger - rename fields to fit convention Change-Id: I90e26c1a2db4d51f5bd13cf39a59593579fa7648 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 2 files changed, 93 insertions(+), 85 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90e26c1a2db4d51f5bd13cf39a59593579fa7648 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0