- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Use error for audit log on import template from config...
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Use error for audit log on import template from configuration. ...................................................................... core: Use error for audit log on import template from configuration. Use error audit log instead of refular audit log when the import VM from configuration fails Change-Id: I134f3a2015b7f249a361bd237b824709f7210f40 Bug-Url: https://bugzilla.redhat.com/1140584 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I134f3a2015b7f249a361bd237b824709f7210f40 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Validate Storage Domain for Importing Template from co...
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Validate Storage Domain for Importing Template from configuration ...................................................................... core: Validate Storage Domain for Importing Template from configuration For each disk in the template, we should fetch the Storage Domain and validate that it exists and active. Today, we set the storage id for each image and then use getStorageDomain method to fetch the Storage Domain with that id, but when the Storage Domain being initialized, it will always check the first Storage Domain every time. Change-Id: I2bfe3ba9b48747650291a887255e85358ed0799a Bug-Url: https://bugzilla.redhat.com/1138200 Bug-Url: https://bugzilla.redhat.com/1140560 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bfe3ba9b48747650291a887255e85358ed0799a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Use the latest OVF_STORE files
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Use the latest OVF_STORE files ...................................................................... core: Use the latest OVF_STORE files Rotate over the OVF_STORE disks and retrieve the entities from the best match of the OVF_STORE disk until succeeded. Also register those disks as OVF_STORE disks, so it will be updated every time there will be any change in the entities' OVF. Change-Id: I8252281f295df49a28c3c131d9a98fef9af8f35e Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 47 insertions(+), 32 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8252281f295df49a28c3c131d9a98fef9af8f35e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Validate disk registration only if a domain exists.
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Validate disk registration only if a domain exists. ...................................................................... core: Validate disk registration only if a domain exists. Registeration of a disk is only a DB operation and does not encounter any VDS commands, therefore, there should not be any validation for Storage Domain activation. Change-Id: I71c138ede22808b5a887e9b9982c154e5591d5c9 Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71c138ede22808b5a887e9b9982c154e5591d5c9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add unregistered entities to the ovf tar file
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add unregistered entities to the ovf tar file ...................................................................... core: Add unregistered entities to the ovf tar file Sync the unregistered entities with the existing entities in the setup to be stored in the OVF_STORE disk. Change-Id: Icc5fc1c1b704ecbb49fe3d4c2561ec1836093369 Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java 1 file changed, 26 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc5fc1c1b704ecbb49fe3d4c2561ec1836093369 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Override unregistered entity on deatch.
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Override unregistered entity on deatch. ...................................................................... core: Override unregistered entity on deatch. Override unregistered entity when there is an existing entity which already exists as an unregistered entity. This can happen when a domain with an unregistered entity, is attached and a VM with disks on multiple storage domains exists in the setup and also as an unregistered VM. Once the VM will be created with disk on the attached Storage Domain, the unregistered entity should be overriden with the existing one, on detach process. Bug-Url: https://bugzilla.redhat.com/1132568 Change-Id: Id22390ae392e95bbc73a5976fc886ed21da4989b Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id22390ae392e95bbc73a5976fc886ed21da4989b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Verify that date is initialized in OVF_STORE disk
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Verify that date is initialized in OVF_STORE disk ...................................................................... core: Verify that date is initialized in OVF_STORE disk Verify that the last_update date is initizlied in the OVF_STORE disk to prevent NPE. If the last_update date is not initialized in the disk we don't count this disk to be retrieved, unregistered entities, from, since it is not initilized with entities. Change-Id: I8e59086ce7242d7aaec10b57b6775ab968c9fe1c Bug-Url: https://bugzilla.redhat.com/1130976 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e59086ce7242d7aaec10b57b6775ab968c9fe1c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Get all unregisterd entities for Storage Domain
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Get all unregisterd entities for Storage Domain ...................................................................... core: Get all unregisterd entities for Storage Domain When entity type is NULL, fetch all the unregistered entities Change-Id: I1fa749c309381a9f034dc8e6ea499740c33f8990 Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java M packaging/dbscripts/unregistered_OVF_data_sp.sql 3 files changed, 19 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fa749c309381a9f034dc8e6ea499740c33f8990 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: Make pki interaction easier
by ydary＠redhat.com 21 Sep '14

21 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Make pki interaction easier ...................................................................... packaging: setup: Make pki interaction easier Make pki interaction use files and ask again if needed. Requires: http://gerrit.ovirt.org/32742 Bug-Url: https://bugzilla.redhat.com/1118328 Bug-Url: https://bugzilla.redhat.com/1118330 Change-Id: Ia5b3713330d6e11bd7c374e04f17660be79f2251 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/reports/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/sso.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py 4 files changed, 297 insertions(+), 145 deletions(-) Approvals: Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5b3713330d6e11bd7c374e04f17660be79f2251 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: dal: Unregistered entities fixups in DAO and fixtures
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: dal: Unregistered entities fixups in DAO and fixtures ...................................................................... dal: Unregistered entities fixups in DAO and fixtures 1. Add unregistered Template entity to fixtures file 2. Use FixturesTool with the new entities 3. Fix UnregisteredOVFDataDAOTest accordingly 4. Fix typos found in the UnregisteredOVFDataDAOTest Change-Id: I3b8663eec50968c0553c8fc6e841b3244ffd418b Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 3 files changed, 31 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b8663eec50968c0553c8fc6e841b3244ffd418b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0