- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: VdsManager - no need to cache config values
by rgolan＠redhat.com 22 Sep '14

22 Sep '14

Roy Golan has submitted this change and it was merged. Change subject: core: VdsManager - no need to cache config values ...................................................................... core: VdsManager - no need to cache config values Change-Id: Icfb5a1641038742dd848ee67cb0fe53ce16b7909 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 22 insertions(+), 11 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfb5a1641038742dd848ee67cb0fe53ce16b7909 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: VdsManager - cleanup
by rgolan＠redhat.com 22 Sep '14

22 Sep '14

Roy Golan has submitted this change and it was merged. Change subject: core: VdsManager - cleanup ...................................................................... core: VdsManager - cleanup * separate fields from methods * encapsulate important parts into methods * extract interface from important methods interaction Change-Id: Ib4062bc376d22253b045ad022c67f3f10da0b100 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 2 files changed, 82 insertions(+), 82 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4062bc376d22253b045ad022c67f3f10da0b100 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: introduce TemplateProvisioningMethod
by ofrenkel＠redhat.com 22 Sep '14

22 Sep '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: introduce TemplateProvisioningMethod ...................................................................... core: introduce TemplateProvisioningMethod Add enumeration for the different template provisioning types and use it in the parameters class of add-vm operation (will be used later to distinguish between regular add-vm, which uses thin template provisioning, and clone from template, which uses clone provisioning) Change-Id: I08c16527ff019269ead9474780f32a90da7e7577 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TemplateProvisioningMethod.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 3 files changed, 17 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/33065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08c16527ff019269ead9474780f32a90da7e7577 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: move vm numa fields to VmBase
by rgolan＠redhat.com 22 Sep '14

22 Sep '14

Roy Golan has submitted this change and it was merged. Change subject: core: move vm numa fields to VmBase ...................................................................... core: move vm numa fields to VmBase Move vm numa related fields to VmBase entity since the fields will also be called in VmTemplate. Change-Id: Icc69f8167b8468becef728617ec850dc9034d88f Bug-Url: https://bugzilla.redhat.com/1069303 Signed-off-by: Bruce Shi <xiao-lei.shi(a)hp.com> Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaTuneMode.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDaoDbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/vm_templates_sp.sql 9 files changed, 62 insertions(+), 54 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc69f8167b8468becef728617ec850dc9034d88f Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei.shi(a)hp.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi(a)hp.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: Adding fields validation in addHost form
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: ui: Adding fields validation in addHost form ...................................................................... ui: Adding fields validation in addHost form 1. For root password during provisioning host 2. For empty compute resources and host group lists, when discovered host is added. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127606 Change-Id: Icfc3e500ad06728fc8c410baa13405633fc90da2 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfc3e500ad06728fc8c410baa13405633fc90da2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add validation for empty compute resource or host group
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add validation for empty compute resource or host group ...................................................................... core: Add validation for empty compute resource or host group Change-Id: Id26697e3e7a1b98c7e5e557cff3fd7078aecb67a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127606 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 4 files changed, 17 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id26697e3e7a1b98c7e5e557cff3fd7078aecb67a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add validation for empty compute resource or host group
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add validation for empty compute resource or host group ...................................................................... core: Add validation for empty compute resource or host group Change-Id: Id26697e3e7a1b98c7e5e557cff3fd7078aecb67a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127606 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 4 files changed, 17 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id26697e3e7a1b98c7e5e557cff3fd7078aecb67a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: setup: Make pki interaction easier
by ydary＠redhat.com 21 Sep '14

21 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Make pki interaction easier ...................................................................... packaging: setup: Make pki interaction easier Make pki interaction use files and ask again if needed. Requires: http://gerrit.ovirt.org/32742 Bug-Url: https://bugzilla.redhat.com/1118328 Bug-Url: https://bugzilla.redhat.com/1118330 Change-Id: Ia5b3713330d6e11bd7c374e04f17660be79f2251 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit c390da6ed5a42c1c49eadc2c039c8f8aa316ff9e) --- M packaging/setup/ovirt_engine_setup/reports/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/sso.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py 4 files changed, 297 insertions(+), 145 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5b3713330d6e11bd7c374e04f17660be79f2251 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: NPE in Picking first provider
by oourfali＠redhat.com 21 Sep '14

21 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: NPE in Picking first provider ...................................................................... webadmin: NPE in Picking first provider Fix assumption that first provider exists Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1144807 Change-Id: I71d1249d86a6b700708391eb19ba98302dd0be4a Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71d1249d86a6b700708391eb19ba98302dd0be4a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: wrong param name for fencing policy
by tnisan＠redhat.com 21 Sep '14

21 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: wrong param name for fencing policy ...................................................................... core: wrong param name for fencing policy In the api schema and API.py the fencing policy param is named policy whereas engine passes fencingPolicy so value is not properly mapped. This patch fixes the naming. Change-Id: I291eb7973afa023e2f3d49bd09b966ce6ae9e333 Bug-Url: https://bugzilla.redhat.com/1143860 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I291eb7973afa023e2f3d49bd09b966ce6ae9e333 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0