- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: NPE in Picking first provider
by oourfali＠redhat.com 18 Sep '14

18 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: NPE in Picking first provider ...................................................................... webadmin: NPE in Picking first provider Fix assumption that first provider exists Change-Id: I71d1249d86a6b700708391eb19ba98302dd0be4a Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Bronhaim: Verified Daniel Erez: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71d1249d86a6b700708391eb19ba98302dd0be4a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: keeping PostgreSQL port open if the DBMS i...
by sbonazzo＠redhat.com 18 Sep '14

18 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: keeping PostgreSQL port open if the DBMS is local ...................................................................... packaging: setup: keeping PostgreSQL port open if the DBMS is local on system with iptables engine-setup is going to completely rewrite iptables rules. Kepping DB port open if the DBMS is local also if we are not upgrading. Change-Id: I92350ec322162e8c199174cf6fa7a1d517af8998 Bug-Url: https://bugzilla.redhat.com/1141286 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92350ec322162e8c199174cf6fa7a1d517af8998 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: add getHostname
by sbonazzo＠redhat.com 18 Sep '14

18 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: add getHostname ...................................................................... packaging: setup: add getHostname Move the code asking for the FQDN to a common place, to allow asking for other host names. Copy the FQDN to ENGINE_FQDN to be used by other plugins needing the engine fqdn. Change-Id: I8747002a14de6d96d5a7e185258d8ee0955b8a24 Related-To: https://bugzilla.redhat.com/1118330 Related-To: https://bugzilla.redhat.com/1080992 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/ovirt_engine_setup/engine_common/constants.py A packaging/setup/ovirt_engine_setup/hostname.py M packaging/setup/plugins/ovirt-engine-setup/base/network/hostname.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/dialog/titles.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/protocols.py 6 files changed, 390 insertions(+), 281 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/32742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8747002a14de6d96d5a7e185258d8ee0955b8a24 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Removed unwanted exception logging
by kmayilsa＠redhat.com 18 Sep '14

18 Sep '14

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Removed unwanted exception logging ...................................................................... engine: Removed unwanted exception logging Gluster task monitoring checks periodically for gluster tasks list from the cluster, and if there are no operational hosts in the cluster, an exception is logged. Removing the noise from this logging as it confuses the user. Change-Id: I9b24fe99a1cb66155a9ff24f149a20db32e76307 Bug-Url: https://bugzilla.redhat.com/1138128 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTasksService.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shubhendu Tripathi: Looks good to me, but someone else must approve Kanagaraj M: Looks good to me, but someone else must approve Sahina Bose: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b24fe99a1cb66155a9ff24f149a20db32e76307 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Live Merge recovery flow
by tnisan＠redhat.com 17 Sep '14

17 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Live Merge recovery flow ...................................................................... core: Live Merge recovery flow When a VM stops running during a live merge, check the status using a new reconcileVolumeChain vdsm verb. This verb will ensure the volume chain is correct and return the comprising images, which we can then use to converge the Live Merge flow while the VM is still down. Change-Id: Ie858c69412698e9a11a7f52ee88c3c078b3f2303 Bug-Url: https://bugzilla.redhat.com/1129898 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommandCallback.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ReconcileVolumeChainVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ReconcileVolumeChainVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/VolumeListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java 11 files changed, 192 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Greg Padgett: Verified -- To view, visit http://gerrit.ovirt.org/33018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie858c69412698e9a11a7f52ee88c3c078b3f2303 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Fix Live Merge regression
by tnisan＠redhat.com 17 Sep '14

17 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix Live Merge regression ...................................................................... core: Fix Live Merge regression A change in CoCo exposed some bad code in DestroyImageCommand; fix the async task creation to not reference the wrong command type. Change-Id: I90e4b96cb673975c964fcb37146ad6baa510c8eb Bug-Url: https://bugzilla.redhat.com/1141985 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Greg Padgett: Verified -- To view, visit http://gerrit.ovirt.org/33017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90e4b96cb673975c964fcb37146ad6baa510c8eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix NPE in Configure Local Storage for host
by tnisan＠redhat.com 17 Sep '14

17 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix NPE in Configure Local Storage for host ...................................................................... webadmin: Fix NPE in Configure Local Storage for host Change-Id: I76bc89af6a22c269b3ce2034466d652f6e0e6db2 Bug-Url: https://bugzilla.redhat.com/1139675 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76bc89af6a22c269b3ce2034466d652f6e0e6db2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Live Merge recovery flow
by derez＠redhat.com 17 Sep '14

17 Sep '14

Daniel Erez has submitted this change and it was merged. Change subject: core: Live Merge recovery flow ...................................................................... core: Live Merge recovery flow When a VM stops running during a live merge, check the status using a new reconcileVolumeChain vdsm verb. This verb will ensure the volume chain is correct and return the comprising images, which we can then use to converge the Live Merge flow while the VM is still down. Change-Id: Ie858c69412698e9a11a7f52ee88c3c078b3f2303 Bug-Url: https://bugzilla.redhat.com/1129898 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeStatusCommandCallback.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ReconcileVolumeChainVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ReconcileVolumeChainVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/VolumeListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java 11 files changed, 192 insertions(+), 14 deletions(-) Approvals: Greg Padgett: Verified Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie858c69412698e9a11a7f52ee88c3c078b3f2303 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix Live Merge regression
by derez＠redhat.com 17 Sep '14

17 Sep '14

Daniel Erez has submitted this change and it was merged. Change subject: core: Fix Live Merge regression ...................................................................... core: Fix Live Merge regression A change in CoCo exposed some bad code in DestroyImageCommand; fix the async task creation to not reference the wrong command type. Change-Id: I90e4b96cb673975c964fcb37146ad6baa510c8eb Bug-Url: https://bugzilla.redhat.com/1141985 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCommand.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90e4b96cb673975c964fcb37146ad6baa510c8eb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove redundant JOIN statement in a storage procedure
by tnisan＠redhat.com 17 Sep '14

17 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove redundant JOIN statement in a storage procedure ...................................................................... core: Remove redundant JOIN statement in a storage procedure Removed JOIN in fn_get_actual_images_size_by_storage, the join with between images_storage_domain_view and disk_image_dynamic since the field actual_size used in the statement already exists in images_storage_domain_view Change-Id: I4f7096ef43876f3b2b96f61a60620e0e33a4e6db Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M packaging/dbscripts/create_functions.sql 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f7096ef43876f3b2b96f61a60620e0e33a4e6db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0