- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: dal: Unregistered entities fixups in DAO and fixtures
by mlipchuk＠redhat.com 21 Sep '14

21 Sep '14

Maor Lipchuk has submitted this change and it was merged. Change subject: dal: Unregistered entities fixups in DAO and fixtures ...................................................................... dal: Unregistered entities fixups in DAO and fixtures 1. Add unregistered Template entity to fixtures file 2. Use FixturesTool with the new entities 3. Fix UnregisteredOVFDataDAOTest accordingly 4. Fix typos found in the UnregisteredOVFDataDAOTest Change-Id: I3b8663eec50968c0553c8fc6e841b3244ffd418b Related to Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 3 files changed, 31 insertions(+), 10 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b8663eec50968c0553c8fc6e841b3244ffd418b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Adding command context support for Register Disk
by mlipchuk＠redhat.com 21 Sep '14

21 Sep '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Adding command context support for Register Disk ...................................................................... core: Adding command context support for Register Disk Adding command context constructor for Register Disk. Change-Id: Ic3303599c7e0b8d27bef6e63ca5c5615a292131f Related to Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3303599c7e0b8d27bef6e63ca5c5615a292131f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use the latest OVF_STORE files
by mlipchuk＠redhat.com 21 Sep '14

21 Sep '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use the latest OVF_STORE files ...................................................................... core: Use the latest OVF_STORE files Rotate over the OVF_STORE disks and retrieve the entities from the best match of the OVF_STORE disk until succeeded. Also register those disks as OVF_STORE disks, so it will be updated every time there will be any change in the entities' OVF. Change-Id: I8252281f295df49a28c3c131d9a98fef9af8f35e Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 47 insertions(+), 32 deletions(-) Approvals: Maor Lipchuk: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8252281f295df49a28c3c131d9a98fef9af8f35e Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Validate disk registration only if a domain exists.
by mlipchuk＠redhat.com 21 Sep '14

21 Sep '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Validate disk registration only if a domain exists. ...................................................................... core: Validate disk registration only if a domain exists. Registeration of a disk is only a DB operation and does not encounter any VDS commands, therefore there should not be any validation for Storage Domain activation. Change-Id: I71c138ede22808b5a887e9b9982c154e5591d5c9 Related to Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71c138ede22808b5a887e9b9982c154e5591d5c9 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Validate Storage Domain for Importing Template from co...
by mlipchuk＠redhat.com 21 Sep '14

21 Sep '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Validate Storage Domain for Importing Template from configuration ...................................................................... core: Validate Storage Domain for Importing Template from configuration For each disk in the template, we should fetch the Storage Domain and validate that it exists and active. Today, we set the storage id for each image and then use getStorageDomain method to fetch the Storage Domain with that id, but when the Storage Domain being initialized, it will always check the first Storage Domain every time. Change-Id: I2bfe3ba9b48747650291a887255e85358ed0799a Bug-Url: https://bugzilla.redhat.com/1138200 Bug-Url: https://bugzilla.redhat.com/1140560 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java 2 files changed, 31 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/32814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bfe3ba9b48747650291a887255e85358ed0799a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add unregistered entities to the ovf tar file
by mlipchuk＠redhat.com 21 Sep '14

21 Sep '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add unregistered entities to the ovf tar file ...................................................................... core: Add unregistered entities to the ovf tar file Sync the unregistered entities with the existing entities in the setup to be stored in the OVF_STORE disk. Change-Id: Icc5fc1c1b704ecbb49fe3d4c2561ec1836093369 Related to Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java 1 file changed, 26 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified Liron Aravot: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc5fc1c1b704ecbb49fe3d4c2561ec1836093369 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Override unregistered entity on deatch.
by mlipchuk＠redhat.com 21 Sep '14

21 Sep '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Override unregistered entity on deatch. ...................................................................... core: Override unregistered entity on deatch. Override unregistered entity when there is an existing entity which already exists as an unregistered entity. This can happen when a domain with an unregistered entity, is attached and a VM with disks on multiple storage domains exists in the setup and also as an unregistered VM. Once the VM will be created with disk on the attached Storage Domain, the unregistered entity should be overriden with the existing one, on detach process. Change-Id: Id22390ae392e95bbc73a5976fc886ed21da4989b Bug-Url: https://bugzilla.redhat.com/1132568 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, but someone else must approve Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32979 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id22390ae392e95bbc73a5976fc886ed21da4989b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use error for audit log on import template from config...
by mlipchuk＠redhat.com 21 Sep '14

21 Sep '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use error for audit log on import template from configuration. ...................................................................... core: Use error for audit log on import template from configuration. Use error audit log instead of refular audit log when the import VM from configuration fails Change-Id: I134f3a2015b7f249a361bd237b824709f7210f40 Bug-Url: https://bugzilla.redhat.com/1140584 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I134f3a2015b7f249a361bd237b824709f7210f40 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add validation for empty compute resource or host group
by oourfali＠redhat.com 21 Sep '14

21 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Add validation for empty compute resource or host group ...................................................................... core: Add validation for empty compute resource or host group Change-Id: Id26697e3e7a1b98c7e5e557cff3fd7078aecb67a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127606 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 4 files changed, 14 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id26697e3e7a1b98c7e5e557cff3fd7078aecb67a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix unmarshalling fenceNode response
by oourfali＠redhat.com 21 Sep '14

21 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix unmarshalling fenceNode response ...................................................................... core: Fix unmarshalling fenceNode response Fixes unmarshalling response of fenceNode call to VDSM. Change-Id: I1035c50e3f1c9cba49c3d477ec9c30599405f3bc Bug-Url: https://bugzilla.redhat.com/1143860 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1035c50e3f1c9cba49c3d477ec9c30599405f3bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0