- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core: allowed to add network label even if Vm using this net...
by oourfali＠redhat.com 16 Sep '14

16 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: allowed to add network label even if Vm using this network is running. ...................................................................... core: allowed to add network label even if Vm using this network is running. ~ Network label was checked to be unchanged in method 'onlyPermittedFieldsChanged'. This is extracted out into new method 'allowedNetworkLabelManipulation' which returns true if network label was not changed, or if former label was not specified (null) and new one is specified (!=null). ~ moved methods out from non static SyncNetworkParametersBuilder. These methods can be used outside from SyncNetworkParametersBuilder, but in that case their owning class have to be instantiated using CommandContext parameter, which is completely unrelated to these four methods. Change-Id: I40075be15ec9f3607c2f859b09e2b113d92f6e66 Bug-Url: https://bugzilla.redhat.com/1142203 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 22 insertions(+), 16 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40075be15ec9f3607c2f859b09e2b113d92f6e66 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: build: Make "pretty CSS" part of gwtdraft profile
by vszocs＠redhat.com 16 Sep '14

16 Sep '14

Vojtech Szocs has submitted this change and it was merged. Change subject: build: Make "pretty CSS" part of gwtdraft profile ...................................................................... build: Make "pretty CSS" part of gwtdraft profile With this patch, developer no longer needs to mess with extra defines like this, in order to have "pretty CSS" available: DEV_EXTRA_BUILD_FLAGS="... -Dgwt.cssResourceStyle=pretty" All that's needed now is to enable gwtdraft profile: DEV_BUILD_GWT_DRAFT=1 Updated README.developer to describe effects of activating DEV_BUILD_GWT_DRAFT option. Change-Id: I143d204d2f77e1e4350787c8ba46f61d4700f361 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M README.developer M frontend/webadmin/modules/pom.xml 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I143d204d2f77e1e4350787c8ba46f61d4700f361 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: Fix Maven build-time warnings
by awels＠redhat.com 16 Sep '14

16 Sep '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin,userportal: Fix Maven build-time warnings ...................................................................... webadmin,userportal: Fix Maven build-time warnings 1. gwt-extension POM now uses ${project.version} instead of ${version} within the <finalName> declaration 2. frontend POM no longer duplicates plugin declaration for build-helper-maven-plugin -- both <execution>s are now placed under single plugin declaration Change-Id: Id541ba5b01769dc5e8cab16f8260ea20b95e7270 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml 2 files changed, 2 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, but someone else must approve Einav Cohen: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit http://gerrit.ovirt.org/32145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id541ba5b01769dc5e8cab16f8260ea20b95e7270 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: refactor: renamed methods of ObjectCounter
by lvernia＠redhat.com 16 Sep '14

16 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: core: refactor: renamed methods of ObjectCounter ...................................................................... core: refactor: renamed methods of ObjectCounter Change-Id: I24e296de13fee757e109780f18e445887f6e856f Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/ObjectCounter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/Range.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/ObjectCounterTest.java 4 files changed, 35 insertions(+), 35 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24e296de13fee757e109780f18e445887f6e856f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : Clearing reports url
by oourfali＠redhat.com 16 Sep '14

16 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core : Clearing reports url ...................................................................... core : Clearing reports url The reports url will be configured by engine-setup Change-Id: I31cfa9b5e2e559275242c4e7bf15a6d4980f6db6 Bug-Url: https://bugzilla.redhat.com/1116851 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.conf.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31cfa9b5e2e559275242c4e7bf15a6d4980f6db6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, core: Return specific provider authentication error
by oourfali＠redhat.com 16 Sep '14

16 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin, core: Return specific provider authentication error ...................................................................... webadmin, core: Return specific provider authentication error On addProvider form the user fills authentication parameters to communicate with external provider. This patch adds more detailed warning message if the parameters are wrong and the authentication failed. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1113000 Change-Id: Ia8d6540b115454cfd2aa055ba711694f74855164 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>i Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 7 files changed, 13 insertions(+), 5 deletions(-) Approvals: Yaniv Bronhaim: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8d6540b115454cfd2aa055ba711694f74855164 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix fencing policy fields alignment
by oourfali＠redhat.com 16 Sep '14

16 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Fix fencing policy fields alignment ...................................................................... webadmin: Fix fencing policy fields alignment Fixes alignment of field in Fencing Policy tab in Cluster popup view. This problem appears only in Firefox 31 in RHEL 6. Change-Id: Icc5fb79a89c4b6e8fc710f02ce0e59fe5bfed95f Bug-Url: https://bugzilla.redhat.com/1139699 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Peřina: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32939 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc5fb79a89c4b6e8fc710f02ce0e59fe5bfed95f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: build: post ovirt-engine-dwh-3.5_rc2 respin2
by ydary＠redhat.com 16 Sep '14

16 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-dwh-3.5_rc2 respin2 ...................................................................... build: post ovirt-engine-dwh-3.5_rc2 respin2 Change-Id: Idd493434ff04a10ac48c3265c924e353f1e87d3d Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd493434ff04a10ac48c3265c924e353f1e87d3d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: build: ovirt-engine-dwh-3.5_rc2 respin2
by ydary＠redhat.com 16 Sep '14

16 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-dwh-3.5_rc2 respin2 ...................................................................... build: ovirt-engine-dwh-3.5_rc2 respin2 Change-Id: I89ee658ac6161f38efd41b1edc80120c26b75c29 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89ee658ac6161f38efd41b1edc80120c26b75c29 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : VMs pool disappeared after creating a Sub Template ...
by tnisan＠redhat.com 16 Sep '14

16 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine : VMs pool disappeared after creating a Sub Template version ...................................................................... engine : VMs pool disappeared after creating a Sub Template version VMs pool disappeared after creating a Sub Template version with exception constructor not found Change-Id: I7a4833182c3e9302308520a661e1318e366cb04d Bug-Url: https://bugzilla.redhat.com/1138419 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit 44dcd6f7595063db688f7109d1536a9264076449) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java 1 file changed, 19 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified; Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a4833182c3e9302308520a661e1318e366cb04d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0