- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: ImportVmFromConfiguration - @Override
by amureini＠redhat.com 16 Sep '14

16 Sep '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVmFromConfiguration - @Override ...................................................................... core: ImportVmFromConfiguration - @Override Added missing @Override annotation. Change-Id: I0dfedd47a8378864762167c401a46524b9968f95 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0dfedd47a8378864762167c401a46524b9968f95 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ImportVmFromConfiguration - modifiers
by amureini＠redhat.com 16 Sep '14

16 Sep '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVmFromConfiguration - modifiers ...................................................................... core: ImportVmFromConfiguration - modifiers Added static modifiers where possible to fix an IntelliJ IDEA warning. Change-Id: I2ea40b538e5f6ac9020a36204a7ce9f7a64e86a8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ea40b538e5f6ac9020a36204a7ce9f7a64e86a8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.4]: ovirt-iso-uploader: fixing usage of API SDK insecure parameter
by sbonazzo＠redhat.com 16 Sep '14

16 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-iso-uploader: fixing usage of API SDK insecure parameter ...................................................................... ovirt-iso-uploader: fixing usage of API SDK insecure parameter Python SDK insecure parameter simply skips hostname validation, it still gives errors if we also pass an unmatching CA cert. Change-Id: Ie72fbef874f595d60e0441a212329dfb07223c16 Bug-Url: https://bugzilla.redhat.com/1142131 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 17 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/32604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie72fbef874f595d60e0441a212329dfb07223c16 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.4 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : VMs pool disappeared after creating a Sub Template ...
by yzaslavs＠redhat.com 16 Sep '14

16 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : VMs pool disappeared after creating a Sub Template version ...................................................................... engine : VMs pool disappeared after creating a Sub Template version VMs pool disappeared after creating a Sub Template version with exception constructor not found Change-Id: I7a4833182c3e9302308520a661e1318e366cb04d Bug-Url: https://bugzilla.redhat.com/1138419 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java 1 file changed, 19 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a4833182c3e9302308520a661e1318e366cb04d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: removing default storage type question
by oourfali＠redhat.com 16 Sep '14

16 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: setup: removing default storage type question ...................................................................... packaging: setup: removing default storage type question Reviewing it, we found that the question is superfluous since almost all the user will choose 'shared'. Change-Id: Ia7e1ac239b4ad37580bc7ce0863734c60efa7cf5 Bug-Url: https://bugzilla.redhat.com/1138249 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py 1 file changed, 1 insertion(+), 19 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/32711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90cde87b8aaf9cc5b76737f2869b8ab25228c444 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: moved methods out from non static SyncNetworkParameter...
by lvernia＠redhat.com 16 Sep '14

16 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: core: moved methods out from non static SyncNetworkParametersBuilder ...................................................................... core: moved methods out from non static SyncNetworkParametersBuilder These methods can be used outside from SyncNetworkParametersBuilder, but in that case their owning class have to be instantiated using CommandContext parameter, which is completely unrelated to these four methods. Change-Id: I8adb975731d8e3a0367585a65993ec53d538fba3 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 14 insertions(+), 14 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8adb975731d8e3a0367585a65993ec53d538fba3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ExportVMCommand storage allocation checks
by amureini＠redhat.com 16 Sep '14

16 Sep '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: ExportVMCommand storage allocation checks ...................................................................... core: ExportVMCommand storage allocation checks This patch is a part of a series of patches, adding storage allocation validations to the system when they're missing, and replacing old verification usage with unified, new, correct and tested verification. This patch does this for ExportVmCommand, using only existing validations. Change-Id: Ic65fdc7324babacda2d1d49dc7157f6799b922f2 Bug-Url: https://bugzilla.redhat.com/1053747 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 23 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/32897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic65fdc7324babacda2d1d49dc7157f6799b922f2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.5]: ovirt-iso-uploader: fixing usage of API SDK insecure parameter
by sbonazzo＠redhat.com 16 Sep '14

16 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-iso-uploader: fixing usage of API SDK insecure parameter ...................................................................... ovirt-iso-uploader: fixing usage of API SDK insecure parameter Python SDK insecure parameter simply skips hostname validation, it still gives errors if we also pass an unmatching CA cert. Change-Id: Ie72fbef874f595d60e0441a212329dfb07223c16 Bug-Url: https://bugzilla.redhat.com/1136768 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 17 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/32596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie72fbef874f595d60e0441a212329dfb07223c16 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix Coverity Scan on getVdsStaticDao method
by oourfali＠redhat.com 16 Sep '14

16 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix Coverity Scan on getVdsStaticDao method ...................................................................... core: Fix Coverity Scan on getVdsStaticDao method Coverity Scan marked getVdsStaticDao method name as confusing. This patch pulls up this method to AuditLogableBase Change-Id: I69ea5f345e6758939a01997e161cd064a4c1d7f4 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommandTest.java 6 files changed, 6 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liran Zelkha: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69ea5f345e6758939a01997e161cd064a4c1d7f4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: build: fix jboss deploy location
by sbonazzo＠redhat.com 16 Sep '14

16 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: build: fix jboss deploy location ...................................................................... packaging: build: fix jboss deploy location broken by I88563c8c0 Change-Id: Id578f163f355b15743be1685038530047c39bfcc Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id578f163f355b15743be1685038530047c39bfcc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0