- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: use last successful proxy in wait-for-status
by emesika＠redhat.com 16 Sep '14

16 Sep '14

Eli Mesika has submitted this change and it was merged. Change subject: core: use last successful proxy in wait-for-status ...................................................................... core: use last successful proxy in wait-for-status Power Management proxy selection keep selecting the same proxy first even is it constantly fails This patch changes the waiting for status after stop/start PM action to use the last successful proxy along the wait-for-status loop instead of searching for proxy each time that might be resulted in significant delays in case that the preferred proxy (according to the proxy selection settings_ has some connectivity issues and can not access the PM card. Change-Id: I7684826be6098e952134366ce480ddb1ca3a2c99 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 27 insertions(+), 25 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7684826be6098e952134366ce480ddb1ca3a2c99 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: osinfo - add unsupported list of CPUs
by rgolan＠redhat.com 16 Sep '14

16 Sep '14

Roy Golan has submitted this change and it was merged. Change subject: core: osinfo - add unsupported list of CPUs ...................................................................... core: osinfo - add unsupported list of CPUs adding a comma separated list of unsupported CPUs to osinfo and 2 verbs to query it: public Map<Pair<Integer, Version>, Set<String>> getUnsupportedCpus(); public boolean isCpuSupported(int osId, Version version, String cpuId); Change-Id: I339b87de7646b813aa634102c26f710b9d5f6f75 Bug-Url: https://bugzilla.redhat.com/1096851 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java M packaging/conf/osinfo-defaults.properties 4 files changed, 89 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32923 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I339b87de7646b813aa634102c26f710b9d5f6f75 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Change cluster command should lock host
by tnisan＠redhat.com 16 Sep '14

16 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Change cluster command should lock host ...................................................................... core: Change cluster command should lock host This patch adds a missing lock when host cluster is changed. Prior to this change the host was not locked allowing a concurrent removal of the host to occur while the change cluster operation is still running this resulted on a SQL exception while trying to add a line to host SPM mapping table with a host GUID when the host was already removed. Change-Id: I1cd9e237838ce03438d806160d08efc9db0d6cd7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1102729 Signed-off-by: Eli Mesika <emesika(a)redhat.com> (cherry picked from commit abe3413e0e8c7056f764ebfc06e7c43b13371d0e) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cd9e237838ce03438d806160d08efc9db0d6cd7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: aaa: fix coverity issue, default encoding
by tnisan＠redhat.com 16 Sep '14

16 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: aaa: fix coverity issue, default encoding ...................................................................... restapi: aaa: fix coverity issue, default encoding Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I5de36d41c23d548fb4a6d91902cbd00f358e09c5 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5de36d41c23d548fb4a6d91902cbd00f358e09c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: packaging: Added release notes
by ydary＠redhat.com 16 Sep '14

16 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: Added release notes ...................................................................... packaging: Added release notes Change-Id: Ic636173c641e122d9a75c4cf54ce67c3d1eee8d8 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic636173c641e122d9a75c4cf54ce67c3d1eee8d8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Change cluster command should lock host
by yzaslavs＠redhat.com 15 Sep '14

15 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Change cluster command should lock host ...................................................................... core: Change cluster command should lock host This patch adds a missing lock when host cluster is changed. Prior to this change the host was not locked allowing a concurrent removal of the host to occur while the change cluster operation is still running this resulted on a SQL exception while trying to add a line to host SPM mapping table with a host GUID when the host was already removed. Change-Id: I1cd9e237838ce03438d806160d08efc9db0d6cd7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1102729 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cd9e237838ce03438d806160d08efc9db0d6cd7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Data center list of a storage domain should be sor...
by tnisan＠redhat.com 15 Sep '14

15 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Data center list of a storage domain should be sorted by DC name ...................................................................... webadmin: Data center list of a storage domain should be sorted by DC name Change-Id: I1af7d25f10a80cf9106007fa4b1f85cd9ffb9e3a Related-To: https://bugzilla.redhat.com/1117228 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Objections: automation(a)ovirt.org: Fails -- To view, visit http://gerrit.ovirt.org/32956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1af7d25f10a80cf9106007fa4b1f85cd9ffb9e3a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix bug in DC selection for an ISO domain attached...
by tnisan＠redhat.com 15 Sep '14

15 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix bug in DC selection for an ISO domain attached to multiple DCs ...................................................................... webadmin: Fix bug in DC selection for an ISO domain attached to multiple DCs Change-Id: I31dd6b0a2908f82bdcb3762c963908865ac88f42 Bug-Url: https://bugzilla.redhat.com/1117228 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31dd6b0a2908f82bdcb3762c963908865ac88f42 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: remove snapshot - validate snapshot type
by tnisan＠redhat.com 15 Sep '14

15 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: remove snapshot - validate snapshot type ...................................................................... core: remove snapshot - validate snapshot type * Validate snapshot type on RemoveSnapshotCommand (e.g. Active snapshots cannot be removed). * Removed the obsolete validation based on a representative image. * Added appropriate tests accordingly. Change-Id: I90d9144e9d0f7db4f165b7d6945bb27d387c4f66 Bug-Url: https://bugzilla.redhat.com/1140207 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 29 insertions(+), 23 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90d9144e9d0f7db4f165b7d6945bb27d387c4f66 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: remove snapshot - validate snapshot type
by derez＠redhat.com 15 Sep '14

15 Sep '14

Daniel Erez has submitted this change and it was merged. Change subject: core: remove snapshot - validate snapshot type ...................................................................... core: remove snapshot - validate snapshot type * Validate snapshot type on RemoveSnapshotCommand (e.g. Active snapshots cannot be removed). * Removed the obsolete validation based on a representative image. * Added appropriate tests accordingly. Change-Id: I90d9144e9d0f7db4f165b7d6945bb27d387c4f66 Bug-Url: https://bugzilla.redhat.com/1140207 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 29 insertions(+), 23 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90d9144e9d0f7db4f165b7d6945bb27d387c4f66 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0