- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: packaging: jsonrpc version update
by oourfali＠redhat.com 10 Sep '14

10 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: jsonrpc version update ...................................................................... packaging: jsonrpc version update Bug-Url: https://bugzilla.redhat.com/1136876 Change-Id: Ib8bde0cc1e54366be10042085265ef988ae53450 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8bde0cc1e54366be10042085265ef988ae53450 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: The scroll bar is not aligned with the Edit Role m...
by oourfali＠redhat.com 10 Sep '14

10 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: The scroll bar is not aligned with the Edit Role menu box ...................................................................... webadmin: The scroll bar is not aligned with the Edit Role menu box In edit role dialog the permissions tree scroll bar is not aligned with edit role menu box Change-Id: I03e80765cffddd77c95d80ee386bbea4fd16d620 Bug-Url: https://bugzilla.redhat.com/1128449 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit 304356481cef283f27af2f60eb1720e7086243f6) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03e80765cffddd77c95d80ee386bbea4fd16d620 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Fix search to search properly for users by groups
by oourfali＠redhat.com 10 Sep '14

10 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: Fix search to search properly for users by groups ...................................................................... aaa: Fix search to search properly for users by groups Instead of ilike 'group%' which is problematic in case the user is member of multiple groups , the pattern matching operator is used with a proper expression to replace the % wildcard. Topic: AAA Bug-Url: https://bugzilla.redhat.com/1120720 Change-Id: I14e795926cb57de15b628587d5c3df427518720a Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/IConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java 4 files changed, 24 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/32705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14e795926cb57de15b628587d5c3df427518720a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Coverity CID 1231855 (NULL_RETURNS)
by lvernia＠redhat.com 10 Sep '14

10 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Coverity CID 1231855 (NULL_RETURNS) ...................................................................... webadmin: Coverity CID 1231855 (NULL_RETURNS) Added assertions to make sure developers properly use the method. Change-Id: Ie5c451a9d52942d703f3f1eb05ad301fbf355f55 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5c451a9d52942d703f3f1eb05ad301fbf355f55 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: jsonrpc version update
by oourfali＠redhat.com 10 Sep '14

10 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: jsonrpc version update ...................................................................... packaging: jsonrpc version update Bug-Url: https://bugzilla.redhat.com/1136876 Change-Id: Ib8bde0cc1e54366be10042085265ef988ae53450 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8bde0cc1e54366be10042085265ef988ae53450 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: cleanup in AddVmFromScratchParameters
by ofrenkel＠redhat.com 10 Sep '14

10 Sep '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: cleanup in AddVmFromScratchParameters ...................................................................... core: cleanup in AddVmFromScratchParameters - Remove unused network related data - Remove the 'private' prefix from privateDiskInfoList field Change-Id: Iea82daa2f1afc2440ac71732e6896ddcad3c7673 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromScratchParameters.java 1 file changed, 3 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/32639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea82daa2f1afc2440ac71732e6896ddcad3c7673 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Remove redundant header splitters in fixed columns
by lvernia＠redhat.com 10 Sep '14

10 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Remove redundant header splitters in fixed columns ...................................................................... webadmin: Remove redundant header splitters in fixed columns This was previously fixed in resizable columns, but not in fixed ones. Change-Id: I0090109d3cc2c4a18418fef49eaf09b8a5c52915 Bug-Url: https://bugzilla.redhat.com/1139551 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0090109d3cc2c4a18418fef49eaf09b8a5c52915 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: The text and buttons not aligned in Create VM dialog
by tjelinek＠redhat.com 10 Sep '14

10 Sep '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: The text and buttons not aligned in Create VM dialog ...................................................................... webadmin: The text and buttons not aligned in Create VM dialog The http://gerrit.ovirt.org/#/c/30821 enhanced the "Guide Me" dialog so also the bigger text will fit in. The problem with this patch is that it uses the "display: flex" which is not supported by firefox 17 and firefox 17 is the only browser supported by oVirt. So this patch "reverts" this fix and applyes the one proposed here: http://gerrit.ovirt.org/#/c/30861/ which does not look so nice but works also on older browsers. Change-Id: Ifcb74f036476fb8544d1f15d26a0ef92e2eeed46 Bug-Url: https://bugzilla.redhat.com/1135965 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 3 files changed, 12 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcb74f036476fb8544d1f15d26a0ef92e2eeed46 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core : Invalid action group identifiers in the roles_groups...
by oourfali＠redhat.com 10 Sep '14

10 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core : Invalid action group identifiers in the roles_groups table ...................................................................... core : Invalid action group identifiers in the roles_groups table invalid action groups in roles_groups table causes NPE when listing permits using restapi. The roles groups 130 and 131 as listed in roles_groups table are not valid role group ids and are can be safely removed. The ids were erroneosuly ntroduced into the roles_groups table by commit c89b145f12d77a7271d63073d5. The correct action group id for install vds and upgrade oVirtNode is 101(EDIT_HOST_CONFIGURATION) and is already present in the roles_groups table. Change-Id: Ib511e7c3a657c884a92ddee5e7972bd3e7a95497 Bug-Url: https://bugzilla.redhat.com/1139533 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit 11f323c2bca08171f084811baf5d142225ee0e6b) --- A packaging/dbscripts/upgrade/03_05_1040_remove_install_vds_upgrade_ovirt_node_action_group.sql 1 file changed, 38 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib511e7c3a657c884a92ddee5e7972bd3e7a95497 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : Invalid action group identifiers in the roles_groups...
by oourfali＠redhat.com 10 Sep '14

10 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core : Invalid action group identifiers in the roles_groups table ...................................................................... core : Invalid action group identifiers in the roles_groups table invalid action groups in roles_groups table causes NPE when listing permits using restapi. The roles groups 130 and 131 as listed in roles_groups table are not valid role group ids and are can be safely removed. The ids were erroneosuly ntroduced into the roles_groups table by commit c89b145f12d77a7271d63073d5. The correct action group id for install vds and upgrade oVirtNode is 101(EDIT_HOST_CONFIGURATION) and is already present in the roles_groups table. Change-Id: Ib511e7c3a657c884a92ddee5e7972bd3e7a95497 Bug-Url: https://bugzilla.redhat.com/1139533 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_0360_remove_install_vds_upgrade_ovirt_node_action_group.sql 1 file changed, 38 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib511e7c3a657c884a92ddee5e7972bd3e7a95497 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0