- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: The scroll bar is not aligned with the Edit Role m...
by oourfali＠redhat.com 09 Sep '14

09 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: The scroll bar is not aligned with the Edit Role menu box ...................................................................... webadmin: The scroll bar is not aligned with the Edit Role menu box In edit role dialog the permissions tree scroll bar is not aligned with edit role menu box Change-Id: I03e80765cffddd77c95d80ee386bbea4fd16d620 Bug-Url: https://bugzilla.redhat.com/1128449 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03e80765cffddd77c95d80ee386bbea4fd16d620 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: setup: Avoid engine DB password in answerfile if ...
by oourfali＠redhat.com 09 Sep '14

09 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: packaging: setup: Avoid engine DB password in answerfile if providing ...................................................................... packaging: setup: Avoid engine DB password in answerfile if providing If engine-setup is providing the DB the DB password is randomly generated. Avoiding to write it in the answer file, the password will be randomly choosed also replaying that answer file. Change-Id: I3fb9d2c10d3809c68430084f6212eaa191d5ca21 Bug-Url: https://bugzilla.redhat.com/1139211 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/32651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fb9d2c10d3809c68430084f6212eaa191d5ca21 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: style fixes in manage events popup.
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: style fixes in manage events popup. ...................................................................... webadmin: style fixes in manage events popup. Change-Id: Ie7b8063d60666bdbcaaeaa7347ff36b7a3ddc369 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133572 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> (cherry picked from commit fc8ccf4ca617cc876eb8df428ee25a7a9a765557) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/css/NotificationsTree.css 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Looks good to me, approved mooli tayer: Verified -- To view, visit http://gerrit.ovirt.org/32675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7b8063d60666bdbcaaeaa7347ff36b7a3ddc369 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: vm name field is misaligned on "new vm" pop up window
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: vm name field is misaligned on "new vm" pop up window ...................................................................... webadmin: vm name field is misaligned on "new vm" pop up window The mistake happend during the backport. The patch to master branch (http://gerrit.ovirt.org/#/c/31034) contains the configuration of the "nameEditorContent" as "width: 238px", while the backport patch (http://gerrit.ovirt.org/#/c/31159) contains the width: "230px". This patch fixes this backport mistake to make also the 3.5 version 238px width. Change-Id: I05dba94b33a72ae0644b4f543d257efed52a3fb4 Bug-Url: https://bugzilla.redhat.com/1133995 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Alexander Wels: Looks good to me, approved Martin Betak: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05dba94b33a72ae0644b4f543d257efed52a3fb4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: correctly writing pg_hba.conf
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: correctly writing pg_hba.conf ...................................................................... packaging: setup: correctly writing pg_hba.conf Fixing the parameter order writing pg_hba.conf Change-Id: I6a75084ec5134570f0c27b60214db00813651370 Bug-Url: http://bugzilla.redhat.com/1134444 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit d431535542ab49f4db30e0b79125a07382a032a1) --- M packaging/setup/ovirt_engine_setup/engine_common/postgres.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/32516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a75084ec5134570f0c27b60214db00813651370 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: removing default storage type question
by sbonazzo＠redhat.com 09 Sep '14

09 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: removing default storage type question ...................................................................... packaging: setup: removing default storage type question Reviewing it, we found that the question is superfluous since almost all the user will choose 'shared'. Change-Id: Ia7e1ac239b4ad37580bc7ce0863734c60efa7cf5 Bug-Url: https://bugzilla.redhat.com/1102021 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py 1 file changed, 2 insertions(+), 21 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7e1ac239b4ad37580bc7ce0863734c60efa7cf5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: avoid duplicate keys in answerfile
by sbonazzo＠redhat.com 09 Sep '14

09 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: avoid duplicate keys in answerfile ...................................................................... packaging: setup: avoid duplicate keys in answerfile Avoiding duplicate keys in answerfile. Change-Id: I96504ec0fc6112dfeb539294f84ce2294d1b2850 Bug-Url: https://bugzilla.redhat.com/1118335 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96504ec0fc6112dfeb539294f84ce2294d1b2850 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Fix validation of UnitVmModel
by awels＠redhat.com 09 Sep '14

09 Sep '14

Alexander Wels has submitted this change and it was merged. Change subject: frontend: Fix validation of UnitVmModel ...................................................................... frontend: Fix validation of UnitVmModel Individual entity models were validated but the validate() method always returned true since the validity of individual tabs was not taken into account. This resulted in submitting invalid edits and subsequent backend validation errors. Change-Id: Iabba7f93a0541292a1a4c82b675ab0faf141b9b2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128444 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 2 files changed, 11 insertions(+), 14 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/32645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabba7f93a0541292a1a4c82b675ab0faf141b9b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: Avoid engine DB password in answerfile if ...
by tnisan＠redhat.com 09 Sep '14

09 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: Avoid engine DB password in answerfile if providing ...................................................................... packaging: setup: Avoid engine DB password in answerfile if providing If engine-setup is providing the DB the DB password is randomly generated. Avoiding to write it in the answer file, the password will be randomly choosed also replaying that answer file. Change-Id: I3fb9d2c10d3809c68430084f6212eaa191d5ca21 Bug-Url: https://bugzilla.redhat.com/1139211 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 7f91be98f63034815147d65d490b43a99bec5683) --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py 3 files changed, 12 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fb9d2c10d3809c68430084f6212eaa191d5ca21 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa: Fix search to search properly for users by groups
by yzaslavs＠redhat.com 09 Sep '14

09 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Fix search to search properly for users by groups ...................................................................... aaa: Fix search to search properly for users by groups Instead of ilike 'group%' which is problematic in case the user is member of multiple groups , the pattern matching operator is used with a proper expression to replace the % wildcard. Topic: AAA Change-Id: I14e795926cb57de15b628587d5c3df427518720a Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/IConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java 4 files changed, 24 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14e795926cb57de15b628587d5c3df427518720a Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0