- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Reduce number of tasks in queue log messages
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Reduce number of tasks in queue log messages ...................................................................... core: Reduce number of tasks in queue log messages When the engine server is loaded, there is a message printed to the log. This patch increases the threshold of the number of waiting tasks from 0 to 5. Change-Id: Ieb061ed29750184bcdd39af7d8c3fc7d0dcacabd Bug-Url: https://bugzilla.redhat.com/1130076 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> (cherry picked from commit 0c9c012b8704794e27d5a44842fd447cc7a2aa24) --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/threadpool/ThreadPoolUtil.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb061ed29750184bcdd39af7d8c3fc7d0dcacabd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: add QoS RESTful interface for storage QoS
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: add QoS RESTful interface for storage QoS ...................................................................... restapi: add QoS RESTful interface for storage QoS - POST: /ovirt-engine/api/datacenters/{datacenter:id}/qoss; body: qos; response: qos <qos type="storage"> <name>test_qos</name> <description>aaaaa</description> <max_throughput>1</max_throughput> <max_read_throughput>1</max_read_throughput> <max_write_throughput>1</max_write_throughput> <max_iops>1</max_iops> <max_read_iops>1</max_read_iops> <max_write_iops>1</max_write_iops> </qos> - GET: /ovirt-engine/api/datacenters/{datacenter:id}/qoss; response: qoss - DELETE: /ovirt-engine/api/datacenters/{datacenter:id}/qoss/{qos:id}; - GET: /ovirt-engine/api/datacenters/{datacenter:id}/qoss/{qos:id}; response: qos <qos type="storage" href="/ovirt-engine/api/datacenters/00000002-0002-0002-0002-000000000321/qoss/a66577ff-d5f1-40f7-aebb-0b350ad8bb8c" id="a66577ff-d5f1-40f7-aebb-0b350ad8bb8c"> <name>test_qos</name> <description>aaaaa</description> <data_center href="/ovirt-engine/api/datacenters/00000002-0002-0002-0002-000000000321" id="00000002-0002-0002-0002-000000000321"/> <max_throughput>1</max_throughput> <max_read_throughput>1</max_read_throughput> <max_write_throughput>1</max_write_throughput> <max_iops>1</max_iops> <max_read_iops>1</max_read_iops> <max_write_iops>1</max_write_iops> </qos> - PUT: /ovirt-engine/api/datacenters/{datacenter:id}/qoss/{qos:id}; body: qos; response: qos For more information see: http://www.ovirt.org/Features/aggregate_QoS, http://www.ovirt.org/Features/blkio-support#RESTful_API Change-Id: I1a9af59277b50554531522802f19046c0051d82f Bug-Url: https://bugzilla.redhat.com/1085049 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/QosType.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DataCenterResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QoSsResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QosResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterClustersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCentersResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQosResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/QosValidator.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/QosMapperTest.java 17 files changed, 581 insertions(+), 31 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/31806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a9af59277b50554531522802f19046c0051d82f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Allow selection of None for Cloud-Init network boo...
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Allow selection of None for Cloud-Init network boot protocol ...................................................................... webadmin: Allow selection of None for Cloud-Init network boot protocol The REST API supported DHCP, Static IP, and None as NIC address types for cloud-init VM startup. Make the same available in the UI as well. Change-Id: Ic51a76e968922fb62a07ccaced969c8b580de083 Bug-Url: https://bugzilla.redhat.com/1120092 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> Signed-off-by: Moti Asayag <masayag(a)redhat.com> (cherry picked from commit d5dafab5c906c65a2878dbefd0a4b2cb8f3a1534) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java 4 files changed, 43 insertions(+), 27 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic51a76e968922fb62a07ccaced969c8b580de083 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: 'Start-on-boot' of a nic should be respected
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: 'Start-on-boot' of a nic should be respected ...................................................................... core: 'Start-on-boot' of a nic should be respected The user should be able to instruct which network interface will be booted on startup when the interface is configured by cloud-init. Change-Id: I325c5edaa27be322bd5488d4397f696338e434fe Bug-Url: https://bugzilla.redhat.com/1132439 Signed-off-by: Moti Asayag <masayag(a)redhat.com> (cherry picked from commit cf8f8106ca83c33721a6c61ec2ce297bd828d0b6) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/31772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I325c5edaa27be322bd5488d4397f696338e434fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fix application messages
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fix application messages ...................................................................... core: fix application messages Some error messages are enclosed in double quotation marks that are redundant and one message contains a typo Change-Id: I898c232be9ad082ec262f44e2a958763e405bac0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131484 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I898c232be9ad082ec262f44e2a958763e405bac0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: In disks tab/subtab, make the default view to All
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: In disks tab/subtab, make the default view to All ...................................................................... webadmin: In disks tab/subtab, make the default view to All In the disks maintab/subtab we have 3 view options - All, Images, LUNs, the default was "Images" and now was changed to "All" Bug-Url: https://bugzilla.redhat.com/878962 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Change-Id: I4f97a8c39053eac961a79141071ee3471825f1df --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewRadioGroup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DiskModule.java 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f97a8c39053eac961a79141071ee3471825f1df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: fix build break
by amureini＠redhat.com 25 Aug '14

25 Aug '14

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: fix build break ...................................................................... restapi: fix build break Fix compilation error introduced by ced96c948c538fe5674528e54c8a1f754446a4d0 Change-Id: Ib8470ebbc6b8afe515f51d4c9ae235d796445e4c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionsResource.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ori Liel: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/31889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8470ebbc6b8afe515f51d4c9ae235d796445e4c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fixing other_dc proxy preference implementation
by oourfali＠redhat.com 25 Aug '14

25 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: fixing other_dc proxy preference implementation ...................................................................... core: fixing other_dc proxy preference implementation Fencing with proxy from other_dc is actually performed by a proxy in the same dc This patch actually issues two things 1) the selected proxy preferences where not passed by the HostModel so always the "cluster,dc" default was treated 2) when searching for a proxy on other_dc, hosts from the fenced host DC where not filtered out. Change-Id: I0de81858dc9f9b76bd27c75cb47086c884f1d6cd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131411 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNewVdsFenceStatusQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetNewVdsFenceStatusParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 4 files changed, 19 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Gilad Chaplik: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31870 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0de81858dc9f9b76bd27c75cb47086c884f1d6cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add vm.disks.disk collection to RSDL schema
by juan.hernandez＠redhat.com 25 Aug '14

25 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add vm.disks.disk collection to RSDL schema ...................................................................... restapi: Add vm.disks.disk collection to RSDL schema Change-Id: I789144e1a51817bb268c0467943bba1d6a9c8889 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132078 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I789144e1a51817bb268c0467943bba1d6a9c8889 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Make OsType enum consistent with OsRepository
by juan.hernandez＠redhat.com 25 Aug '14

25 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Make OsType enum consistent with OsRepository ...................................................................... restapi: Make OsType enum consistent with OsRepository The restapi enum OsType contained WINDOWS_2008R2 which was not one of the os' supported in OsRepository (only the windows_2008r2x64 is supported). Change-Id: I636de81217db51aaf122d0851f9102e7406e8531 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109546 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/OsType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Martin Betak: Verified Roy Golan: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I636de81217db51aaf122d0851f9102e7406e8531 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0