- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Expose effective SPICE proxy in VM.display
by juan.hernandez＠redhat.com 25 Aug '14

25 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Expose effective SPICE proxy in VM.display ...................................................................... restapi: Expose effective SPICE proxy in VM.display Change-Id: I0bc84f39c8b6a2da742baae9b0874c2f36c3738d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1054948 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 4 files changed, 61 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bc84f39c8b6a2da742baae9b0874c2f36c3738d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: also consider file groups in cleanup
by sbonazzo＠redhat.com 25 Aug '14

25 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: also consider file groups in cleanup ...................................................................... packaging: setup: also consider file groups in cleanup Change-Id: Ia25acec388c913f1d81c7cde3f43bda29a9013ae Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/31468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia25acec388c913f1d81c7cde3f43bda29a9013ae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: accept action in remove storage connection
by juan.hernandez＠redhat.com 25 Aug '14

25 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: accept action in remove storage connection ...................................................................... restapi: accept action in remove storage connection Storage connections delete operation now takes an Action as optional parameter. The Action object should contain a Host element from which the connection would be unmounted. Change-Id: I19a0047ee14962eb8a6d0ab2c4e981913d062612 Bug-Url: https://bugzilla.redhat.com/1117278 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageServerConnectionsResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResourceTest.java 4 files changed, 28 insertions(+), 16 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19a0047ee14962eb8a6d0ab2c4e981913d062612 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: storage disks subtab - fix status column
by derez＠redhat.com 25 Aug '14

25 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: storage disks subtab - fix status column ...................................................................... webadmin: storage disks subtab - fix status column Storage > Disks: 'Status' column should be fetched using 'getStatusColumn' method. Change-Id: Ia373c40f696ce080dbfd09252fc96a5b59b3a80c Bug-Url: https://bugzilla.redhat.com/1133265 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageDiskView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia373c40f696ce080dbfd09252fc96a5b59b3a80c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix client sorting for size columns
by derez＠redhat.com 25 Aug '14

25 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fix client sorting for size columns ...................................................................... webadmin: fix client sorting for size columns Currently, size columns are sorted using LexoNumericComparator, which is fine for most cases except for '< 1 GB' value... Hence, overridden 'makeSortable' method to compare the size values numerically. Screenshot: http://i.imgur.com/KfJjdq8.png Change-Id: Iab8cdc171ff8f652ec0747212f6fd846cf95540e Bug-Url: https://bugzilla.redhat.com/1133264 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractSizeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskSizeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StorageSizeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java 4 files changed, 31 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab8cdc171ff8f652ec0747212f6fd846cf95540e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: missing disks link in SD VMs resource
by juan.hernandez＠redhat.com 25 Aug '14

25 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: missing disks link in SD VMs resource ...................................................................... restapi: missing disks link in SD VMs resource Added missing 'disks' link for vms/templates under an export storage domain resource (i.e. on locations [1] and [2]). [1] /api/storagedomains/{storagedomain:id}/vms [2] /api/storagedomains/{storagedomain:id}/templates Change-Id: Ic8b7fe696f66eb02f2d402985e845f746ccb2095 Bug-Url: https://bugzilla.redhat.com/1130182 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainContentsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java 3 files changed, 14 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8b7fe696f66eb02f2d402985e845f746ccb2095 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: fix rsdl generation for import glance image
by juan.hernandez＠redhat.com 25 Aug '14

25 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: fix rsdl generation for import glance image ...................................................................... restapi: fix rsdl generation for import glance image Import action has been missing under '/api/storagedomains/{storagedomain:id}/images/{images:id}/'. Hence, added missing signature on ImagesResource interface. Change-Id: Icf119c8a9b30385d14c756217d5c3c7fead84472 Bug-Url: https://bugzilla.redhat.com/1096496 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ImagesResource.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf119c8a9b30385d14c756217d5c3c7fead84472 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: TypeAheadListBox to display default text
by lvernia＠redhat.com 25 Aug '14

25 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: TypeAheadListBox to display default text ...................................................................... webadmin: TypeAheadListBox to display default text Adjusted the widget to display default grayed-out text when it has no content. Change-Id: I18d43efadde607867be440af73a9d67a14c293e0 Bug-Url: https://bugzilla.redhat.com/1086259 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java 2 files changed, 18 insertions(+), 17 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18d43efadde607867be440af73a9d67a14c293e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: getting a cert for a remote wsp via suppor...
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: getting a cert for a remote wsp via support files ...................................................................... packaging: setup: getting a cert for a remote wsp via support files Providing support to get the certificate for a remote Websocket Proxy also via support files and not just only with copy and paste. Adding pasted cert validation and better error handling. Change-Id: I24384e213470ff521a8a3651920fef594e4d7c9d Bug-Url: https://bugzilla.redhat.com/1116017 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py 1 file changed, 135 insertions(+), 41 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/31762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24384e213470ff521a8a3651920fef594e4d7c9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin, userportal: Custom 405 error page
by tnisan＠redhat.com 25 Aug '14

25 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin, userportal: Custom 405 error page ...................................................................... webadmin, userportal: Custom 405 error page After rhev manager access failure, browser should not display the "JBoss Web" package version. Change-Id: I3029915d10f3df830f3040dc1269ac4607e33ac7 Bug-Url: https://bugzilla.redhat.com/1129944 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/docs/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/welcome/src/main/resources/messages.properties A backend/manager/modules/welcome/src/main/webapp/WEB-INF/405.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/frontend/src/main/resources/META-INF/web-fragment.xml M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml 8 files changed, 146 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3029915d10f3df830f3040dc1269ac4607e33ac7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0