- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Report domain monitoring for virt nodes only
by laravot＠redhat.com 20 Aug '14

20 Aug '14

Liron Aravot has submitted this change and it was merged. Change subject: engine: Report domain monitoring for virt nodes only ...................................................................... engine: Report domain monitoring for virt nodes only Storage domain monitoring is required only for virtualization nodes (not for gluster nodes) Change-Id: I8731a81de756cbe0bb221f205c2a6d50c015b86b Bug-Url: https://bugzilla.redhat.com/1105513 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve Sahina Bose: Verified Liron Aravot: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8731a81de756cbe0bb221f205c2a6d50c015b86b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add UI field for Neutron physical network
by lvernia＠redhat.com 20 Aug '14

20 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Add UI field for Neutron physical network ...................................................................... webadmin: Add UI field for Neutron physical network The same UI field was being used for both the oVirt label and the Neutron physical network, and only its interpretation changed according to context, which was confusing. As usual, had to change some styling for things to look decent (some of it is related to unresolved Look & Feel feature issues). Change-Id: I6b90800cf5948b35283bef03d8e2f95384799c80 Bug-Url: https://bugzilla.redhat.com/1108069 Bug-Url: https://bugzilla.redhat.com/1121546 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 6 files changed, 46 insertions(+), 53 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b90800cf5948b35283bef03d8e2f95384799c80 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add some spacing to checkbox cell labels
by lvernia＠redhat.com 20 Aug '14

20 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Add some spacing to checkbox cell labels ...................................................................... webadmin: Add some spacing to checkbox cell labels Some regression occurred in 3.5 where labels in checkbox cells too close to the actual checkbox (presumably due to the Look & Feel patches). This adds some space between them. Change-Id: I2e345fcfdfb18c8305598e0affc87c2e6c196092 Bug-Url: https://bugzilla.redhat.com/1120984 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e345fcfdfb18c8305598e0affc87c2e6c196092 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add disk profile to disk's commands
by ahadas＠redhat.com 20 Aug '14

20 Aug '14

Arik Hadas has submitted this change and it was merged. Change subject: core: add disk profile to disk's commands ...................................................................... core: add disk profile to disk's commands * Allow null disk profile id, if there's a single disk profile in relevant storage domain (trivial case to avoid breaking current flow). * Replace null disk profile with trivial one. * Validate disk profile in all disk flows. * Permission for disk profiles will be handled in a later patch, currently we rely on storage domain permissions (no change in flow). Change-Id: Ie7b6d977243cffc0bde772665ebaca47340075c6 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 23 files changed, 276 insertions(+), 21 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7b6d977243cffc0bde772665ebaca47340075c6 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: removed forgotten "<<< HEAD" from the comment
by ofrenkel＠redhat.com 20 Aug '14

20 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: engine: removed forgotten "<<< HEAD" from the comment ...................................................................... engine: removed forgotten "<<< HEAD" from the comment It was a merging mistake, removed Change-Id: Id826f4d6167b9aa08c3437db1c8b03fc4cfb4180 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id826f4d6167b9aa08c3437db1c8b03fc4cfb4180 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix possible NPE on run/migrate commands
by ahadas＠redhat.com 20 Aug '14

20 Aug '14

Arik Hadas has submitted this change and it was merged. Change subject: core: fix possible NPE on run/migrate commands ...................................................................... core: fix possible NPE on run/migrate commands In some cases we might reach the runningFailed method when no host was selected by the scheduler, so we could get NPE when trying to decrease the pending memory. So null-check is added. Change-Id: I664b2aaabc855ed3b28a9b8fdee64d32c4191e65 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/31617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I664b2aaabc855ed3b28a9b8fdee64d32c4191e65 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add 'Comment' field to OVF
by ofrenkel＠redhat.com 20 Aug '14

20 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: add 'Comment' field to OVF ...................................................................... core: add 'Comment' field to OVF 'Comment' is missing from the OVF, therfore, missing from snapshots, import-export and also not working when editing running vm. this patch add the fields to the OVF and solving all above. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128446 Change-Id: I79fdcfd10d2bd510b57314f330f349b38e6f5ee2 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 3 files changed, 10 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/31666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79fdcfd10d2bd510b57314f330f349b38e6f5ee2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[cli_3.5]: cli: Use UTF-8 for writing output files
by juan.hernandez＠redhat.com 20 Aug '14

20 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Use UTF-8 for writing output files ...................................................................... cli: Use UTF-8 for writing output files Currently when the CLI opens an output file due to a redirection it opens it using the ASCII character encoding. If the text written to the file contains characters outside of the ASCII set an exception is generated. This patch changes the CLI so that it uses UTF-8 when writing these files. Change-Id: Ibe4eae82d3360c678cba133106e4a30ab930ca3b Bug-Url: https://bugzilla.redhat.com/1126763 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 80ed3042919b6cf4442cb5a8bae9117a934b56b8) --- M src/cli/context.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe4eae82d3360c678cba133106e4a30ab930ca3b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core, db: disk profile: handle attach/detach
by ahadas＠redhat.com 20 Aug '14

20 Aug '14

Arik Hadas has submitted this change and it was merged. Change subject: core, db: disk profile: handle attach/detach ...................................................................... core, db: disk profile: handle attach/detach Attach: create disk profile for new storage domain in pool (attach/create) Detach: remove qos id from disk profiles of detached storage domain Change-Id: I29aaf7b0b537f0b80b91b09e025e9487bbb69c2d Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/DiskProfileDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoTest.java M packaging/dbscripts/disk_profiles_sp.sql 7 files changed, 77 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29aaf7b0b537f0b80b91b09e025e9487bbb69c2d Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: Use UTF-8 for writing output files
by juan.hernandez＠redhat.com 20 Aug '14

20 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Use UTF-8 for writing output files ...................................................................... cli: Use UTF-8 for writing output files Currently when the CLI opens an output file due to a redirection it opens it using the ASCII character encoding. If the text written to the file contains characters outside of the ASCII set an exception is generated. This patch changes the CLI so that it uses UTF-8 when writing these files. Change-Id: Ibe4eae82d3360c678cba133106e4a30ab930ca3b Bug-Url: https://bugzilla.redhat.com/1126763 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/cli/context.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe4eae82d3360c678cba133106e4a30ab930ca3b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0