- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Forbid Bootable and Shareable Disks
by derez＠redhat.com 19 Aug '14

19 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: engine: Forbid Bootable and Shareable Disks ...................................................................... engine: Forbid Bootable and Shareable Disks A disk cannot be both bootable and shareable. Changes have been made in the backend and frontend. Also, an SQL script was added to packaging/dbscripts/upgrade. Change-Id: I8e221d6534b71db96d0c58442220d249b305079b Bug-Url: https://bugzilla.redhat.com/1084103 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_06_0230_update_disk_bootable_shareable.sql 14 files changed, 162 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e221d6534b71db96d0c58442220d249b305079b Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: adding local storage domain name to answer...
by sbonazzo＠redhat.com 19 Aug '14

19 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: adding local storage domain name to answer file ...................................................................... packaging: setup: adding local storage domain name to answer file Adding local storage domain name value to answer file to allow automated AIO setup. Change-Id: Ic3bdb5b101a4b6b3261cad62c4977b4529e77a15 Bug-Url: https://bugzilla.redhat.com/1125920 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/31664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3bdb5b101a4b6b3261cad62c4977b4529e77a15 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: ovirt-websocket-proxy fail when missing enforced key/pair
by sbonazzo＠redhat.com 19 Aug '14

19 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: ovirt-websocket-proxy fail when missing enforced key/pair ...................................................................... core: ovirt-websocket-proxy fail when missing enforced key/pair This patch makes websocket proxy fail when SSL_ONLY is set to True and key or certificate file is missing. Change-Id: I47033df4ea2c12799bb8535e1ef749967c2b4d06 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1116393 --- M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/31638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47033df4ea2c12799bb8535e1ef749967c2b4d06 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: change the signature of handleVdsMaintenanceTimeout
by ofrenkel＠redhat.com 19 Aug '14

19 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: change the signature of handleVdsMaintenanceTimeout ...................................................................... core: change the signature of handleVdsMaintenanceTimeout VdsEventListener#handleVdsMaintenanceTimeout can get just the ID of the host and not the whole VDS object. Change-Id: Iaa4a4815a1bf69ccae33bb37773a2a1a3b99a02e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/31612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa4a4815a1bf69ccae33bb37773a2a1a3b99a02e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanup in VURTI
by ofrenkel＠redhat.com 19 Aug '14

19 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: cleanup in VURTI ...................................................................... core: cleanup in VURTI - improve log printings - call getVdsEventListener to shorten few lines Change-Id: I4a0b6ab3ee60e96e9863e56d2a7d4b40a585b9fc Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 8 insertions(+), 16 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/31611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a0b6ab3ee60e96e9863e56d2a7d4b40a585b9fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix incorrect value of migrating_to_vds
by ofrenkel＠redhat.com 19 Aug '14

19 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix incorrect value of migrating_to_vds ...................................................................... core: fix incorrect value of migrating_to_vds Since we retried to switch host to maintenance as part of the monitoring thread but before the updated data from the monitoring was saved, the migrating_to_vds could have been overridden and set back to its previous value. This bug caused NPE in VURTI#handOver method sometimes and sometimes it produced a VM which is not migrating with some wrong value in its migrating_to_vds field. The solution is to retry to switch host to maintenance in the after-refresh-treatment part of the monitoring. Change-Id: I423d573ae5251d3058bdfb778a2b486ac5ea0090 Bug-Url: https://bugzilla.redhat.com/1112359 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/31610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I423d573ae5251d3058bdfb778a2b486ac5ea0090 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Fix redundant synch print message for admin user
by yzaslavs＠redhat.com 19 Aug '14

19 Aug '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Fix redundant synch print message for admin user ...................................................................... aaa: Fix redundant synch print message for admin user Change-Id: Id95552f0e7602a520d33f6d46687405327dca7f4 Topic: AAAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id95552f0e7602a520d33f6d46687405327dca7f4 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Removing unused method from DbUser
by yzaslavs＠redhat.com 19 Aug '14

19 Aug '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Removing unused method from DbUser ...................................................................... aaa: Removing unused method from DbUser Change-Id: I4268675f1859ef53c2513c76729792fb980c9815 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4268675f1859ef53c2513c76729792fb980c9815 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: Coverity fixing
by yzaslavs＠redhat.com 19 Aug '14

19 Aug '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: Coverity fixing ...................................................................... aaa: Coverity fixing Topic: AAA Change-Id: I1bb986dd9df608cac00f9387cfee7c84b65b2631 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/kerberos/KrbConfCreator.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResourceTest.java 4 files changed, 56 insertions(+), 41 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bb986dd9df608cac00f9387cfee7c84b65b2631 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: handling exception from uuid validation
by sbonazzo＠redhat.com 19 Aug '14

19 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: handling exception from uuid validation ...................................................................... packaging: setup: handling exception from uuid validation Better handling of exception from UUID validation to provide an easier to read and more consistent error. Change-Id: I505a4f01d41c218a572f6e42682b57875712f1c0 Bug-Url: https://bugzilla.redhat.com/1125834 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py 1 file changed, 19 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I505a4f01d41c218a572f6e42682b57875712f1c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0