- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: In Add Users and Groups dialog the namespace drop...
by oourfali＠redhat.com 11 Aug '14

11 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: In Add Users and Groups dialog the namespace drop down is not aligned ...................................................................... webadmin: In Add Users and Groups dialog the namespace drop down is not aligned The namespace selection drop down in add users and groups dialog is not aligned Change-Id: I9bd2f5465a047dc4616e4fa0e7f9dea2f64f9bcc Bug-Url: https://bugzilla.redhat.com/1128234 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bd2f5465a047dc4616e4fa0e7f9dea2f64f9bcc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Rename TaskManagerUtil to CommandCoordinatorUtil
by oourfali＠redhat.com 11 Aug '14

11 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : Rename TaskManagerUtil to CommandCoordinatorUtil ...................................................................... engine : Rename TaskManagerUtil to CommandCoordinatorUtil Rename TaskManagerUtil to CommandCoordinatorUtil Change-Id: Idf796edd6c0812dac03bbf1e71b637e9d2b452e5 Bug-Url: https://bugzilla.redhat.com/1127774 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandEntityCleanupManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTasksStatusesByTasksIDsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskUtils.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java 20 files changed, 68 insertions(+), 68 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf796edd6c0812dac03bbf1e71b637e9d2b452e5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Fix NPE when live migrating a disk
by tnisan＠redhat.com 11 Aug '14

11 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix NPE when live migrating a disk ...................................................................... restapi: Fix NPE when live migrating a disk Empty Guid was passed as source domain id to the MoveDisksCommand and onward. This is fixed and the actual source domain is extracted from the disk entity when moving/migrating/copying a disk. The source domain id is then used in the parameters classes. This was mocked out in the relevant tests. Change-Id: I570a4c81605b63a860c012e9071e46c34c793635 Bug-Url: https://bugzilla.redhat.com/1103499 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskResourceTest.java 4 files changed, 31 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/30975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I570a4c81605b63a860c012e9071e46c34c793635 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: Add HostTime.py in Makefile
by alitke＠redhat.com 11 Aug '14

11 Aug '14

Adam Litke has submitted this change and it was merged. Change subject: Add HostTime.py in Makefile ...................................................................... Add HostTime.py in Makefile Change-Id: Ia4a3acc382969f619ac94fc36a0f84d5ba2fcd8e Signed-off-by: Meghal Gosalia <meghal(a)yahoo-inc.com> Reviewed-on: http://gerrit.ovirt.org/31110 Reviewed-by: Adam Litke <alitke(a)redhat.com> Tested-by: Meghal .B. Gosalia <meghalgosalia(a)gmail.com> --- M mom/Collectors/Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Adam Litke: Looks good to me, approved Meghal .B. Gosalia: Verified -- To view, visit http://gerrit.ovirt.org/31110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4a3acc382969f619ac94fc36a0f84d5ba2fcd8e Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Meghal .B. Gosalia <meghalgosalia(a)gmail.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Meghal .B. Gosalia <meghalgosalia(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in mom[master]: fixed the collect method signature
by alitke＠redhat.com 11 Aug '14

11 Aug '14

Adam Litke has submitted this change and it was merged. Change subject: fixed the collect method signature ...................................................................... fixed the collect method signature Change-Id: I03d592bffe282350fede03132bebb83ff03665aa Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/31223 Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/Collectors/Collector.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Adam Litke: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/31223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03d592bffe282350fede03132bebb83ff03665aa Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: extmgr: use trace level for trace extension interaction
by yzaslavs＠redhat.com 11 Aug '14

11 Aug '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: extmgr: use trace level for trace extension interaction ...................................................................... extmgr: use trace level for trace extension interaction Change-Id: I4b8e5afa02582b9b415bff8189cd888435942fb0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionProxy.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b8e5afa02582b9b415bff8189cd888435942fb0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Truncated text box 'Custom serial number' in 'VM->...
by tnisan＠redhat.com 11 Aug '14

11 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Truncated text box 'Custom serial number' in 'VM->System' ...................................................................... webadmin: Truncated text box 'Custom serial number' in 'VM->System' Fixed by adding the proper padding. Change-Id: Id34fd0b248eb515c1b2f409a809b2dde81ee775b Bug-Url: https://bugzilla.redhat.com/1122382 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.ui.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Frank Kobzik: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id34fd0b248eb515c1b2f409a809b2dde81ee775b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: basic/advanced mode not remembered for instance type
by tnisan＠redhat.com 11 Aug '14

11 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: basic/advanced mode not remembered for instance type ...................................................................... webadmin: basic/advanced mode not remembered for instance type Only the configuration of the local storage key was missing. Change-Id: I76e719815953872fc696d0a26396c09c8e6fbb83 Bug-Url: https://bugzilla.redhat.com/1124254 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/instancetypes/InstanceTypeListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/31130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76e719815953872fc696d0a26396c09c8e6fbb83 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fix edit of sound card for running vm
by tnisan＠redhat.com 11 Aug '14

11 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fix edit of sound card for running vm ...................................................................... core: fix edit of sound card for running vm Currently, when updating the sound card setting for running vm, the query that checks if sound card exists is wrong, because sound card can have multiple types of devices (ac97,ich6) Added a code that use the "UNKNOWN" device type, to mark the mechanism to use only the general device type (sound) without the specific type. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128416 Change-Id: If2ff54c3d0929ddf04f39bb42e61e185005d9655 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java 3 files changed, 16 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/31207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2ff54c3d0929ddf04f39bb42e61e185005d9655 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.5]: upload: adding --ignore-lsc CLI options
by sbonazzo＠redhat.com 11 Aug '14

11 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: upload: adding --ignore-lsc CLI options ...................................................................... upload: adding --ignore-lsc CLI options .gz images are decompressed locally before uploading them. gzip doesn't provide accurate informations about the real uncompressed file size and so the free space on local tmp dir are checked against the maximum image size. This, with thin disk images (sparse files), is often too conservative. Adding a CLI option to ignore this kind of errors. Adding support for sparse file in the NFS copy Change-Id: I8ae3e90c4abd832891088899e713c26eac495a4d Bug-Url: https://bugzilla.redhat.com/1119798 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py M src/engine-image-uploader.8 2 files changed, 86 insertions(+), 32 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/31011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ae3e90c4abd832891088899e713c26eac495a4d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0