- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: SyncLunsInfo - avoidable executions/db deadlock
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: SyncLunsInfo - avoidable executions/db deadlock ...................................................................... core: SyncLunsInfo - avoidable executions/db deadlock Currently SyncLunsInfoForBlockStorageDomainCommand is being executed when connecting to a domain storage server. This command is resposible to check if any of the luns of the domain were changed and in case it did, update the DB accordingly. When a storage domain is being activated all of it's hosts are being connected simoltenously to the domain, which leads that SyncLunsInfoForBlockStorageDomainCommand is executed multiple times (once for each host) which is unneeded as it's exactly the same as having response from one host (even if the responses of the hosts are different, we can't decide which response is correct). When being executed simoltenously, possibly concurrent updates from the different threads can be made - as the order of the updates isn't garuanteed, there's a chance for a deadlock. This patch solves it by executes the operation for only one hosts at a time, only in case of failure (which should be rare) the engine will attempt to sync the luns through a different host. Change-Id: I725964aa51ac38bf16d83cc498c5298720031632 Bug-Url: https://bugzilla.redhat.com/1115845 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java 5 files changed, 40 insertions(+), 15 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I725964aa51ac38bf16d83cc498c5298720031632 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: drop ConnectSingleAsyncOperation
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: drop ConnectSingleAsyncOperation ...................................................................... core: drop ConnectSingleAsyncOperation This patch drops the ConnectSingleAsyncOperation and it's factory with the simple use of callables. The ConnectSingleAsyncOperation is more complicated, harder to maintain and limited than the simple use of callables (for example, results can't be returned from it at the moment). There's currently no need for that infrastructure, we can execute the needed operations from a helper or a helper method. Change-Id: I825d80da10ef3d22de7cd68a68d854374e6c136c Bug-Url: https://bugzilla.redhat.com/1115845 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperation.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java 4 files changed, 28 insertions(+), 45 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I825d80da10ef3d22de7cd68a68d854374e6c136c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: renaming connectAllHostsToPool
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: renaming connectAllHostsToPool ...................................................................... core: renaming connectAllHostsToPool connectAllHostsToPool actually connects the hosts to the related domain storage server, therefore in this patch its name was changed to connectHostsInUpToDomainStorageServer. Change-Id: I15b3cfc6f4a08350b16f252df2587bd2c7737ebe Bug-Url: https://bugzilla.redhat.com/1115845 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectDomainToStorageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DetachStorageDomainFromPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java 6 files changed, 6 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15b3cfc6f4a08350b16f252df2587bd2c7737ebe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: increment the vm generation when disk is being unplugged
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: increment the vm generation when disk is being unplugged ...................................................................... core: increment the vm generation when disk is being unplugged When a disk is being detached from a vm the vm generation should be incremented otherwise the vm's ovf won't be updated. Change-Id: I91bb0b562907e8d5be4daa8bed97acbf148fae34 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057108 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/31279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91bb0b562907e8d5be4daa8bed97acbf148fae34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Set read only in the CDA instead the constructor
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Set read only in the CDA instead the constructor ...................................................................... core: Set read only in the CDA instead the constructor Setting read only property in the disk at the CDA phase in the constructor to avoid NPE when there is no disk in the DB. Change-Id: Ib70637b4fc29a95bb73aa57a6f3f0c74d4d16ca1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128430 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified Vered Volansky: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib70637b4fc29a95bb73aa57a6f3f0c74d4d16ca1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: sdk: Update API fails in SDK & CLI for several entities
by mishka8520＠yahoo.com 10 Aug '14

10 Aug '14

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: Update API fails in SDK & CLI for several entities ...................................................................... sdk: Update API fails in SDK & CLI for several entities All update operations fail from cli and sdk Change-Id: Iaf51e314e2e8381c882031e749780811a8e14b16 Bug-Url: https://bugzilla.redhat.com/1122546 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/templates/SuperAttributesTemplate 1 file changed, 48 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/31112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf51e314e2e8381c882031e749780811a8e14b16 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: build: post ovirt-engine-reports-3.5_rc2
by ydary＠redhat.com 10 Aug '14

10 Aug '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-reports-3.5_rc2 ...................................................................... build: post ovirt-engine-reports-3.5_rc2 Change-Id: I8cf35bb81e0c6209a7863c85c23b0f43ac306f78 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cf35bb81e0c6209a7863c85c23b0f43ac306f78 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: build: ovirt-engine-reports-3.5_rc2
by ydary＠redhat.com 10 Aug '14

10 Aug '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-reports-3.5_rc2 ...................................................................... build: ovirt-engine-reports-3.5_rc2 build ovirt-engine-reports-3.5_rc2 and updated release notes. Change-Id: I1452050a53cc20fca766033c57fa4362cb55a301 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in M version.mak 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1452050a53cc20fca766033c57fa4362cb55a301 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: build: post ovirt-engine-dwh-3.5_rc2
by ydary＠redhat.com 10 Aug '14

10 Aug '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-dwh-3.5_rc2 ...................................................................... build: post ovirt-engine-dwh-3.5_rc2 Change-Id: I3bba3faea0a7fd41cfbe037265a3e90ab8d4e506 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bba3faea0a7fd41cfbe037265a3e90ab8d4e506 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: build: ovirt-engine-dwh-3.5_rc2
by ydary＠redhat.com 10 Aug '14

10 Aug '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-dwh-3.5_rc2 ...................................................................... build: ovirt-engine-dwh-3.5_rc2 build ovirt-engine-dwh-3.5_rc2 and updated telease notes. Change-Id: I1c181a8113eb943203bfc9290fd84ea65a51d8ac Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c181a8113eb943203bfc9290fd84ea65a51d8ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0