- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: shorten columns on Network->Hosts sub tab
by alkaplan＠redhat.com 10 Aug '14

10 Aug '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: shorten columns on Network->Hosts sub tab ...................................................................... webadmin: shorten columns on Network->Hosts sub tab Shortened- 1) Column Network Device Shortened and remaned- 1) "Network Device Speed"->"Speed (Mbps)" 2) "Network Device Rx (Mbps)"->"Receive (Mbps)" 3) "Network Device Tx (Mbps)"->"Transmit (Mbps)" Change-Id: I5e23d51e76ac0aba9b4b253fa04b03a0c8cb5da7 Bug-Url: https://bugzilla.redhat.com/1108062 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java 2 files changed, 10 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e23d51e76ac0aba9b4b253fa04b03a0c8cb5da7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: clear disk device address when it's being unplugged fr...
by laravot＠redhat.com 10 Aug '14

10 Aug '14

Liron Aravot has submitted this change and it was merged. Change subject: core: clear disk device address when it's being unplugged from a vm ...................................................................... core: clear disk device address when it's being unplugged from a vm Change-Id: If82c8983089916ab1c58dd0330442c3aff8d6d02 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1079697 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java A packaging/dbscripts/upgrade/03_06_0150_clear_address_for_unplugged_disks.sql M packaging/dbscripts/vm_device_sp.sql 7 files changed, 14 insertions(+), 54 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If82c8983089916ab1c58dd0330442c3aff8d6d02 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: shorten column VLAN tag on Networks main Tab
by alkaplan＠redhat.com 10 Aug '14

10 Aug '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: shorten column VLAN tag on Networks main Tab ...................................................................... webadmin: shorten column VLAN tag on Networks main Tab Change-Id: I7b08ce09cc2899a049c48d713f9457a09b41218b Bug-Url: https://bugzilla.redhat.com/1108072 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b08ce09cc2899a049c48d713f9457a09b41218b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Coverity defect CID 1230096 (FB.BC_UNCONFIRMED_CAST)
by lvernia＠redhat.com 10 Aug '14

10 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Coverity defect CID 1230096 (FB.BC_UNCONFIRMED_CAST) ...................................................................... webadmin: Coverity defect CID 1230096 (FB.BC_UNCONFIRMED_CAST) Replaced unsafe cast with properly-parameterized event. Change-Id: Ib9ab0cf699d0f0cfeda5a3462527565b31edce7d Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9ab0cf699d0f0cfeda5a3462527565b31edce7d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix confusing names in async tasks
by emesika＠redhat.com 10 Aug '14

10 Aug '14

Eli Mesika has submitted this change and it was merged. Change subject: engine: Fix confusing names in async tasks ...................................................................... engine: Fix confusing names in async tasks Fix confusing name for action and command parameters in AsyncTasks and Command Entities Change-Id: I6e619857ae36f1b69a4370ddcf53aee45c2c2c6f Bug-Url: https://bugzilla.redhat.com/1127774 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CommandEntity.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CommandEntityDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/CommandEntityDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/async_tasks_sp.sql M packaging/dbscripts/command_entities_sp.sql A packaging/dbscripts/upgrade/03_06_0140_rename_async_tasks_columns.sql 12 files changed, 61 insertions(+), 50 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e619857ae36f1b69a4370ddcf53aee45c2c2c6f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Coverity defect CID 1230097 (FB.BC_UNCONFIRMED_CAST)
by lvernia＠redhat.com 10 Aug '14

10 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Coverity defect CID 1230097 (FB.BC_UNCONFIRMED_CAST) ...................................................................... webadmin: Coverity defect CID 1230097 (FB.BC_UNCONFIRMED_CAST) Swapped unsafe cast for properly-parameterized event. Change-Id: I2b42060e7b906b1172d1f823d63c6fbcf1703fdd Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b42060e7b906b1172d1f823d63c6fbcf1703fdd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Coverity defect CID 1230278 (FB.BC_UNCONFIRMED_CAST)
by lvernia＠redhat.com 10 Aug '14

10 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Coverity defect CID 1230278 (FB.BC_UNCONFIRMED_CAST) ...................................................................... webadmin: Coverity defect CID 1230278 (FB.BC_UNCONFIRMED_CAST) Swapped unsafe cast for a properly-parameterized event listener. Change-Id: Ied30d82a0ae72acecf504d3307ae1a9f7f35c220 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/MacPoolModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied30d82a0ae72acecf504d3307ae1a9f7f35c220 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: jsonrpc: Protocol decision based on cluser compatibility ver...
by oourfali＠redhat.com 10 Aug '14

10 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: jsonrpc: Protocol decision based on cluser compatibility version ...................................................................... jsonrpc: Protocol decision based on cluser compatibility version Engine decides which protocol to use depending on cluster compatibility version when there was no manual protocol override (UI or REST). When cluser compatibility verions is set to 3.5 or higher jsonrpc over stomp is used and for older versions xmlrpc is used. Next step is to disable user override option when we confirm that jsonrpc is stable enough. Bug-Url: https://bugzilla.redhat.com/1081049 Change-Id: I63e857be667095f62de7ed5e6a81b25a41e917f4 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStaticDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStatisticsDAOTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 10 files changed, 63 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63e857be667095f62de7ed5e6a81b25a41e917f4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Parameterize PropertyChangedEvent
by lvernia＠redhat.com 10 Aug '14

10 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Parameterize PropertyChangedEvent ...................................................................... webadmin: Parameterize PropertyChangedEvent Rendered the PropertyChangedEvent of Model generic, and parameterized it with PropertyChangedEventArgs. Change-Id: I6d5e2363ad44c9432f49dc50f5715a836c327189 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d5e2363ad44c9432f49dc50f5715a836c327189 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Parameterize Event and IEventListener
by lvernia＠redhat.com 10 Aug '14

10 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Parameterize Event and IEventListener ...................................................................... webadmin: Parameterize Event and IEventListener This to further promote type-safety and not have to unsafely-cast specific event arguments. Also took the chance to parameterize an event in ReportsListModel (it wouldn't compile off the bat, and I preferred to parameterize properly than add a cast). Change-Id: I1ad96ebbc2a4d2baff514d53dba8a222a08d1306 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Event.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IEventListener.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabReportsPresenter.java 4 files changed, 24 insertions(+), 23 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ad96ebbc2a4d2baff514d53dba8a222a08d1306 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0