- Engine-commits - oVirt List Archives

Change in jenkins[master]: jobs: preserve suffix while building in mock
by dcaroest＠redhat.com 08 Aug '14

08 Aug '14

David Caro has submitted this change and it was merged. Change subject: jobs: preserve suffix while building in mock ...................................................................... jobs: preserve suffix while building in mock Preserve the suffix used while building the src.rpm also when building rpms in mock. Also creates a vault directory on $WORKSPACE/tmp for all the jobs that get removed and created at the start of the job Change-Id: Ie5e4cd292a2c9c8b641ca57e31b80f5a05b81e68 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/shell-scripts/build_local_srcrpm.sh M jobs/confs/shell-scripts/build_mock_srcrpm.sh A jobs/confs/shell-scripts/global_setup.sh M jobs/confs/shell-scripts/mock_build_onlyrpm.sh M jobs/confs/yaml/builders/mock_install.yaml M jobs/confs/yaml/builders/rpm_mock.yaml 6 files changed, 23 insertions(+), 0 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5e4cd292a2c9c8b641ca57e31b80f5a05b81e68 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-image-uploader[master]: upload: adding --ignore-lsc CLI options
by sbonazzo＠redhat.com 08 Aug '14

08 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: upload: adding --ignore-lsc CLI options ...................................................................... upload: adding --ignore-lsc CLI options .gz images are decompressed locally before uploading them. gzip doesn't provide accurate informations about the real uncompressed file size and so the free space on local tmp dir are checked against the maximum image size. This, with thin disk images (sparse files), is often too conservative. Adding a CLI option to ignore this kind of errors. Adding support for sparse file in the NFS copy Change-Id: I8ae3e90c4abd832891088899e713c26eac495a4d Bug-Url: https://bugzilla.redhat.com/1119798 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py M src/engine-image-uploader.8 2 files changed, 86 insertions(+), 32 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/31005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ae3e90c4abd832891088899e713c26eac495a4d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: jsonrpc: Protocol decision based on cluser compatibility ver...
by oourfali＠redhat.com 08 Aug '14

08 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: jsonrpc: Protocol decision based on cluser compatibility version ...................................................................... jsonrpc: Protocol decision based on cluser compatibility version Engine decides which protocol to use depending on cluster compatibility version when there was no manual protocol override (UI or REST). When cluser compatibility verions is set to 3.5 or higher jsonrpc over stomp is used and for older versions xmlrpc is used. Next step is to disable user override option when we confirm that jsonrpc is stable enough. Change-Id: I63e857be667095f62de7ed5e6a81b25a41e917f4 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStaticDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStatisticsDAOTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 10 files changed, 62 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63e857be667095f62de7ed5e6a81b25a41e917f4 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi : Create user API fails in SDK & CLI fails
by piotr.kliczewski＠gmail.com 08 Aug '14

08 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi : Create user API fails in SDK & CLI fails ...................................................................... restapi : Create user API fails in SDK & CLI fails Create user fails with error HTTP 400 Request syntactically incorrect from SDK and CLI Change-Id: I308f5ebe3a7bcd4d980c7186fa995c704938ec93 Bug-Url: https://bugzilla.redhat.com/1122589 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/JobMapper.java 2 files changed, 10 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31221 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I308f5ebe3a7bcd4d980c7186fa995c704938ec93 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : Zombie tasks should endWithFailure
by piotr.kliczewski＠gmail.com 08 Aug '14

08 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine : Zombie tasks should endWithFailure ...................................................................... engine : Zombie tasks should endWithFailure Zombie tasks that are stopped and cleared should be marked so they end in failure Change-Id: I01125b507ab116440277bebdd7190a7daecbd810 Bug-Url: https://bugzilla.redhat.com/1122639 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/SPMTask.java 3 files changed, 16 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01125b507ab116440277bebdd7190a7daecbd810 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine : Use java naming conventions
by piotr.kliczewski＠gmail.com 08 Aug '14

08 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine : Use java naming conventions ...................................................................... engine : Use java naming conventions Use java naming conventions for method names instead of csharp naming convention Change-Id: I8ab86d97dbf1c94dd887c5ccc2a438a41ccd1f37 Bug-Url: https://bugzilla.redhat.com/1122639 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java 2 files changed, 60 insertions(+), 60 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ab86d97dbf1c94dd887c5ccc2a438a41ccd1f37 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Persist command at end of execution
by oourfali＠redhat.com 08 Aug '14

08 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Persist command at end of execution ...................................................................... engine: Persist command at end of execution Persist command at the end of command execution Change-Id: I1610e115fb215b9f2dcd587a41c748580f98260d Bug-Url: https://bugzilla.redhat.com/1127774 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/TaskManagerUtil.java 2 files changed, 28 insertions(+), 12 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1610e115fb215b9f2dcd587a41c748580f98260d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Change text of "Enable optional reason" selection box
by piotr.kliczewski＠gmail.com 08 Aug '14

08 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Change text of "Enable optional reason" selection box ...................................................................... webadmin: Change text of "Enable optional reason" selection box Change the text of the checkbox to enable optional reason Change-Id: I76d514cc795271a50f91185a9be3805768876b84 Bug-Url: https://bugzilla.redhat.com/1126432 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76d514cc795271a50f91185a9be3805768876b84 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix name textbox size/alignment on Clone Vm From S...
by piotr.kliczewski＠gmail.com 08 Aug '14

08 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Fix name textbox size/alignment on Clone Vm From Snapshot ...................................................................... webadmin: Fix name textbox size/alignment on Clone Vm From Snapshot Change-Id: I2f865deab00cab1e56fd39e6b2f9a00f507c4a26 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126215 Signed-off-by: Martin Betak <mbetak(a)redhat.com> Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 2 files changed, 26 insertions(+), 15 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Martin Betak: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f865deab00cab1e56fd39e6b2f9a00f507c4a26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: JUnit rule for testing UiCommon models
by vszocs＠redhat.com 07 Aug '14

07 Aug '14

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: JUnit rule for testing UiCommon models ...................................................................... webadmin,userportal: JUnit rule for testing UiCommon models This patch adds a JUnit TestRule used to set up the necessary UiCommon infrastructure in order to test individual UiCommon models. This TestRule ensures that hidden expectations of UiCommon models (represented by static method calls) are satisfied and provides a 'Mocks' interface for stubbing the infrastructure behavior, if necessary. Example - UiCommon infrastructure setup per test class: public class MyTest { @ClassRule public static UiCommonSetup setup = new UiCommonSetup(); // This is optional, but often necessary @BeforeClass public static void stubUiCommonInfra() { AsyncDataProvider adp = setup.getMocks().asyncDataProvider(); when(adp.isWindowsOsType(anyInt())).thenReturn(true); } // Actual test code to exercise model instance(s) } Example - UiCommon infrastructure setup per test method: public class MyTest { @Rule public UiCommonSetup setup = new UiCommonSetup(); // This is optional, but often necessary @Before public void stubUiCommonInfra() { AsyncDataProvider adp = setup.getMocks().asyncDataProvider(); when(adp.isWindowsOsType(anyInt())).thenReturn(true); } // Actual test code to exercise model instance(s) } Existing test code was modified to utilize UiCommonSetup rule. Change-Id: Ifca6bf6a6b77813fa90f419ccfe2ef9f2cd09561 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/junit/UiCommonSetup.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmTest.java 3 files changed, 173 insertions(+), 39 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Allon Mureinik: Verified Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifca6bf6a6b77813fa90f419ccfe2ef9f2cd09561 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0