- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Host life cycle broken for jsonrpc
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Host life cycle broken for jsonrpc ...................................................................... core: Host life cycle broken for jsonrpc Networking issue was translated to VDSErrorException whereas it should be translated to VDSNetworkException Bug-Url: https://bugzilla.redhat.com/1127685 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Change-Id: I9f6921510c9f42f55c5cc9ec8d8a6daff215c52d (cherry picked from commit 6c261dc6188f8d345567393c8d475488abf78e3f) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f6921510c9f42f55c5cc9ec8d8a6daff215c52d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: css: make profile selection in "add users and grou...
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: css: make profile selection in "add users and groups" dialog wider. ...................................................................... webadmin: css: make profile selection in "add users and groups" dialog wider. Widening the parent div prevents misalignment in locals where The 'Search:' label is longer than english (e.g fr). Change-Id: Id4b46a36bd676605067706b718ad8893f470ffab Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1123780 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> (cherry picked from commit 8adf3b42ff70d3b1a162bf6fd1dd5559467a2b45) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4b46a36bd676605067706b718ad8893f470ffab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Host life cycle broken for jsonrpc
by oourfali＠redhat.com 07 Aug '14

07 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Host life cycle broken for jsonrpc ...................................................................... core: Host life cycle broken for jsonrpc Networking issue was translated to VDSErrorException whereas it should be translated to VDSNetworkException Bug-Url: https://bugzilla.redhat.com/1127685 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Change-Id: I9f6921510c9f42f55c5cc9ec8d8a6daff215c52d --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f6921510c9f42f55c5cc9ec8d8a6daff215c52d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Enhanced permissions logging
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Enhanced permissions logging ...................................................................... core: Enhanced permissions logging During permission check when logging level is set to DEBUG there is more information about which user is being checked and on which objects. When permission is not found it is logged to INFO level. Bug-Url: https://bugzilla.redhat.com/1121617 Change-Id: I4ba8fa00b8d28679b9896fe707623af89ac3c01f Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java 2 files changed, 53 insertions(+), 14 deletions(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ba8fa00b8d28679b9896fe707623af89ac3c01f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: making sure not throw NPE when opening SPICE console
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: making sure not throw NPE when opening SPICE console ...................................................................... core: making sure not throw NPE when opening SPICE console When processing console request we get username from db and perform contains and substring on it. We did not check whether the name is null. This patch introduces this check. Bug-Url: https://bugzilla.redhat.com/1120692 Change-Id: Idd5f4a33f8fc5c41faead26afd7ce91c2412ac16 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd5f4a33f8fc5c41faead26afd7ce91c2412ac16 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[master]: build: fixed ovirt master snapshot url
by sbonazzo＠redhat.com 07 Aug '14

07 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: fixed ovirt master snapshot url ...................................................................... build: fixed ovirt master snapshot url Change-Id: I60a977f15370efb928657e5135424a976cc1c7eb Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/kickstart/ovirt-live-base.ks.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60a977f15370efb928657e5135424a976cc1c7eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Removal of labelled network from DC inconsistent with ...
by lvernia＠redhat.com 07 Aug '14

07 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Removal of labelled network from DC inconsistent with removal from cluster ...................................................................... core: Removal of labelled network from DC inconsistent with removal from cluster - when removing labeled network from dc, "remove [that] network from host". I.e. call PersistentSetupNetworks so that given network is removed from host. Change-Id: I9ebc162324ff2ed98374d6a9a3bd9d87bb69db3f Bug-Url: https://bugzilla.redhat.com/1091692 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java 5 files changed, 78 insertions(+), 25 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ebc162324ff2ed98374d6a9a3bd9d87bb69db3f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: Changing foreman provider data loading
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: ui: Changing foreman provider data loading ...................................................................... ui: Changing foreman provider data loading When selected new provider the addHost external provider form fields will be cleaned and blocked till all provider's info will be loaded. In this patch we also change the update method which now retrieves all provider's info in each call, instead of loading only part of the information. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1124842 Change-Id: Ie01a6c8b6d6f7e58a6057fc211ab5e4605bbe310 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java 2 files changed, 63 insertions(+), 63 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie01a6c8b6d6f7e58a6057fc211ab5e4605bbe310 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: add host_provider_id to vdsStatic
by piotr.kliczewski＠gmail.com 07 Aug '14

07 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: add host_provider_id to vdsStatic ...................................................................... core: add host_provider_id to vdsStatic This allows to sign the provider id, which in hosts mostly foreman server id that added as external provider. With saving the ID we'll be able to gather more info about the host later on. Change-Id: Icced7dda43fee83aa904a068cff48b1fd3da4b76 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1113003 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_0830_add_provider_host_id_vdsstatic.sql M packaging/dbscripts/vds_sp.sql 12 files changed, 56 insertions(+), 22 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icced7dda43fee83aa904a068cff48b1fd3da4b76 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Enhanced permissions logging
by oourfali＠redhat.com 07 Aug '14

07 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Enhanced permissions logging ...................................................................... core: Enhanced permissions logging During permission check when logging level is set to DEBUG there is more information about which user is being checked and on which objects. When permission is not found it is logged to INFO level. Bug-Url: https://bugzilla.redhat.com/1121617 Change-Id: I4ba8fa00b8d28679b9896fe707623af89ac3c01f Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java 2 files changed, 53 insertions(+), 14 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ba8fa00b8d28679b9896fe707623af89ac3c01f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0