- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Include VdsSpmIdMapDAODbFacadeImpl.get(vdsId) in VdsSp...
by emesika＠redhat.com 06 Aug '14

06 Aug '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Include VdsSpmIdMapDAODbFacadeImpl.get(vdsId) in VdsSpmIdMapDAO ...................................................................... core: Include VdsSpmIdMapDAODbFacadeImpl.get(vdsId) in VdsSpmIdMapDAO Adds method VdsSpmIdMapDAODbFacadeImpl.get(vdsId) in VdsSpmIdMapDAO so it can be used in engine. Change-Id: Ic590281545123788ce62c740901c69de0ed00c33 Bug-Url: https://bugzilla.redhat.com/1090799 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsSpmIdMapDAO.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic590281545123788ce62c740901c69de0ed00c33 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Suppress kdump not configured warning when PM is off
by piotr.kliczewski＠gmail.com 06 Aug '14

06 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Suppress kdump not configured warning when PM is off ...................................................................... core: Suppress kdump not configured warning when PM is off Suppresses displaying warning "Kdump integration is enabled for host 'dev-21', but kdump is not configured properly on host." when host become Up and its power management is turned off. Change-Id: I8989c83bf7b9c08bd839c81c30f6f1b0edf31322 Bug-Url: https://bugzilla.redhat.com/1125206 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8989c83bf7b9c08bd839c81c30f6f1b0edf31322 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Introduce createFenceExecutor method
by emesika＠redhat.com 06 Aug '14

06 Aug '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Introduce createFenceExecutor method ...................................................................... core: Introduce createFenceExecutor method Introduces createFenceExecutor() method with fence action type as a parameter, which will create FenceExecutor instance with specified fence action type and other parameters with default values. Change-Id: Id4630801fc7b6940caabb646c653ef10df3f63a4 Bug-Url: https://bugzilla.redhat.com/1090799 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 22 insertions(+), 12 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4630801fc7b6940caabb646c653ef10df3f63a4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Truncation in instance type -> Random Generator
by piotr.kliczewski＠gmail.com 06 Aug '14

06 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Truncation in instance type -> Random Generator ...................................................................... webadmin: Truncation in instance type -> Random Generator The problem was that the section was not defined with the sectionPanel style Change-Id: I96382e2ab92e816866da740525691bdcd4411ff7 Bug-Url: https://bugzilla.redhat.com/1122423 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Frank Kobzik: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96382e2ab92e816866da740525691bdcd4411ff7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Refactor FenceVdsActionParameters
by emesika＠redhat.com 06 Aug '14

06 Aug '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Refactor FenceVdsActionParameters ...................................................................... core: Refactor FenceVdsActionParameters Refactors FenceVdsActionParameters: 1) Moves instance attributes before methods 2) Remove '_' from attribute names 3) Use constructor chaining 4) Set default values of instance variables in constructor Change-Id: I43bc8d5336633cf0f259d08803d2e902be006791 Bug-Url: https://bugzilla.redhat.com/1090799 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43bc8d5336633cf0f259d08803d2e902be006791 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add FencingPolicy to cluster configuration
by emesika＠redhat.com 06 Aug '14

06 Aug '14

Eli Mesika has submitted this change and it was merged. Change subject: webadmin: Add FencingPolicy to cluster configuration ...................................................................... webadmin: Add FencingPolicy to cluster configuration Adds Fencing Policy tab to cluster detail. Adds option to skip fencing of host if it's connected to at least one storage domain to Fencing Policy tab. Change-Id: Iaecc1662324ce3d3072c9e850fcf8026ccfab0b2 Bug-Url: https://bugzilla.redhat.com/1090799 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 9 files changed, 111 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaecc1662324ce3d3072c9e850fcf8026ccfab0b2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Introduce FencingPolicy
by emesika＠redhat.com 06 Aug '14

06 Aug '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Introduce FencingPolicy ...................................................................... core: Introduce FencingPolicy Adds FencingPolicy as a part of cluster configuration. The 1st option added to FencingPolicy is the ability to skip fencing of host if it's connected to at least one storage domain Change-Id: I7dfcd571b8329174f8d3acccf7136d0b5f83cacc Bug-Url: https://bugzilla.redhat.com/1090799 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FencingPolicy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/FencingPolicyHelper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/03_06_0120_skip_fencing_when_sd_is_alive.sql M packaging/dbscripts/vds_groups_sp.sql 7 files changed, 151 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7dfcd571b8329174f8d3acccf7136d0b5f83cacc Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add config value to enable to skip fencing if SD is ac...
by emesika＠redhat.com 06 Aug '14

06 Aug '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Add config value to enable to skip fencing if SD is active ...................................................................... core: Add config value to enable to skip fencing if SD is active Adds config value to enable feature to skip fencing of host when it's connected to at least one storage domain. Change-Id: If9f1e480a5cedb7988eba37701c3db7b3950c010 Bug-Url: https://bugzilla.redhat.com/1090799 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 4 files changed, 25 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9f1e480a5cedb7988eba37701c3db7b3950c010 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix name textbox size/alignment on Clone Vm From S...
by awels＠redhat.com 06 Aug '14

06 Aug '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Fix name textbox size/alignment on Clone Vm From Snapshot ...................................................................... webadmin: Fix name textbox size/alignment on Clone Vm From Snapshot Change-Id: I2f865deab00cab1e56fd39e6b2f9a00f507c4a26 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126215 Signed-off-by: Martin Betak <mbetak(a)redhat.com> Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 2 files changed, 26 insertions(+), 15 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/31034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f865deab00cab1e56fd39e6b2f9a00f507c4a26 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Change how Affinity behaves if the assumptions are inv...
by oourfali＠redhat.com 06 Aug '14

06 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Change how Affinity behaves if the assumptions are invalid ...................................................................... core: Change how Affinity behaves if the assumptions are invalid This fixes the situation when VMs belonging to the same hard constraint positive affinity group are actually running on more than one host. It used to fail the scheduling task for any VM belonging to the same affinity group (both new VMs and migrating ones). This patch just passes all hosts with VM from that group to the weighting mechanism making it possible for the balancer or administrator to recover from this situation. This change also makes it easier to report per host scheduling information which we need for the following patches. Change-Id: I506bcb6e96c622694e6bf7b8ce7a0f54a82e5713 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122446 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 08971784344624f526287d510adc5cb0ef297403) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java 1 file changed, 43 insertions(+), 48 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I506bcb6e96c622694e6bf7b8ce7a0f54a82e5713 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0