- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core: calculating the maxVcpus in the limits of qemu
by oourfali＠redhat.com 06 Aug '14

06 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: calculating the maxVcpus in the limits of qemu ...................................................................... core: calculating the maxVcpus in the limits of qemu calulate the right maxVCpus we send to VDSM to be in the limits of qemu max number of sockets. this eliminates the need to send an extra argument to VDSM maxNumberOfSockets and eliminates an API change. Change-Id: I452d0614406ed5e9e20ac3212a5d07e7a4e4b269 Bug-Url: https://bugzilla.redhat.com/1070890 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 1 file changed, 15 insertions(+), 6 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I452d0614406ed5e9e20ac3212a5d07e7a4e4b269 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: calculating the maxVcpus in the limits of qemu
by oourfali＠redhat.com 06 Aug '14

06 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: calculating the maxVcpus in the limits of qemu ...................................................................... core: calculating the maxVcpus in the limits of qemu calulate the right maxVCpus we send to VDSM to be in the limits of qemu max number of sockets. this eliminates the need to send an extra argument to VDSM maxNumberOfSockets and eliminates an API change. Change-Id: I452d0614406ed5e9e20ac3212a5d07e7a4e4b269 Bug-Url: https://bugzilla.redhat.com/1070890 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 2 files changed, 8 insertions(+), 9 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I452d0614406ed5e9e20ac3212a5d07e7a4e4b269 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi : Create user API fails in SDK & CLI fails
by oourfali＠redhat.com 06 Aug '14

06 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: restapi : Create user API fails in SDK & CLI fails ...................................................................... restapi : Create user API fails in SDK & CLI fails Create user fails with error HTTP 400 Request syntactically incorrect from SDK and CLI Change-Id: I308f5ebe3a7bcd4d980c7186fa995c704938ec93 Bug-Url: https://bugzilla.redhat.com/1122589 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/JobMapper.java 2 files changed, 10 insertions(+), 3 deletions(-) Approvals: Ori Liel: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/31107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I308f5ebe3a7bcd4d980c7186fa995c704938ec93 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: search: vms.uptime is not working
by piotr.kliczewski＠gmail.com 06 Aug '14

06 Aug '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: search: vms.uptime is not working ...................................................................... engine: search: vms.uptime is not working when searching for vms: vms.uptime > 01:00 we use the TimeSpan.TotalSeconds which is always zero (we never pass the seconds only days, hours and minutes) instead of using the TimeSpan.TotalMilliseconds which hold the true total time. Bug-Url: https://bugzilla.redhat.com/1005805 Change-Id: I322a253557c71888307a60e7ae685dd38d637543 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I322a253557c71888307a60e7ae685dd38d637543 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: increment the vm generation when disk is being unplugged
by laravot＠redhat.com 06 Aug '14

06 Aug '14

Liron Aravot has submitted this change and it was merged. Change subject: core: increment the vm generation when disk is being unplugged ...................................................................... core: increment the vm generation when disk is being unplugged When a disk is being detached from a vm the vm generation should be incremented otherwise the vm's ovf won't be updated. Change-Id: I91bb0b562907e8d5be4daa8bed97acbf148fae34 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057108 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91bb0b562907e8d5be4daa8bed97acbf148fae34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: calculating the maxVcpus in the limits of qemu
by ofrenkel＠redhat.com 06 Aug '14

06 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: calculating the maxVcpus in the limits of qemu ...................................................................... core: calculating the maxVcpus in the limits of qemu calulate the right maxVCpus we send to VDSM to be in the limits of qemu max number of sockets. this eliminates the need to send an extra argument to VDSM maxNumberOfSockets and eliminates an API change. Change-Id: I452d0614406ed5e9e20ac3212a5d07e7a4e4b269 Bug-Url: https://bugzilla.redhat.com/1070890 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 2 files changed, 8 insertions(+), 9 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I452d0614406ed5e9e20ac3212a5d07e7a4e4b269 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-live[master]: build: post ovirt-live-3.5 branching
by sbonazzo＠redhat.com 06 Aug '14

06 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-live-3.5 branching ...................................................................... build: post ovirt-live-3.5 branching Change-Id: Id81519b6719110e6c7d15969f9ce59fa0634b4cd Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile M centos/kickstart/ovirt-live-base.ks.in 2 files changed, 7 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id81519b6719110e6c7d15969f9ce59fa0634b4cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.5]: build: ovirt-live-3.5.0_rc1
by sbonazzo＠redhat.com 06 Aug '14

06 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.5.0_rc1 ...................................................................... build: ovirt-live-3.5.0_rc1 Change-Id: I25e489e5621da6931483696b577d2b8b699670f2 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25e489e5621da6931483696b577d2b8b699670f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: spm local in DeactivateStorageDomainCommand
by laravot＠redhat.com 06 Aug '14

06 Aug '14

Liron Aravot has submitted this change and it was merged. Change subject: core: spm local in DeactivateStorageDomainCommand ...................................................................... core: spm local in DeactivateStorageDomainCommand Change-Id: I48155e8bf5649f7485dfcb80df2d3eb18949c961 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Federico Simoncelli: Verified Allon Mureinik: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48155e8bf5649f7485dfcb80df2d3eb18949c961 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: early domain check in electNewMaster
by laravot＠redhat.com 06 Aug '14

06 Aug '14

Liron Aravot has submitted this change and it was merged. Change subject: core: early domain check in electNewMaster ...................................................................... core: early domain check in electNewMaster This patch improves the readability of electNewMaster. Change-Id: Iaf651cf670cffa2aea1443ee33153421785534a4 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 25 insertions(+), 20 deletions(-) Approvals: Federico Simoncelli: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf651cf670cffa2aea1443ee33153421785534a4 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0